<rdar://problem/13069948>
Major fixed to allow reading files that are over 4GB. The main problems were that the DataExtractor was using 32 bit offsets as a data cursor, and since we mmap all of our object files we could run into cases where if we had a very large core file that was over 4GB, we were running into the 4GB boundary. So I defined a new "lldb::offset_t" which should be used for all file offsets. After making this change, I enabled warnings for data loss and for enexpected implicit conversions temporarily and found a ton of things that I fixed. Any functions that take an index internally, should use "size_t" for any indexes and also should return "size_t" for any sizes of collections. llvm-svn: 173463
This commit is contained in:
@@ -316,8 +316,14 @@ PythonDictionary::GetItemForKeyAsInteger (const PythonString &key, int64_t fail_
|
||||
if (m_py_obj && key)
|
||||
{
|
||||
PyObject *py_obj = PyDict_GetItem(m_py_obj, key.GetPythonObject());
|
||||
if (py_obj && PyInt_Check(py_obj))
|
||||
return PyInt_AsLong(py_obj);
|
||||
if (py_obj)
|
||||
{
|
||||
if (PyInt_Check(py_obj))
|
||||
return PyInt_AsLong(py_obj);
|
||||
|
||||
if (PyLong_Check(py_obj))
|
||||
return PyLong_AsLong(py_obj);
|
||||
}
|
||||
}
|
||||
return fail_value;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user