caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace 'ap' with 'up' suffix in variable names. (NFC)

Browse Source 
The `ap` suffix is a remnant of lldb's former use of auto pointers,
before they got deprecated. Although all their uses were replaced by
unique pointers, some variables still carried the suffix.

In r353795 I removed another auto_ptr remnant, namely redundant calls to
::get for unique_pointers. Jim justly noted that this is a good
opportunity to clean up the variable names as well.

I went over all the changes to ensure my find-and-replace didn't have
any undesired side-effects. I hope I didn't miss any, but if you end up
at this commit doing a git blame on a weirdly named variable, please
know that the change was unintentional.

llvm-svn: 353912
This commit is contained in:
Jonas Devlieghere
2019-02-13 06:25:41 +00:00
parent 5cf777e413
commit d5b440369d
190 changed files with 1963 additions and 1959 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp
View File

@@ -115,18 +115,18 @@ Symtab *ObjectFileJIT::GetSymtab() {
ModuleSP module_sp(GetModule());
if (module_sp) {
std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
if (m_symtab_ap == NULL) {
m_symtab_ap.reset(new Symtab(this));
if (m_symtab_up == NULL) {
m_symtab_up.reset(new Symtab(this));
std::lock_guard<std::recursive_mutex> symtab_guard(
m_symtab_ap->GetMutex());
m_symtab_up->GetMutex());
ObjectFileJITDelegateSP delegate_sp(m_delegate_wp.lock());
if (delegate_sp)
delegate_sp->PopulateSymtab(this, *m_symtab_ap);
delegate_sp->PopulateSymtab(this, *m_symtab_up);
// TODO: get symbols from delegate
m_symtab_ap->Finalize();
m_symtab_up->Finalize();
}
}
return m_symtab_ap.get();
return m_symtab_up.get();
}
bool ObjectFileJIT::IsStripped() {
@@ -134,12 +134,12 @@ bool ObjectFileJIT::IsStripped() {
}
void ObjectFileJIT::CreateSections(SectionList &unified_section_list) {
if (!m_sections_ap) {
m_sections_ap.reset(new SectionList());
if (!m_sections_up) {
m_sections_up.reset(new SectionList());
ObjectFileJITDelegateSP delegate_sp(m_delegate_wp.lock());
if (delegate_sp) {
delegate_sp->PopulateSectionList(this, *m_sections_ap);
unified_section_list = *m_sections_ap;
delegate_sp->PopulateSectionList(this, *m_sections_up);
unified_section_list = *m_sections_up;
}
}
}
@@ -161,8 +161,8 @@ void ObjectFileJIT::Dump(Stream *s) {
if (sections)
sections->Dump(s, NULL, true, UINT32_MAX);
if (m_symtab_ap)
m_symtab_ap->Dump(s, NULL, eSortOrderNone);
if (m_symtab_up)
m_symtab_up->Dump(s, NULL, eSortOrderNone);
}
}