caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[libc++] Add noexcept to string::find and similar members.

Browse Source 
Adds `noexcept` to `string_view`/`string::find` and similar members
(`rfind`, etc.). See discussion in D95251. Refs D95821.

Reviewed By: curdeius, ldionne

Differential Revision: https://reviews.llvm.org/D95848
This commit is contained in:
zoecarver
2021-02-05 11:54:47 -08:00
parent 59c1139d3e
commit dea74b2820
60 changed files with 139 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libcxx/test/std/strings/basic.string/string.ops/string_rfind/char_size.pass.cpp
View File

@@ -21,6 +21,7 @@ void
test(const S& s, typename S::value_type c, typename S::size_type pos,
typename S::size_type x)
{
LIBCPP_ASSERT_NOEXCEPT(s.rfind(c, pos));
assert(s.rfind(c, pos) == x);
if (x != S::npos)
assert(x <= pos && x + 1 <= s.size());
@@ -30,6 +31,7 @@ template <class S>
void
test(const S& s, typename S::value_type c, typename S::size_type x)
{
LIBCPP_ASSERT_NOEXCEPT(s.rfind(c));
assert(s.rfind(c) == x);
if (x != S::npos)
assert(x + 1 <= s.size());

2
libcxx/test/std/strings/basic.string/string.ops/string_rfind/pointer_size.pass.cpp
View File

@@ -21,6 +21,7 @@ void
test(const S& s, const typename S::value_type* str, typename S::size_type pos,
typename S::size_type x)
{
LIBCPP_ASSERT_NOEXCEPT(s.rfind(str, pos));
assert(s.rfind(str, pos) == x);
if (x != S::npos)
{
@@ -33,6 +34,7 @@ template <class S>
void
test(const S& s, const typename S::value_type* str, typename S::size_type x)
{
LIBCPP_ASSERT_NOEXCEPT(s.rfind(str));
assert(s.rfind(str) == x);
if (x != S::npos)
{

1
libcxx/test/std/strings/basic.string/string.ops/string_rfind/pointer_size_size.pass.cpp
View File

@@ -21,6 +21,7 @@ void
test(const S& s, const typename S::value_type* str, typename S::size_type pos,
typename S::size_type n, typename S::size_type x)
{
LIBCPP_ASSERT_NOEXCEPT(s.rfind(str, pos, n));
assert(s.rfind(str, pos, n) == x);
if (x != S::npos)
assert(x <= pos && x + n <= s.size());

2
libcxx/test/std/strings/basic.string/string.ops/string_rfind/string_size.pass.cpp
View File

@@ -20,6 +20,7 @@ template <class S>
void
test(const S& s, const S& str, typename S::size_type pos, typename S::size_type x)
{
LIBCPP_ASSERT_NOEXCEPT(s.rfind(str, pos));
assert(s.rfind(str, pos) == x);
if (x != S::npos)
assert(x <= pos && x + str.size() <= s.size());
@@ -29,6 +30,7 @@ template <class S>
void
test(const S& s, const S& str, typename S::size_type x)
{
LIBCPP_ASSERT_NOEXCEPT(s.rfind(str));
assert(s.rfind(str) == x);
if (x != S::npos)
assert(0 <= x && x + str.size() <= s.size());

2
libcxx/test/std/strings/basic.string/string.ops/string_rfind/string_view_size.pass.cpp
View File

@@ -20,6 +20,7 @@ template <class S, class SV>
void
test(const S& s, SV sv, typename S::size_type pos, typename S::size_type x)
{
LIBCPP_ASSERT_NOEXCEPT(s.rfind(sv, pos));
assert(s.rfind(sv, pos) == x);
if (x != S::npos)
assert(x <= pos && x + sv.size() <= s.size());
@@ -29,6 +30,7 @@ template <class S, class SV>
void
test(const S& s, SV sv, typename S::size_type x)
{
LIBCPP_ASSERT_NOEXCEPT(s.rfind(sv));
assert(s.rfind(sv) == x);
if (x != S::npos)
assert(0 <= x && x + sv.size() <= s.size());