caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a bug in the breakpoint ID verifier in CommandObjectBreakpoint. (#145994)

Browse Source 
It was assuming that for any location M.N, N was always less than the
number of breakpoint locations. But if you rebuild the target and rerun
multiple times, when the section backing one of the locations is no
longer valid, we remove the location, but we don't reuse the ID. So you
can have a breakpoint that only has location 1.3. The num_locations
check would say that was an invalid location.
This commit is contained in:
jimingham
2025-06-26 17:03:07 -07:00
committed by GitHub
parent c3811c8474
commit ec48d15b20
6 changed files with 63 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lldb/source/Commands/CommandObjectBreakpoint.cpp
View File

@@ -2485,8 +2485,9 @@ void CommandObjectMultiwordBreakpoint::VerifyIDs(
Breakpoint *breakpoint =
target.GetBreakpointByID(cur_bp_id.GetBreakpointID()).get();
if (breakpoint != nullptr) {
const size_t num_locations = breakpoint->GetNumLocations();
if (static_cast<size_t>(cur_bp_id.GetLocationID()) > num_locations) {
lldb::break_id_t cur_loc_id = cur_bp_id.GetLocationID();
// GetLocationID returns 0 when the location isn't specified.
if (cur_loc_id != 0 && !breakpoint->FindLocationByID(cur_loc_id)) {
StreamString id_str;
BreakpointID::GetCanonicalReference(
&id_str, cur_bp_id.GetBreakpointID(), cur_bp_id.GetLocationID());