caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete Host/windows/win32.h

Browse Source 
It's always hard to remember when to include this file, and
when you do include it it's hard to remember what preprocessor
check it needs to be behind, and then you further have to remember
whether it's windows.h or win32.h which you need to include.

This patch changes the name to PosixApi.h, which is more appropriately
named, and makes it independent of any preprocessor setting.

There's still the issue of people not knowing when to include this,
because there's not a well-defined set of things it exposes other
than "whatever is missing on Windows", but at least this should
make it less painful to fix when problems arise.

This patch depends on LLVM revision r278170.

llvm-svn: 278177
This commit is contained in:
Zachary Turner
2016-08-09 23:06:08 +00:00
parent cef001aaaa
commit f343968f5d
62 changed files with 237 additions and 187 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/tools/debugserver/source/PThreadEvent.cpp
View File

@@ -28,14 +28,14 @@ PThreadEvent::PThreadEvent(uint32_t bits, uint32_t validBits) :
PThreadEvent::~PThreadEvent()
{
// DNBLogThreadedIf(LOG_EVENTS, "%p %s", this, __PRETTY_FUNCTION__);
// DNBLogThreadedIf(LOG_EVENTS, "%p %s", this, LLVM_PRETTY_FUNCTION);
}
uint32_t
PThreadEvent::NewEventBit()
{
// DNBLogThreadedIf(LOG_EVENTS, "%p %s", this, __PRETTY_FUNCTION__);
// DNBLogThreadedIf(LOG_EVENTS, "%p %s", this, LLVM_PRETTY_FUNCTION);
PTHREAD_MUTEX_LOCKER (locker, m_mutex);
uint32_t mask = 1;
while (mask & m_validBits)
@@ -60,7 +60,7 @@ PThreadEvent::FreeEventBits(const uint32_t mask)
uint32_t
PThreadEvent::GetEventBits() const
{
// DNBLogThreadedIf(LOG_EVENTS, "%p %s", this, __PRETTY_FUNCTION__);
// DNBLogThreadedIf(LOG_EVENTS, "%p %s", this, LLVM_PRETTY_FUNCTION);
PTHREAD_MUTEX_LOCKER (locker, m_mutex);
uint32_t bits = m_bits;
return bits;