caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

factor out an abstract base class for File

Browse Source 
Summary:
This patch factors out File as an abstract base
class and moves most of its actual functionality into
a subclass called NativeFile.   In the next patch,
I'm going to be adding subclasses of File that
don't necessarily have any connection to actual OS files,
so they will not inherit from NativeFile.

This patch was split out as a prerequisite for
https://reviews.llvm.org/D68188

Reviewers: JDevlieghere, jasonmolenda, labath

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D68317

llvm-svn: 373564
This commit is contained in:
Lawrence D'Anna
2019-10-03 04:31:46 +00:00
parent 96898eb6a9
commit f913fd6eb0
17 changed files with 367 additions and 262 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
View File

@@ -720,9 +720,9 @@ bool ScriptInterpreterPythonImpl::EnterSession(uint16_t on_entry_flags,
PythonDictionary &sys_module_dict = GetSysModuleDictionary();
if (sys_module_dict.IsValid()) {
File in_file(in, false);
File out_file(out, false);
File err_file(err, false);
NativeFile in_file(in, false);
NativeFile out_file(out, false);
NativeFile err_file(err, false);
lldb::FileSP in_sp;
lldb::StreamFileSP out_sp;