From fbbf1bed746c335b970aee7bd135676e534ffa05 Mon Sep 17 00:00:00 2001 From: Mariya Podchishchaeva Date: Tue, 17 Dec 2024 14:37:48 +0100 Subject: [PATCH] [HLSL][NFC] Fix static analyzer concerns (#120090) Class BuiltinTypeMethodBuilder has a user-defined destructor so likely compiler generated special functions may behave incorrectly. Delete explicitly copy constructor and copy assignment operator to avoid potential errors. --- clang/lib/Sema/HLSLExternalSemaSource.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/clang/lib/Sema/HLSLExternalSemaSource.cpp b/clang/lib/Sema/HLSLExternalSemaSource.cpp index 09fced111568..f3362fb619af 100644 --- a/clang/lib/Sema/HLSLExternalSemaSource.cpp +++ b/clang/lib/Sema/HLSLExternalSemaSource.cpp @@ -559,6 +559,10 @@ private: public: ~BuiltinTypeMethodBuilder() { finalizeMethod(); } + BuiltinTypeMethodBuilder(const BuiltinTypeMethodBuilder &Other) = delete; + BuiltinTypeMethodBuilder & + operator=(const BuiltinTypeMethodBuilder &Other) = delete; + Expr *getResourceHandleExpr() { // The first statement added to a method or access to 'this' creates the // declaration.