caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix reporting of stop reasons when the StepOver & StepIn plans stop because of a crash or breakpoint. Added the ability for a plan to say it is done but doesn't want to be the reason for the stop.

Browse Source 
llvm-svn: 155927
This commit is contained in:
Jim Ingham
2012-05-01 18:38:37 +00:00
parent 758e0cc94a
commit fbbfe6ecf0
9 changed files with 103 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
lldb/source/Target/ThreadPlanStepInRange.cpp
View File

@@ -295,3 +295,41 @@ ThreadPlanStepInRange::DefaultShouldStopHereCallback (ThreadPlan *current_plan,
return NULL;
}
bool
ThreadPlanStepInRange::PlanExplainsStop ()
{
// We always explain a stop. Either we've just done a single step, in which
// case we'll do our ordinary processing, or we stopped for some
// reason that isn't handled by our sub-plans, in which case we want to just stop right
// away.
// We also set ourselves complete when we stop for this sort of unintended reason, but mark
// success as false so we don't end up being the reason for the stop.
//
// The only variation is that if we are doing "step by running to next branch" in which case
// if we hit our branch breakpoint we don't set the plan to complete.
LogSP log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_STEP));
StopInfoSP stop_info_sp = GetPrivateStopReason();
if (stop_info_sp)
{
StopReason reason = stop_info_sp->GetStopReason();
switch (reason)
{
case eStopReasonBreakpoint:
if (NextRangeBreakpointExplainsStop(stop_info_sp))
return true;
case eStopReasonWatchpoint:
case eStopReasonSignal:
case eStopReasonException:
if (log)
log->PutCString ("ThreadPlanStepInRange got asked if it explains the stop for some reason other than step.");
SetPlanComplete(false);
break;
default:
break;
}
}
return true;
}