[LLDB] Fix for libc++ atomic allowing modification of contained value

Reviewed By: clayborg

Differential Revision: https://reviews.llvm.org/D140623
This commit is contained in:
Pavel Kosov
2023-01-25 10:39:50 +03:00
parent 21d9282ae2
commit ff9c31b23b
4 changed files with 62 additions and 1 deletions

View File

@@ -0,0 +1,6 @@
CXX_SOURCES := main.cpp
USE_LIBCPP := 1
CXXFLAGS_EXTRAS := -O0
include Makefile.rules

View File

@@ -0,0 +1,48 @@
"""
Test change libc++ std::atomic values.
"""
import lldb
from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *
from lldbsuite.test import lldbutil
class LibcxxChangeValueTestCase(TestBase):
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
@add_test_categories(["libc++"])
@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24772")
def test(self):
"""Test that we can change values of libc++ std::atomic."""
self.build()
self.runCmd("file " + self.getBuildArtifact("a.out"), CURRENT_EXECUTABLE_SET)
bkpt = self.target().FindBreakpointByID(
lldbutil.run_break_set_by_source_regexp(
self, "Set break point at this line."))
self.runCmd("run", RUN_SUCCEEDED)
# Get Frame #0.
target = self.dbg.GetSelectedTarget()
process = target.GetProcess()
self.assertState(process.GetState(), lldb.eStateStopped)
thread = lldbutil.get_stopped_thread(
process, lldb.eStopReasonBreakpoint)
self.assertTrue(
thread.IsValid(),
"There should be a thread stopped due to breakpoint condition")
frame0 = thread.GetFrameAtIndex(0)
self.assertTrue(frame0.IsValid(), "Got a valid frame.")
q_value = frame0.FindVariable("Q")
self.assertTrue(q_value.IsValid(), "Got the SBValue for val")
inner_val = q_value.GetChildAtIndex(0)
self.assertTrue(inner_val.IsValid(), "Got the SBValue for inner atomic val")
result = inner_val.SetValueFromCString("42")
self.assertTrue(result, "Setting val returned True.")
result = inner_val.GetValueAsUnsigned()
self.assertTrue(result == 42, "Got correct value (42)")

View File

@@ -0,0 +1,7 @@
#include <atomic>
int main()
{
std::atomic<int> Q(1);
return Q; // Set break point at this line.
}