caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
38,425 Commits 1 Branch 0 Tags
38ef3a8ec7e5b4d1f5e951136094de9a6f9ae22e
Commit Graph

271 Commits

Author SHA1 Message Date
Anders Carlsson
e1af1d20ef Support lax vector conversions. 
llvm-svn: 44449
 2007-11-30 04:21:22 +00:00
Ted Kremenek
3a2c950401 Added "isExact" field to FloatingLiteral. This flag indicates whether or not 
the APFloat representing the parsed literal can represent the literal value
exactly.  This is useful when performing various semantic checks on the code,
and issuing appropriate warnings to users.

llvm-svn: 44423
 2007-11-29 00:56:49 +00:00
Steve Naroff
0ee0b0ab8c Move the null pointer constant check from Sema::CheckSingleInitializer/ActOnCallExpr/CheckMessageArgumentTypes/ActOnReturnStmt to Sema::CheckSingleAssignmentConstraints. This makes sure all null pointer assignments are considered compatible. 
Thanks to Seo Sanghyeon for the bug, follow-through, and patch!

llvm-svn: 44366
 2007-11-27 17:58:44 +00:00
Anders Carlsson
de71adff60 Report errors for invalid casts from/to vectors. 
llvm-svn: 44350
 2007-11-27 05:51:55 +00:00
Chris Lattner
2ab40a6207 Fix sema support for the gnu ?: expression with a 
missing middle expression, and fix a codegen bug where
we didn't correctly promote the condition to the right 
result type.  This fixes PR1824.

llvm-svn: 44322
 2007-11-26 01:40:58 +00:00
Ted Kremenek
43fb8b0799 Moved logic for -Wfloat-equal to SemaChecking.cpp. 
Moved utility functions IgnoreParen and friends to be static inline functions
defined in SemaUtil.h.

Added SemaUtil.h to Xcode project.

llvm-svn: 44312
 2007-11-25 00:58:00 +00:00
Chris Lattner
48d52848d7 Tighten up address-of checking, implementing test/Sema/expr-address-of.c. 
This fixes a bug reported by Seo Sanghyeon.

This was meant to be committed yesterday, but the commit failed.  doh.

llvm-svn: 44190
 2007-11-16 17:46:48 +00:00
Steve Naroff
e3ffc2f4a9 Finish up variadic methods/messages. 
llvm-svn: 44172
 2007-11-15 13:05:42 +00:00
Steve Naroff
f60782b8c9 - Implement ivar rewrite (patch by Fariborz). 
- RewriteMessageExpr()...make implicit casts explicit with synthesizing call (removing warnings when calling objc_msgSend()).

llvm-svn: 44156
 2007-11-15 02:58:25 +00:00
Ted Kremenek
b83f182b59 Modified -Wfloat-equal logic to suppress warnings where floating point values 
are compared against builtins such as __builtin_inf.

llvm-svn: 44058
 2007-11-13 19:17:00 +00:00
Ted Kremenek
577437de8b Updated diagnostic for -Wfloat-equal to underline the offending expressions. 
llvm-svn: 44054
 2007-11-13 18:40:33 +00:00
Steve Naroff
b666625493 Teach Sema::CheckCompareOperands() about "void *" (C99 6.5.9p2) 
llvm-svn: 44047
 2007-11-13 14:57:38 +00:00
Steve Naroff
e50478e0b0 Tune the lookup logic in Sema::ActOnInstanceMessage() to handle private methods (declared within the implementation). 
llvm-svn: 44041
 2007-11-13 04:10:18 +00:00
Steve Naroff
4a158f37f9 Fix Sema::CheckAssignmentConstraints() to operate on the canonical, unqualified type. 
llvm-svn: 44036
 2007-11-13 00:31:42 +00:00
Fariborz Jahanian
21f54eeacf Patch to do statically typed ivar references. 
llvm-svn: 44028
 2007-11-12 22:29:28 +00:00
Fariborz Jahanian
2d0d3ba43e Minor twik for when there is no super class and 'super' is errornously used. 
llvm-svn: 44026
 2007-11-12 20:20:37 +00:00
Fariborz Jahanian
d98a734bd6 'super' nailed. 
llvm-svn: 44025
 2007-11-12 20:13:27 +00:00
Steve Naroff
e46504b278 Implement instance variable references. 
llvm-svn: 44016
 2007-11-12 14:29:37 +00:00
Steve Naroff
49effdefef Tweak Sema::ActOnInstanceMessage() to treat the built-in "Class" type the same as "id". 
llvm-svn: 43996
 2007-11-11 17:52:25 +00:00
Steve Naroff
5f9ae64f6e Make sure Sema::CheckIncrementDecrementOperand() removes typedefs when doing it's analysis. 
Thanks to Seo Sanghyeon for his excellent (first) bug fix!

llvm-svn: 43994
 2007-11-11 14:15:57 +00:00
Steve Naroff
22e078e013 Teach Sema::ActOnInstanceMessage() about private methods. That is, methods declared in an implementation (but not listed in the interface). 
This commit is only 95% of the bug fix. The last piece to this puzzle is to add the method decls to the implementation incrementally (as we encounter them). At the moment, the methods aren't added until we see an @end (which is too late).

I will complete this later...

llvm-svn: 43989
 2007-11-11 00:10:47 +00:00
Steve Naroff
257b4a2467 Fix a basic bug (having to do with typedefs) in Sema::UsualArithmeticConversions(). 
This resuled in the following crash below.

Also modified the usual-float.c test case to capture this case.

[steve-naroffs-imac:clang/test/Sema] snaroff% ../../../../Debug/bin/clang usual-float.c
Assertion failed: (0 && "Sema::UsualArithmeticConversions(): illegal float comparison"), function UsualArithmeticConversions, file SemaExpr.cpp, line 960.
0   clang                               0x001ef9b9 _ZN40_GLOBAL__N_Signals.cpp_00000000_4E6DAF8315PrintStackTraceEv + 45
1   clang                               0x001efd5f _ZN40_GLOBAL__N_Signals.cpp_00000000_4E6DAF8313SignalHandlerEi + 323
2   libSystem.B.dylib                   0x90c6297b _sigtramp + 43
3   ???                                 0xffffffff 0x0 + 4294967295
4   libSystem.B.dylib                   0x90cdb782 raise + 26
5   libSystem.B.dylib                   0x90cead3f abort + 73
6   libSystem.B.dylib                   0x90cdc923 __assert_rtn + 101
7   clang                               0x00077316 _ZN5clang4Sema26UsualArithmeticConversionsERPNS_4ExprES3_b + 1004
8   clang                               0x000803cf _ZN5clang4Sema27CheckMultiplyDivideOperandsERPNS_4ExprES3_NS_14SourceLocationEb + 181
9   clang                               0x0007a8e8 _ZN5clang4Sema10ActOnBinOpENS_14SourceLocationENS_3tok9TokenKindEPvS4_ + 472
10  clang                               0x000cf058 _ZN5clang6Parser26ParseRHSOfBinaryExpressionENS_6Action12ActionResultILj0EEEj + 1286
11  clang                               0x000cf2de _ZN5clang6Parser25ParseAssignmentExpressionEv + 86

llvm-svn: 43985
 2007-11-10 19:45:54 +00:00
Steve Naroff
96d20616c4 Sema::ActOnClassMessage()...if a class method isn't found, lookup an instance method. Since all classes are also instances, this is appropriate. 
llvm-svn: 43708
 2007-11-05 15:27:52 +00:00
Steve Naroff
66697aa72f Add a method prototype slot/getter to the ObjCMessageExpr AST. 
llvm-svn: 43666
 2007-11-03 16:37:59 +00:00
Steve Naroff
a397efd915 Implement rewrite rules for ObjC string constants. 
llvm-svn: 43665
 2007-11-03 11:27:19 +00:00
Steve Naroff
6d40db0dde Implement a more sensible strategy for ObjC built-in types (addressing a long standing FIXME in Sema::GetObjcIdType()). 
This removes several gross hacks to work around the previous "lazy" behavior.

Two notes:
- MinimalActions still needs to be taught about the built-in types (This breaks one of the -noop test cases). I started this, then added a FIXME.
- I didn't convert Sema::GetObjcProtoType() yet.

llvm-svn: 43567
 2007-10-31 18:42:27 +00:00
Anders Carlsson
f56a7aee2f Encode Class, SEL and Objective-C objects. 
llvm-svn: 43540
 2007-10-31 02:53:19 +00:00
Steve Naroff
5cdcd9b61c Stop pre-defining objc_msgSend/objc_getClass in the preprocessor. Instead, I generate these declaration on the fly when rewriting a message expression. 
llvm-svn: 43529
 2007-10-30 23:14:51 +00:00
Ted Kremenek
78036cdd5c Tightened IgnoreParen. 
llvm-svn: 43517
 2007-10-30 21:03:09 +00:00
Ted Kremenek
e2763b0948 Added some comments. 
Moved a dependent predicate in an if statement to be an assertion
within the if statement body.

llvm-svn: 43453
 2007-10-29 17:13:39 +00:00
Ted Kremenek
e451eae8d7 For non-floating point types, added check for expressions of the form 
"x == x" and "x != x".  We emit a warning for these since they always evaluate
to a constant value and often indicate a logical error.

Added test case for this check.

llvm-svn: 43450
 2007-10-29 16:58:49 +00:00
Ted Kremenek
fa907b8168 For floating point equality check, we now ignore parentheses. e.g.: 
(x) == x  is the treated the same as x == x.

llvm-svn: 43448
 2007-10-29 16:45:23 +00:00
Ted Kremenek
d4ecc6da67 For checking for floating point comparison using == or !=, we now suppress 
errors for cases such as "x == x".

Added test case to test this feature.

llvm-svn: 43447
 2007-10-29 16:40:01 +00:00
Chris Lattner
b104d31bd9 when checking for type equality, ignore typedefs. 
llvm-svn: 43441
 2007-10-29 05:15:40 +00:00
Chris Lattner
3bc4d20862 casting to void is ok for structs (C99 6.5.4p2), this fixes 
one bogus error on PR1750.

llvm-svn: 43436
 2007-10-29 04:26:44 +00:00
Steve Naroff
684dc4107f Fix the previous (short lived:-) FIXME. 
I didn't realize that GCC considers this a hard error (I thought it was built-in).

Since it's not, we should simply emit an error.

[dylan:~/llvm/tools/clang] admin% cc -c trivial.m
trivial.m:6: error: cannot find interface declaration for 'NSConstantString'

[administrators-powerbook59:~/llvm/tools/clang] admin% ../../Debug/bin/clang trivial.m 
trivial.m:6:16: error: cannot find interface declaration for 'NSConstantString'
NSString *s = @"123";
               ^
1 diagnostic generated.

llvm-svn: 43157
 2007-10-18 23:53:51 +00:00
Fariborz Jahanian
e183a8259d Check for Nullness of value built in GetObjcProtoType. 
llvm-svn: 43155
 2007-10-18 22:59:23 +00:00
Steve Naroff
eee59ebb15 Add a FIXME to an assert. 
Change a dyn_cast_or_null back to cast (which is more efficient).

llvm-svn: 43152
 2007-10-18 22:17:45 +00:00
Steve Naroff
1bb21df47f Tweak a recent fix to UsualArithmeticConversions (made by Chris - r43113). The benefit of this tweak is it guarantees the entire routine operates on unqualified types (which I believe is a bit clearer). 
llvm-svn: 43142
 2007-10-18 18:55:53 +00:00
Steve Naroff
a78c464c9e Fix a bug in Sema::CheckConditionalOperands(). When mixing pointers and null pointer constants, we need to promote the null pointer constant (which is an integer) to the pointer type. Test case is self explanatory. 
This surfaced yesterday, when compiling test/Sema/cocoa.m on Leopard. Since this has nothing to do with ObjC, it's kind of bizarre this hasn't shown up before. I imagine Cocoa.h on Leopard may have changed recently? 

Thanks to Ted for localizing the bug and giving me a useful AST dump...

llvm-svn: 43114
 2007-10-18 05:13:08 +00:00
Chris Lattner
fac7ac4130 UsualArithmeticConversions is crashing with an assert 
when comparing "float" and "const float".  This "fixes" the
issue, but may not be the right fix.  Steve, please review.

Testcase here: test/Sema/usual-float.c

llvm-svn: 43113
 2007-10-18 03:50:33 +00:00
Fariborz Jahanian
a32aaefadc Implementation of AST for @protocol expression. 
llvm-svn: 43075
 2007-10-17 16:58:11 +00:00
Fariborz Jahanian
6bd1d612ac Fix location processing of @selector: the range should include the @ sign. 
llvm-svn: 43051
 2007-10-16 23:21:02 +00:00
Steve Naroff
077c83bddb Add Sema::CheckMessageArgumentTypes()... 
llvm-svn: 43050
 2007-10-16 23:12:48 +00:00
Chris Lattner
37390bed4d Fix location processing of @encode: the range should include the @ sign. 
@selector probably gets this wrong also.

llvm-svn: 43048
 2007-10-16 22:51:17 +00:00
Steve Naroff
d275426449 Remove ObjcMethodDecl::getNumMethodParams/getMethodParamDecl, they aren't used/needed. 
Change ObjcMethodDecl::getMethodType to getResultType, to match FunctionDecl.

llvm-svn: 43045
 2007-10-16 21:36:54 +00:00
Fariborz Jahanian
4bef462a3e Patch to implement AST generation for objective-c's @selector expression. 
llvm-svn: 43038
 2007-10-16 20:40:23 +00:00
Steve Naroff
55f52da24c Emit diagnostics for methods not found. 
llvm-svn: 43037
 2007-10-16 20:39:36 +00:00
Chris Lattner
e6dcd505d0 initialization of references should not do default fn/array promotions. 
This fixes a bug Anders noticed.

llvm-svn: 43024
 2007-10-16 02:55:40 +00:00
Steve Naroff
698495522d Bad cast...need to use dyn_cast_or_null. Also changed Sema::InitBuiltinVaListType (which had the same bug). 
llvm-svn: 43023
 2007-10-16 00:00:18 +00:00