caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
114,121 Commits 1 Branch 0 Tags
3a86ba767c7efbb9a6c2e4916fca9590a7664bd2
Commit Graph

370 Commits

Author SHA1 Message Date
Benjamin Kramer
547b6c5ecd Stop emitting instructions with the name "tmp" they eat up memory and have to be uniqued, without any benefit. 
If someone prefers %tmp42 to %42, run instnamer.

llvm-svn: 140634
 2011-09-27 20:39:19 +00:00
Jakub Staszak
7470fb01d0 Compare type size instead of type _store_ size to make sure that BitCastInst 
will be valid. This fixes PR10820.

llvm-svn: 139005
 2011-09-02 14:57:37 +00:00
Eli Friedman
9a468153e1 Atomic load/store handling for the passes using memdep (GVN, DSE, memcpyopt). 
llvm-svn: 137888
 2011-08-17 22:22:24 +00:00
Bill Wendling
8bbcbedeaf Disable PRE for landing pads. 
PRE needs the landing pads to have their critical edges split. Doing this for a
landing pad is non-trivial. Abandon the attempt to perform PRE when we come
across a landing pad. (Reviewed by Owen!)

llvm-svn: 137876
 2011-08-17 21:32:02 +00:00
Jay Foad
ed8db7d9df Convert ConstantExpr::getGetElementPtr and 
ConstantExpr::getInBoundsGetElementPtr to use ArrayRef.

llvm-svn: 135673
 2011-07-21 14:31:17 +00:00
Chris Lattner
229907cd11 land David Blaikie's patch to de-constify Type, with a few tweaks. 
llvm-svn: 135375
 2011-07-18 04:54:35 +00:00
Lang Hames
266dab7bab Added recognition for signed add/sub/mul with overflow intrinsics to GVN as per Chris and Frits suggestion. 
llvm-svn: 134777
 2011-07-09 00:25:11 +00:00
Lang Hames
29cd98fd52 Make GVN look through extractvalues for recognised intrinsics. GVN can then CSE ops that match values produced by the intrinsics. 
llvm-svn: 134677
 2011-07-08 01:50:54 +00:00
Jay Foad
372ad64b4d Make better use of the PHINode API. 
Change various bits of code to make better use of the existing PHINode
API, to insulate them from forthcoming changes in how PHINodes store
their operands.

llvm-svn: 133434
 2011-06-20 14:18:48 +00:00
Eli Friedman
7d58bc7bc0 Add "unknown" results for memdep, which mean "I don't know whether a dependence for the given instruction exists in the given block". This cleans up all the existing hacks in memdep which represent this concept by returning clobber with various unrelated instructions. 
llvm-svn: 133031
 2011-06-15 00:47:34 +00:00
Chris Lattner
f0d59072de fix PR9841 by having GVN not process dead loads. This was 
causing it to get into infinite loops when it would widen a 
load (which can necessarily leave around dead loads).

llvm-svn: 131847
 2011-05-22 07:03:34 +00:00
Devang Patel
341b38c22a Preserve line number information. 
llvm-svn: 131482
 2011-05-17 20:00:02 +00:00
Devang Patel
c5933f2418 Set debug loc for new load instruction. 
llvm-svn: 131481
 2011-05-17 19:43:38 +00:00
Devang Patel
ffb798c1c6 Set debug loc for new instructions. 
llvm-svn: 130895
 2011-05-04 23:58:50 +00:00
Chris Lattner
a5452c0d67 improve comment. 
llvm-svn: 130426
 2011-04-28 20:02:57 +00:00
Chris Lattner
1777601a74 final step needed to resolve PR6627, which allows us to flatten the code down to 
a nice and tidy:
  %x1 = load i32* %0, align 4
  %1 = icmp eq i32 %x1, 1179403647
  br i1 %1, label %if.then, label %if.end

instead of doing lots of loads and branches.  May the FreeBSD bootloader
long fit in its allocated space.

llvm-svn: 130416
 2011-04-28 18:15:47 +00:00
Chris Lattner
45e393fc9c code cleanups only. 
llvm-svn: 130414
 2011-04-28 18:08:21 +00:00
Chris Lattner
f81f789b6c centralize "marking for deletion" into a helper function. Pass GVN around to 
static functions instead of passing around tons of random ivars.

llvm-svn: 130403
 2011-04-28 16:36:48 +00:00
Chris Lattner
6cec6ab275 Promote toErase to be an ivar of the GVN class. 
llvm-svn: 130401
 2011-04-28 16:18:52 +00:00
Chris Lattner
827a270a2a teach GVN to widen integer loads when they are overaligned, when doing an 
wider load would allow elimination of subsequent loads, and when the wider
load is still a native integer type.  This eliminates a ton of loads on 
various benchmarks involving struct fields, though it is somewhat hobbled
by clang not being very aggressive about field alignment.

This is yet another step along the way towards resolving PR6627.

llvm-svn: 130390
 2011-04-28 07:29:08 +00:00
Chris Lattner
eb045f9c02 Improve the bail-out predicate to really only kick in when phi 
translation fails.  We were bailing out in some cases that would
cause us to miss GVN'ing some non-local cases away.

llvm-svn: 130206
 2011-04-26 17:41:02 +00:00
Chris Lattner
6f83d06ffa Enhance MemDep: When alias analysis returns a partial alias result, 
return it as a clobber.  This allows GVN to do smart things.

Enhance GVN to be smart about the case when a small load is clobbered
by a larger overlapping load.  In this case, forward the value.  This
allows us to compile stuff like this:

int test(void *P) {
  int tmp = *(unsigned int*)P;
  return tmp+*((unsigned char*)P+1);
}

into:

_test:                                  ## @test
	movl	(%rdi), %ecx
	movzbl	%ch, %eax
	addl	%ecx, %eax
	ret

which has one load.  We already handled the case where the smaller
load was from a must-aliased base pointer.

llvm-svn: 130180
 2011-04-26 01:21:15 +00:00
Jay Foad
52131344a2 Remove PHINode::reserveOperandSpace(). Instead, add a parameter to 
PHINode::Create() giving the (known or expected) number of operands.

llvm-svn: 128537
 2011-03-30 11:28:46 +00:00
Jay Foad
e0938d8a87 (Almost) always call reserveOperandSpace() on newly created PHINodes. 
llvm-svn: 128535
 2011-03-30 11:19:20 +00:00
Dan Gohman
0f124e1987 Give GetUnderlyingObject a TargetData, to keep it in sync 
with BasicAA's DecomposeGEPExpression, which recently began
using a TargetData. This fixes PR8968, though the testcase
is awkward to reduce.

Also, update several off GetUnderlyingObject's users
which happen to have a TargetData handy to pass it in.

llvm-svn: 124134
 2011-01-24 18:53:32 +00:00
Jakob Stoklund Olesen
12cc296bd4 Remove the PR8954 workaround. 
llvm-svn: 123288
 2011-01-11 22:56:41 +00:00
Cameron Zwarich
cb9c4f85ec Dial back the speculative fix for PR8954 a bit, so that we only recompute dominators 
once at the beginning of GVN instead of once per iteration.

llvm-svn: 123278
 2011-01-11 22:14:42 +00:00
Cameron Zwarich
51eb403907 Attempt to fix the bootstrap buildbot. Rafael says this works for him on x86-64 Linux. 
llvm-svn: 123270
 2011-01-11 20:23:34 +00:00
Chris Lattner
193ce7c4d1 update memdep when an instruction is deleted. This code isn't 
actually reached in the testcase in PR8954, but it's safe and good
practice.

llvm-svn: 123224
 2011-01-11 08:19:16 +00:00
Chris Lattner
f6ae904e34 Fix FoldSingleEntryPHINodes to update memdep and AA when it deletes 
phi nodes.  It is called from MergeBlockIntoPredecessor which is 
called from GVN, which claims to preserve these.

I'm skeptical that this is the actual problem behind PR8954, but
this is a stab in the right direction.

llvm-svn: 123222
 2011-01-11 08:13:40 +00:00
Owen Anderson
7b25ff04bd Don't bother value numbering instructions with void types in GVN. In theory this should allow us to insert 
fewer things into the value numbering maps, but any speedup is beneath the noise threshold on my machine
on 403.gcc.

llvm-svn: 122844
 2011-01-04 22:15:21 +00:00
Owen Anderson
e39cb57b09 Complete the NumberTable --> LeaderTable rename. 
llvm-svn: 122828
 2011-01-04 19:29:46 +00:00
Owen Anderson
d7d06d3aaf Fix typo in a comment. 
llvm-svn: 122827
 2011-01-04 19:25:18 +00:00
Owen Anderson
51489b3b28 Prune #include's. 
llvm-svn: 122826
 2011-01-04 19:24:57 +00:00
Owen Anderson
c7c3bc63f7 Clarify terminology, settling on referring to what was the "number table" as the "leader table", and 
rename methods to make it much more clear what they're doing.

llvm-svn: 122823
 2011-01-04 19:13:25 +00:00
Owen Anderson
83546f2fe0 When removing a value from GVN's leaders list, don't drop the Next pointer in a corner case. 
llvm-svn: 122822
 2011-01-04 19:10:54 +00:00
Owen Anderson
41a1550ef5 Branch instructions don't produce values, so there's no need to generate a value number for them. This 
avoids adding them to the various value numbering tables, resulting in a minor (~3%) speedup for GVN
on 40.gcc.

llvm-svn: 122819
 2011-01-04 18:54:18 +00:00
Owen Anderson
22c53e277a Remove commented out code. 
llvm-svn: 122817
 2011-01-04 18:22:08 +00:00
Owen Anderson
d62d37225a Use the new addEscapingValue callback to update GlobalsModRef when GVN adds PHIs of GEPs. For the moment, 
have GlobalsModRef handle this conservatively by simply removing the value from its maps.

llvm-svn: 122787
 2011-01-03 23:51:43 +00:00
Owen Anderson
3a33d0cc4a Simplify GVN's value expression structure, allowing the elimination of a lot of 
almost-but-not-quite-identical code.  No intended functionality change.

llvm-svn: 122760
 2011-01-03 19:00:11 +00:00
Chris Lattner
bf0aa927cc split dom frontier handling stuff out to its own DominanceFrontier header, 
so that Dominators.h is *just* domtree.  Also prune #includes a bit.

llvm-svn: 122714
 2011-01-02 22:09:33 +00:00
Owen Anderson
5ab8d4b5e5 Give GVN back the ability to perform simple conditional propagation on conditional branch values. 
I still think that LVI should be handling this, but that capability is some ways off in the future,
and this matters for some significant benchmarks.

llvm-svn: 122378
 2010-12-21 23:54:34 +00:00
Owen Anderson
12470778d7 Remove dead code. 
llvm-svn: 122371
 2010-12-21 22:31:24 +00:00
Benjamin Kramer
43493c089f GVN's Expression is not POD-like (it contains a SmallVector). Simplify code while at it. 
llvm-svn: 122362
 2010-12-21 21:30:19 +00:00
Chris Lattner
b6252a376a tidy up 
llvm-svn: 122190
 2010-12-19 20:24:28 +00:00
Dan Gohman
4467aa5294 Preserve TBAA tags when doing load PRE. 
llvm-svn: 121921
 2010-12-15 23:53:55 +00:00
Dan Gohman
a4fcd2418d Move Value::getUnderlyingObject to be a standalone 
function so that it can live in Analysis instead of
VMCore.

llvm-svn: 121885
 2010-12-15 20:02:24 +00:00
Chris Lattner
e28618de59 move GetPointerBaseWithConstantOffset out of GVN into ValueTracking.h 
llvm-svn: 120476
 2010-11-30 22:25:26 +00:00
Chris Lattner
50162e3c2a remove a fixed fixme 
llvm-svn: 120474
 2010-11-30 22:18:11 +00:00
Owen Anderson
ea326db47b Document the new GVN number table structure. 
llvm-svn: 119865
 2010-11-19 22:48:40 +00:00