caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
43,071 Commits 1 Branch 0 Tags
86bbf338e57504cc1e006552d8a1a2d99302e961
Commit Graph

4008 Commits

Author SHA1 Message Date
Chris Lattner
86bbf338e5 Split some code out of the main SimplifyCFG loop into its own function. 
Fix said code to handle merging return instructions together correctly
when handling multiple return values.

llvm-svn: 50199
 2008-04-24 00:01:19 +00:00
Devang Patel
8f83081fea Check type instead of no. of operands. 
llvm-svn: 50179
 2008-04-23 20:18:29 +00:00
Dale Johannesen
f6e15a4774 Rewrite previous patch to suit Chris's preference. 
llvm-svn: 50174
 2008-04-23 18:34:37 +00:00
Chris Lattner
a82d691caa simplify code for propagation of constant arguments into 
callees.

llvm-svn: 50142
 2008-04-23 06:16:27 +00:00
Chris Lattner
5f1802cfdf Fix a number of bugs in ipconstantprop, simplify the code, fit in 80 cols, 
fix read after free bug (PR2238).

llvm-svn: 50141
 2008-04-23 05:59:23 +00:00
Chris Lattner
5a58a4dc6d Rewrite multiple return value handling in SCCP. Before, the -sccp pass 
would turn every getresult instruction into undef.  This helps with
rdar://5778210

llvm-svn: 50140
 2008-04-23 05:38:20 +00:00
Dale Johannesen
493527d8c9 Do not change the type of a ByVal argument to a 
type of a different size.

llvm-svn: 50121
 2008-04-23 01:03:05 +00:00
Evan Cheng
1c89ca7295 Don't do: "(X & 4) >> 1 == 2 --> (X & 4) == 4" if there are more than one uses of the shift result. 
llvm-svn: 50118
 2008-04-23 00:38:06 +00:00
Chris Lattner
37e9c187b0 Start doing the significantly useful part of jump threading: handle cases 
where a comparison has a phi input and that phi is a constant.  For example,
stuff like:

  Threading edge through bool from 'bb2149' to 'bb2231' with cost: 1, across block:
bb2237:		; preds = %bb2231, %bb2149
	%tmp2328.rle = phi i32 [ %tmp2232, %bb2231 ], [ %tmp2232439, %bb2149 ]		; <i32> [#uses=2]
	%done.0 = phi i32 [ %done.2, %bb2231 ], [ 0, %bb2149 ]		; <i32> [#uses=1]
	%tmp2239 = icmp eq i32 %done.0, 0		; <i1> [#uses=1]
	br i1 %tmp2239, label %bb2231, label %bb2327

or

bb38.i298:		; preds = %bb33.i295, %bb1693
	%tmp39.i296.rle = phi %struct.ibox* [ null, %bb1693 ], [ %tmp39.i296.rle1109, %bb33.i295 ]		; <%struct.ibox*> [#uses=2]
	%minspan.1.i291.reg2mem.1 = phi i32 [ 32000, %bb1693 ], [ %minspan.0.i288, %bb33.i295 ]		; <i32> [#uses=1]
	%tmp40.i297 = icmp eq %struct.ibox* %tmp39.i296.rle, null		; <i1> [#uses=1]
	br i1 %tmp40.i297, label %implfeeds.exit311, label %bb43.i301

This triggers thousands of times in spec.

llvm-svn: 50110
 2008-04-22 21:40:39 +00:00
Chris Lattner
d5425e8f8d Dig through multiple levels of AND to thread jumps if needed. 
llvm-svn: 50106
 2008-04-22 20:46:09 +00:00
Chris Lattner
3df4c15dc7 Teach jump threading to thread through blocks like: 
br (and X, phi(Y, Z, false)), label L1, label L2

This triggers once on 252.eon and 6 times on 176.gcc.  Blocks 
in question often look like this:

bb262:		; preds = %bb261, %bb248
	%iftmp.251.0 = phi i1 [ true, %bb261 ], [ false, %bb248 ]		; <i1> [#uses=4]
	%tmp270 = icmp eq %struct.rtx_def* %tmp.0.i, null		; <i1> [#uses=1]
	%bothcond = or i1 %iftmp.251.0, %tmp270		; <i1> [#uses=1]
	br i1 %bothcond, label %bb288, label %bb273

In this case, it is clear that it doesn't matter if tmp.0.i is null when coming from bb261.  When coming from bb248, it is all that matters.


Another random example:

check_asm_operands.exit:		; preds = %check_asm_operands.exit.thr_comm, %bb30.i, %bb12.i, %bb6.i413
	%tmp.0.i420 = phi i1 [ true, %bb6.i413 ], [ true, %bb12.i ], [ true, %bb30.i ], [ false, %check_asm_operands.exit.thr_comm ; <i1> [#uses=1]
	call void @llvm.stackrestore( i8* %savedstack ) nounwind 
	%tmp4389 = icmp eq i32 %added_sets_1.0, 0		; <i1> [#uses=1]
	%tmp4394 = icmp eq i32 %added_sets_2.0, 0		; <i1> [#uses=1]
	%bothcond80 = and i1 %tmp4389, %tmp4394		; <i1> [#uses=1]
	%bothcond81 = and i1 %bothcond80, %tmp.0.i420		; <i1> [#uses=1]
	br i1 %bothcond81, label %bb4398, label %bb4397

Here is the case from 252.eon:

bb290.i.i:		; preds = %bb23.i57.i.i, %bb8.i39.i.i, %bb100.i.i, %bb100.i.i, %bb85.i.i110
	%myEOF.1.i.i = phi i1 [ true, %bb100.i.i ], [ true, %bb100.i.i ], [ true, %bb85.i.i110 ], [ true, %bb8.i39.i.i ], [ false, %bb23.i57.i.i ]		; <i1> [#uses=2]
	%i.4.i.i = phi i32 [ %i.1.i.i, %bb85.i.i110 ], [ %i.0.i.i, %bb100.i.i ], [ %i.0.i.i, %bb100.i.i ], [ %i.3.i.i, %bb8.i39.i.i ], [ %i.3.i.i, %bb23.i57.i.i ]		; <i32> [#uses=3]
	%tmp292.i.i = load i8* %tmp16.i.i100, align 1		; <i8> [#uses=1]
	%tmp293.not.i.i = icmp ne i8 %tmp292.i.i, 0		; <i1> [#uses=1]
	%bothcond.i.i = and i1 %tmp293.not.i.i, %myEOF.1.i.i		; <i1> [#uses=1]
	br i1 %bothcond.i.i, label %bb202.i.i, label %bb301.i.i
  Factoring out 3 common predecessors.

On the path from any blocks other than bb23.i57.i.i, the load and compare 
are dead.

llvm-svn: 50096
 2008-04-22 07:05:46 +00:00
Chris Lattner
e369c35a84 refactor some code, no functionality change. 
llvm-svn: 50094
 2008-04-22 06:36:15 +00:00
Chris Lattner
8fb13cbe4e remove dead code. 
llvm-svn: 50080
 2008-04-22 03:21:48 +00:00
Chris Lattner
c3a439351c optimize "p != gep p, ..." better. This allows us to compile 
getelementptr-seteq.ll into:

define i1 @test(i64 %X, %S* %P) {
	%C = icmp eq i64 %X, -1		; <i1> [#uses=1]
	ret i1 %C
}

instead of:

define i1 @test(i64 %X, %S* %P) {
	%A.idx.mask = and i64 %X, 4611686018427387903		; <i64> [#uses=1]
	%C = icmp eq i64 %A.idx.mask, 4611686018427387903		; <i1> [#uses=1]
	ret i1 %C
}

And fixes the second half of PR2235.  This speeds up the insertion sort
case by 45%, from 1.12s to 0.77s.  In practice, this will significantly
speed up for loops structured like:

for (double *P = Base + N; P != Base; --P)
  ...

Which happens frequently for C++ iterators.

llvm-svn: 50079
 2008-04-22 02:53:33 +00:00
Chris Lattner
bab7bec9c8 fix grammar-o, thanks to Duncan for noticing. 
llvm-svn: 50047
 2008-04-21 18:25:01 +00:00
Owen Anderson
a5b96ecef9 Remove unneeded #include's. 
llvm-svn: 50035
 2008-04-21 07:47:38 +00:00
Owen Anderson
6a7355caa2 Refactor memcpyopt based on Chris' suggestions. Consolidate several functions 
and simplify code that was fallout from the separation of memcpyopt and gvn.

llvm-svn: 50034
 2008-04-21 07:45:10 +00:00
Chris Lattner
ad0d42ba15 don't assume that the argument passed to fprintf("%s" is a string. This 
fixes a crash in opt on 433.milc.

llvm-svn: 50023
 2008-04-21 03:18:33 +00:00
Chris Lattner
f6236cc2e9 Use the new SplitBlockPredecessors to implement a todo. 
llvm-svn: 50022
 2008-04-21 02:57:57 +00:00
Chris Lattner
a5b11705b6 Move SplitBlockPredecessors out of loopsimplify into BasicBlockUtils.h 
as a global helper function.  At the same type, switch it from taking
a vector of predecessors to an arbitrary sequential input.  This allows
us to switch LoopSimplify to use a SmallVector for various temporary
vectors that it passed into SplitBlockPredecessors.

llvm-svn: 50020
 2008-04-21 01:28:02 +00:00
Chris Lattner
d418b06abf Move domtree/frontier updating earlier, allowing us to use it to update phi 
nodes, removing a hack.

llvm-svn: 50019
 2008-04-21 01:05:08 +00:00
Chris Lattner
96e9e22269 Factor dominator tree and frontier updating into SplitBlockPredecessors 
instead of doing it after every call.

llvm-svn: 50018
 2008-04-21 00:54:38 +00:00
Chris Lattner
559c867ece fit some more code in 80 cols. 
llvm-svn: 50016
 2008-04-21 00:25:49 +00:00
Chris Lattner
aca912d793 simplify code, fit in 80 cols. 
llvm-svn: 50015
 2008-04-21 00:23:14 +00:00
Chris Lattner
38806c3e9c fit in 80 cols 
llvm-svn: 50014
 2008-04-21 00:19:16 +00:00
Chris Lattner
ff1c6e388c finish the first cut of a jump threading pass implementation. 
llvm-svn: 50006
 2008-04-20 22:39:42 +00:00
Chris Lattner
567166c0a8 replace a slow and verbose version of Instruction::isUsedOutsideOfBlock with 
a call to Instruction::isUsedOutsideOfBlock.

llvm-svn: 50005
 2008-04-20 22:18:22 +00:00
Chris Lattner
9c1f1a82bf we can only thread blocks when there is a pred we can determine the succ of. 
llvm-svn: 50003
 2008-04-20 21:18:09 +00:00
Chris Lattner
2115722ffa improve comments, infrastructure, and add some validity checks for threading. 
Add a cost function.

llvm-svn: 50002
 2008-04-20 21:13:06 +00:00
Chris Lattner
b3b6007c8b Add a new Jump Threading pass, which will handle cases 
such as those in PR2235.  Right now the pass is not very
effective. :)

llvm-svn: 50000
 2008-04-20 20:35:01 +00:00
Torok Edwin
ab20784740 g++-4.3 build-fix: CHAR_BIT requires <climits>. 
llvm-svn: 49989
 2008-04-20 08:33:11 +00:00
Chris Lattner
3b18762f40 Switch to using Simplified ConstantFP::get API. 
llvm-svn: 49977
 2008-04-20 00:41:09 +00:00
Chris Lattner
eb6bb803a7 Allow argpromote to promote struct arguments with a specified number 
of elements.  Patch by Matthijs Kooijman!

llvm-svn: 49962
 2008-04-19 19:50:01 +00:00
Owen Anderson
f9ae76d89c Make GVN able to remove unnecessary calls to read-only functions again. 
llvm-svn: 49842
 2008-04-17 05:36:50 +00:00
Scott Michel
376acf4aaa Remove unused variable 
llvm-svn: 49838
 2008-04-17 01:30:44 +00:00
Scott Michel
f66cb3696a Workaround for PR2207, in which pred_iterator assert gets triggered due to a 
wee problem in Xcode 2.[45]/gcc 4.0.1.

llvm-svn: 49831
 2008-04-16 23:46:39 +00:00
Chuck Rose III
c6a47e8a79 VisualStudio project files updated. #include <algorithm> added to make VisualStudio happy. Also had to undefine setjmp because of #include <csetjmp> turning setjmp into _setjmp in VisualStudio. 
llvm-svn: 49743
 2008-04-15 21:27:11 +00:00
Dan Gohman
4fff979a43 Remove unnecessary <sstream> includes. 
llvm-svn: 49681
 2008-04-14 20:40:47 +00:00
Dan Gohman
e36714c0b4 Minor whitespace and comment cleanups. 
llvm-svn: 49671
 2008-04-14 18:26:16 +00:00
Owen Anderson
7629b71dd4 Revert r49614. As Dan pointed out, some of these aren't correct. 
llvm-svn: 49657
 2008-04-14 17:38:21 +00:00
Owen Anderson
1f6fbc4bc3 Replace calls of the form V1->setName(V2->getName()) with V1->takeName(V2), 
which is significantly more efficient.

llvm-svn: 49614
 2008-04-13 19:15:17 +00:00
Owen Anderson
1e73f29a7f Fix PR2213 by simultaneously making GVN more aggressive with the return values 
of calls and less aggressive with non-readnone calls.

llvm-svn: 49516
 2008-04-11 05:11:49 +00:00
Dan Gohman
99b7b3f03b Teach InstCombine's ComputeMaskedBits to handle pointer expressions 
in addition to integer expressions. Rewrite GetOrEnforceKnownAlignment
as a ComputeMaskedBits problem, moving all of its special alignment
knowledge to ComputeMaskedBits as low-zero-bits knowledge.

Also, teach ComputeMaskedBits a few basic things about Mul and PHI
instructions.

This improves ComputeMaskedBits-based simplifications in a few cases,
but more noticeably it significantly improves instcombine's alignment
detection for loads, stores, and memory intrinsics.

llvm-svn: 49492
 2008-04-10 18:43:06 +00:00
Chris Lattner
a29d2536aa Disable an xform we've had for a long time, pow(x,0.5) -> sqrt. 
This is not safe for all inputs.

llvm-svn: 49458
 2008-04-10 02:07:51 +00:00
Chris Lattner
802134fc02 Generalize getUnaryFloatFunction to handle any FP unary function, automatically 
figuring out the suffix to use.  implement pow(2,x) -> exp2(x).

llvm-svn: 49437
 2008-04-09 17:48:11 +00:00
Chris Lattner
cca74e5ab9 use the new ConstantFP::get method to make this work with 
long double and simplify the code.

llvm-svn: 49435
 2008-04-09 17:17:35 +00:00
Devang Patel
a7dfbc0366 Be conservative if getresult operand is neither call nor invoke. 
llvm-svn: 49430
 2008-04-09 15:58:24 +00:00
Owen Anderson
ef9a6fd5c2 Factor a bunch of functionality related to memcpy and memset transforms out of 
GVN and into its own pass.

llvm-svn: 49419
 2008-04-09 08:23:16 +00:00
Owen Anderson
8ee792d1b6 Remove accidentally duplicated code. 
llvm-svn: 49418
 2008-04-09 07:55:01 +00:00
Chris Lattner
b859fb49ed many cleanups to the pow optimizer. Allow it to handle powf, 
add support for  pow(x, 2.0) -> x*x.

llvm-svn: 49411
 2008-04-09 00:07:45 +00:00