caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
201,694 Commits 1 Branch 0 Tags
98b4cf8fcaf391794de17bb10bea1ec03bc0133a
Commit Graph

537 Commits

Author SHA1 Message Date
Daniel Jasper
3273930d9a clang-format: Fix false positive in function annotation detection. 
llvm-svn: 238285
 2015-05-27 04:55:47 +00:00
Daniel Jasper
0805199185 clang-format: [JS] Support ES6 spread operator. 
Specifically, don't add a space before it.

Before:
  someFunction(... a);
  var x = [1, 2, ... a];

After:
  someFunction(...a);
  var x = [1, 2, ...a];

llvm-svn: 238183
 2015-05-26 07:18:56 +00:00
Anders Waldenborg
b09075a240 clang-format: Add space in function pointers with SpaceBeforeParens=Always 
"void (*my_function)(void)" should become "void (*my_function) (void)" when
SpaceBeforeParens is set to 'Always'

Differential Revision: http://reviews.llvm.org/D9835

llvm-svn: 237704
 2015-05-19 16:54:26 +00:00
Daniel Jasper
9310166a63 clang-format: Improve *-detection. 
Before:
  S << a *(10);

After:
  S << a * (10);

This fixes llvm.org/PR16500.

llvm-svn: 237690
 2015-05-19 12:29:27 +00:00
Daniel Jasper
d6e09e85f9 clang-format: Improve for-loop formatting. 
Before:
  for (SmallVectorImpl<TemplateIdAnnotationn *>::iterator I =
           Container.begin(),
                                                          E = Container.end();
       I != E; ++I)

After:
  for (SmallVectorImpl<TemplateIdAnnotationn *>::iterator
           I = Container.begin(),
           E = Container.end();
       I != E; ++I)

This fixes llvm.org/PR23544.

llvm-svn: 237688
 2015-05-19 11:51:39 +00:00
Daniel Jasper
fa3f8fbed8 clang-format: Support #include_next 
Before:
  #include_next < test.h >

After:
  #include_next <test.h>

This fixes llvm.org/PR23500

llvm-svn: 237686
 2015-05-19 11:22:29 +00:00
Daniel Jasper
f5e5ee6d69 clang-format: Correctly detect casts to qualified types. 
Before:
  ns::E f() { return (ns::E) - 1; }

After:
  ns::E f() { return (ns::E)-1; }

This fixes llvm.org/PR23503.

llvm-svn: 237684
 2015-05-19 11:18:39 +00:00
Daniel Jasper
ed41f774fc clang-format: Fix regression caused by r237244. 
Before:
  [call aaaaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa.
          aaaaaaaa];

After:
  [call aaaaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa
          .aaaaaaaa];

This merely papers over the fact that we aren't parsing ObjC method calls
correctly. Also, the indentation is weird.

llvm-svn: 237681
 2015-05-19 11:06:33 +00:00
Daniel Jasper
47bbda0939 clang-format: Improve detection of macros annotating functions. 
Before:
  ASSERT("aaaaaaaaaaaaaaa")
      << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
      << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;

After:
  ASSERT("aaaaaaaaaaaaaaa") << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
                            << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;

Also cleanup implementation a bit and only mark closing parenthesis of
these annotations.

llvm-svn: 237567
 2015-05-18 13:47:23 +00:00
Daniel Jasper
f090f031bc clang-format: Support function annotations in macros. 
Before:
  DEPRECATED("Use NewClass::NewFunction instead.") string
      OldFunction(const string &parameter) {}

After:
  DEPRECATED("Use NewClass::NewFunction instead.")
  string OldFunction(const string &parameter) {}

llvm-svn: 237562
 2015-05-18 09:47:22 +00:00
Daniel Jasper
2fd16632bc clang-format: Improve line wrapping around << operators. 
Generally, clang-format tries to keep label-value pairs on a single
line for stream operators. However, we should not do that if there is
just a single such pair, as that doesn't help much.

Before:
  llvm::errs() << "aaaaaaaaaaaa: " << aaaaaaa(aaaaaaaaa,
                                              aaaaaaaaa);

After:
  llvm::errs() << "aaaaaaaaaaaa: "
               << aaaaaaa(aaaaaaaaa, aaaaaaaaa);

Also remove old test case that was testing actual behavior any more.

llvm-svn: 237535
 2015-05-17 07:27:09 +00:00
Daniel Jasper
3ca283ada3 clang-format: Slightly change format decisions around macro annotations. 
Before:
  bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
      GUARDED_BY(aaaaaaaaaaaa) = aaaaaaaaaaaaaaaaaaaaaaaaa;

After:
  bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa GUARDED_BY(aaaaaaaaaaaa) =
      aaaaaaaaaaaaaaaaaaaaaaaaa;

llvm-svn: 237430
 2015-05-15 09:58:11 +00:00
Daniel Jasper
cdb58b2e45 clang-format: Add missing space before ObjC selector. 
Before:
  [self aaaaa:(1 + 2)bbbbb:3];

After:
  [self aaaaa:(1 + 2) bbbbb:3];

llvm-svn: 237424
 2015-05-15 09:05:31 +00:00
Daniel Jasper
3a26a8db5d clang-format: Fix incorrect */& classification. 
Before:
  void f() { f(new a(), c *d); }

After:
  void f() { f(new a(), c * d); }

llvm-svn: 237249
 2015-05-13 12:54:30 +00:00
Daniel Jasper
a7b142603d clang-format: [ObjC] Further improve wrapping of methods calls without inputs. 
Before:
  [aaaaaaaaaaaaaaaaaaaaaaa
      .aaaaaaaa[aaaaaaaaaaaaaaaaaaaaa] aaaaaaaaaaaaaaaaaaaaaa];

After:
  [aaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaa[aaaaaaaaaaaaaaaaaaaaa]
      aaaaaaaaaaaaaaaaaaaaaa];

llvm-svn: 237244
 2015-05-13 10:23:03 +00:00
Daniel Jasper
0ad2814c89 clang-format: Prefer formatting local lambdas like functions. 
Before:
  auto my_lambda =
      [](const string &some_parameter) { return some_parameter.size(); };

After:
  auto my_lambda = [](const string &some_parameter) {
    return some_parameter.size();
  };

llvm-svn: 237235
 2015-05-13 08:47:16 +00:00
Daniel Jasper
99b5a4648c clang-format: Fix */& detection for lambdas in macros. 
Before:
  #define MACRO() [](A * a) { return 1; }

After:
  #define MACRO() [](A *a) { return 1; }

llvm-svn: 237109
 2015-05-12 10:20:32 +00:00
Daniel Jasper
015c7a91f1 clang-format: Support aligning ObjC string literals. 
Before:
  NSString s = @"aaaa"
      @"bbbb";

After:
  NSString s = @"aaaa"
               @"bbbb";

llvm-svn: 237000
 2015-05-11 15:15:48 +00:00
Daniel Jasper
c6366077ed clang-format: Preserve line break before } in __asm { ... }. 
Some compilers ignore everything after a semicolon in such inline asm
blocks and thus, the closing brace must not be moved to the previous
line.

llvm-svn: 236946
 2015-05-10 08:42:04 +00:00
Daniel Jasper
7325aee167 clang-format: [JS] Avoid bad line-warp around "function". 
Before:
  someLooooooooongFunction(
      aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,
      aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa, function(
                                              aaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {
        // code
      });

After:
  someLooooooooongFunction(
      aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,
      aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,
      function(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {
        // code
      });

llvm-svn: 236813
 2015-05-08 08:38:52 +00:00
Daniel Jasper
9c95013e8f clang-format: Improve r236597, Properly indent method calls without inputs. 
Before:
  [aaaaaaaaaaaa(aaaaaa)
          aaaaaaaaaaaaaaaaaaaa];

After:
  [aaaaaaaaaaaa(aaaaaa)
      aaaaaaaaaaaaaaaaaaaa];

llvm-svn: 236730
 2015-05-07 14:19:59 +00:00
Daniel Jasper
1fe0d5ca59 clang-format: Merge labels and subsequent semicolons. 
E.g.:

  default:;

This can be used to get around restrictions as to what can follow a
label. It fixes llvm.org/PR19648.

llvm-svn: 236604
 2015-05-06 15:19:47 +00:00
Daniel Jasper
112b50e6b6 clang-format: Allow ternary expressions inside template parameters if 
the template parameters aren't inside an expression context.

This fixes llvm.org/PR23270.

llvm-svn: 236603
 2015-05-06 14:53:50 +00:00
Daniel Jasper
e92bf6f141 clang-format: Consider operator precedence as penalty when breaking 
before operators.

This fixes llvm.org/23382.

llvm-svn: 236602
 2015-05-06 14:23:38 +00:00
Daniel Jasper
62c78f5474 clang-format: Prevent assertion discovered by fuzzer. 
llvm-svn: 236578
 2015-05-06 08:58:57 +00:00
Daniel Jasper
4d9ec17f1e clang-format: Prevent exponential runtime in token annotator. 
llvm-svn: 236577
 2015-05-06 08:38:24 +00:00
Daniel Jasper
9326f91922 clang-format: [JS] support optional methods. 
Optional methods use ? tokens like this:

  interface X { y?(): z; }

It seems easiest to detect and disambiguate these from ternary
expressions by checking if the code is in a declaration context. Turns
out that that didn't quite work properly for interfaces in Java and JS,
and for JS file root contexts.

Patch by Martin Probst, thank you.

llvm-svn: 236488
 2015-05-05 08:40:32 +00:00
Daniel Jasper
66cb8c503f clang-format: NFC: Delete FormatToken::IsForEachMacro. Use a TokenType instead. 
llvm-svn: 236415
 2015-05-04 09:22:29 +00:00
Daniel Jasper
de7ca75ca0 clang-format: Force aligning different brackets relative to each other. 
Before:
  void SomeFunction(vector< // break
      int> v);

After:
  void SomeFunction(vector< // break
                        int> v);

llvm-svn: 236412
 2015-05-04 07:39:00 +00:00
Daniel Jasper
d22190632c clang-format: [JS] Fix templated parameter default values. 
Parameters can have templated types and default values (= ...), which is
another location in which a template closer should be followed by
whitespace.

Patch by Martin Probst, thank you.

llvm-svn: 236382
 2015-05-02 07:54:58 +00:00
Daniel Jasper
0faa9136fa clang-format: Properly detect variable declarations with ObjC. 
Before:
  LoooooooooooooooooooooooooooooooooooooooongType
  LoooooooooooooooooooooooooooooooooooooongVariable([A a]);

After:
  LoooooooooooooooooooooooooooooooooooooooongType
      LoooooooooooooooooooooooooooooooooooooongVariable([A a]);

llvm-svn: 235599
 2015-04-23 13:58:40 +00:00
Daniel Jasper
caf84fe21e clang-format: Allow splitting "= default" and "= delete". 
Otherwise, this can violate the column limit.

llvm-svn: 235592
 2015-04-23 12:59:09 +00:00
Daniel Jasper
532a031422 clang-format: Don't add unwanted space when creating new arrays. 
Before:
  char** newargv = new char* [argc];

After:
  char** newargv = new char*[argc];

llvm-svn: 235583
 2015-04-23 10:23:53 +00:00
Daniel Jasper
1b998815a0 clang-format: [Proto] Don't linewrap top-level options. 
They are very similar to import statements.

llvm-svn: 235582
 2015-04-23 09:54:10 +00:00
Daniel Jasper
ee4a8a140a clang-format: Fix for #pragma option formatting. 
Adapted patch from Sergey Razmetov. Thank you.

llvm-svn: 235492
 2015-04-22 09:45:42 +00:00
Daniel Jasper
e4ab49e8d3 clang-format: Fix incorrect multi-var declstmt detection. 
This is now obvious as the pointer alignment behavior was changed.

Before (even with pointer alignment "Left"):
  MACRO Constructor(const int &i) : a(a), b(b) {}

After:
  MACRO Constructor(const int& i) : a(a), b(b) {}

llvm-svn: 235301
 2015-04-20 12:54:29 +00:00
Daniel Jasper
20e15563ff clang-format: Undo r214508. It was essentially always removing the 
space where we already had the flag ObjCSpaceBeforeProtocolList to
control it. I don't know what I was thinking.

llvm-svn: 235076
 2015-04-16 07:02:19 +00:00
Daniel Jasper
2b1865c251 clang-format: Determine "in" as a keyword in ObjC for loops more precisely 
Before:
  for (int i = 0; i < in [a]; ++i) ..

After:
  for (int i = 0; i < in[a]; ++i) ..

Also do some related cleanups.

llvm-svn: 234980
 2015-04-15 07:26:18 +00:00
Daniel Jasper
d9309774a6 clang-format: [JS] Support index signature types. 
Patch by Martin Probst.

llvm-svn: 234754
 2015-04-13 15:03:30 +00:00
Daniel Jasper
a74f5072e1 clang-format: [JS] support optionality markers in JS types. 
Patch by Martin Probst. Thank you.

llvm-svn: 234753
 2015-04-13 15:01:40 +00:00
Daniel Jasper
739ec534d2 clang-format: [JS] Understand object literals with only methods. 
Before:
  let theObject = {someMethodName() {
    doTheThing();
    doTheOtherThing();
  },
                   someOtherMethodName() {
                     doSomething();
                     doSomethingElse();
                   }};

After:
  let theObject = {
    someMethodName() {
      doTheThing();
      doTheOtherThing();
    },
    someOtherMethodName() {
      doSomething();
      doSomethingElse();
    }
  };

llvm-svn: 234091
 2015-04-04 07:56:55 +00:00
Daniel Jasper
05cd92922d clang-format: Force line break in trailing calls after multline exprs. 
Before:
  aaaaaaaa(aaaaaaaaaa,
           bbbbbbbbbb).a();

After:
  aaaaaaaa(aaaaaaaaaa,
           bbbbbbbbbb)
      .a();

llvm-svn: 233304
 2015-03-26 18:46:28 +00:00
Daniel Jasper
414c9c6fb0 clang-format: Fix another bug in wrapping around "*". 
Before:
  void aaaaa(
      aaaaaaaaaaaa* aaaaaaaaaaaaaa) {} // even violation the column limit

After:
  void aaaaa(aaaaaaaaaaaa*
                 aaaaaaaaaaaaaa) {}

llvm-svn: 232717
 2015-03-19 09:40:16 +00:00
Daniel Jasper
1130981907 clang-format: Fix bad wrapping after "*" introduced in r232044. 
Before:
  void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa*
                                              const aaaaaaaaaaaa) {}

After:
  void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(
      aaaaaaaaaaaaaaaaaaaaaaaaa* const aaaaaaaaaaaa) {}

llvm-svn: 232635
 2015-03-18 14:20:13 +00:00
Daniel Jasper
bc46b939e6 clang-format: [JS] support cast syntax and type arguments. 
Casts in TS syntax (foo = <type>bar;) should not be followed by
whitespace.

Patch by Martin Probst. Thank you.

llvm-svn: 232321
 2015-03-15 13:59:51 +00:00
Daniel Jasper
60948b12bb clang-format: [JS] more precisely detect enums. 
The current enum detection is overly aggressive. As NestingLevel only
applies per line (?) it classifies many if not most object literals as
enum declarations and adds superfluous line breaks into them. This
change narrows the heuristic by requiring an assignment just before the
open brace and requiring the line to start with an identifier.

Patch by Martin Probst. Thank you.

llvm-svn: 232320
 2015-03-15 13:55:54 +00:00
Daniel Jasper
b754a747be clang-format: When putting */& next to types, also wrap before them. 
Before:
  LoooooooooooongType *
      loooooooooooongVariable;

After:
  LoooooooooooongType
      *loooooooooooongVariable;

llvm-svn: 232044
 2015-03-12 15:04:53 +00:00
Daniel Jasper
dc4f725673 clang-format: Fix incorrect && recognition. 
Before:
  if (a &&(b = c)) ..

After:
  if (a && (b = c)) ..

llvm-svn: 231920
 2015-03-11 12:59:49 +00:00
Benjamin Kramer
28b45ce151 Make constant static variables const so they can go into a read-only section 
NFC.

llvm-svn: 231597
 2015-03-08 16:06:46 +00:00
Daniel Jasper
e662316994 clang-format: Prefer wrapping a lambda's body over the lambda's return type. 
Before:
  aaaaaaaaaaaaaaaaaaaaaa(
      [](aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &aaa)
          -> aaaaaaaaaaaaaaaaaaaaa { return aaaaaaaaaaaaaaaaa; });

After:
  aaaaaaaaaaaaaaaaaaaaaa(
      [](aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &aaa) -> aaaaaaaaaaaaaaaaaaaaa {
        return aaaaaaaaaaaaaaaaa;
      });

llvm-svn: 230942
 2015-03-02 10:35:13 +00:00