caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
45,916 Commits 1 Branch 0 Tags
9cfd2f8e577789cf9ddf4792ceee0d2ccd825921
Commit Graph

4357 Commits

Author SHA1 Message Date
Dan Gohman
7ad3cd8c9d Fix a bug in LSR's dead-PHI cleanup. If a PHI has a def-use chain that 
leads into a cycle involving a different PHI, LSR got stuck running
around that cycle looking for the original PHI. To avoid this, keep
track of visited PHIs and stop searching if we see one more than once.
This fixes PR2570.

llvm-svn: 53879
 2008-07-21 21:45:02 +00:00
Duncan Sands
2c741145a7 Supress a gcc-4.3 warning. 
llvm-svn: 53771
 2008-07-18 21:06:02 +00:00
Owen Anderson
04a6e0ba8c Make PRE actually handle critical edges (by splitting them). Confirmed that bootstrap passes with this change. 
llvm-svn: 53762
 2008-07-18 18:03:38 +00:00
Owen Anderson
9858691f25 Reapply r53735. My last patch fixed the failures Dan observed. 
llvm-svn: 53761
 2008-07-18 17:49:43 +00:00
Owen Anderson
1468bec06e Add some checks that got lost in the shuffle. This fixes 464.h264ref. 
llvm-svn: 53760
 2008-07-18 17:46:41 +00:00
Dan Gohman
29c3adaae0 Revert r53735. It broke SPEC 464.h264ref. 
llvm-svn: 53757
 2008-07-18 16:44:49 +00:00
Owen Anderson
fd7102037d Use MergeBlockIntoPredecessor to simplify some code. 
llvm-svn: 53735
 2008-07-17 20:00:46 +00:00
Owen Anderson
27405efdc0 Make MergeBlockIntoPredecessor more aggressive when the same successor appears 
more than once.

llvm-svn: 53731
 2008-07-17 19:42:29 +00:00
Owen Anderson
addbe3eed1 Enable PRE. My last batch of changes fixed the miscompile. 
llvm-svn: 53730
 2008-07-17 19:41:00 +00:00
Matthijs Kooijman
8b69d77a7a Make GlobalOpt preserve address spaces when scalar replacing aggregate globals. 
llvm-svn: 53716
 2008-07-17 11:59:53 +00:00
Chris Lattner
c600c53d1f Fix PR2553 
llvm-svn: 53715
 2008-07-17 06:07:20 +00:00
Evan Cheng
97cd0298cc Inliner tweak. Function calls should cost more than one instruction! 
llvm-svn: 53712
 2008-07-17 01:31:49 +00:00
Owen Anderson
c062381c7b Factor MergeBlockIntoPredecessor out into BasicBlockUtils. 
llvm-svn: 53705
 2008-07-17 00:01:40 +00:00
Owen Anderson
ac31096311 There's no need to iterate block merging and PRE. In fact, iterating the latter 
could cause problems for memdep when it breaks critical edges.

llvm-svn: 53691
 2008-07-16 17:52:31 +00:00
Matthijs Kooijman
c1d7477ed2 Redo InstCombiner::visitExtractValueInst. Instead of using the (complicate) 
FindInsertedValue, it now performs a number of simple transformations that
should result in the same effect when applied iteratively.

llvm-svn: 53673
 2008-07-16 12:55:45 +00:00
Evan Cheng
c97094552c Fix PR2296. Do not transform x86_sse2_storel_dq into a full-width store. 
llvm-svn: 53666
 2008-07-16 07:28:14 +00:00
Owen Anderson
24768e3dc4 Revert this, as it seems to still be broken. 
llvm-svn: 53627
 2008-07-15 17:59:02 +00:00
Owen Anderson
9d1f497a28 Enable local PRE by default. 
llvm-svn: 53616
 2008-07-15 16:28:23 +00:00
Owen Anderson
53d546e40b Have GVN do a pre-pass over the CFG that folds away unconditional branches where possible. This allows local PRE to be more aggressive. 
llvm-svn: 53615
 2008-07-15 16:28:06 +00:00
Matthijs Kooijman
c893bf472d Allow deadargelim to change return types even though now values were dead. This 
again canonicalizes {i32} into i32 and {} into void.

llvm-svn: 53610
 2008-07-15 14:42:31 +00:00
Matthijs Kooijman
5e8c022e21 Revert r53606. It turns out that explicitely tracking the liveness of the 
return value as a whole in deadargelim is really not needed now that we simply
rebuild the old return value and actually prevents some canonicalization from
taking place.

This revert stops deadargelim from changing {i32} into i32 for now, but I'll
fix that next.

llvm-svn: 53609
 2008-07-15 14:39:36 +00:00
Matthijs Kooijman
c1da874478 Make deadargelim a bit less smart, so it doesn't choke on nested structs as 
return values that are still (partially) live. Instead of updating all uses of
a call instruction after removing some elements, it now just rebuilds the
original struct (With undef gaps where the unused values were) and leaves it to
instcombine to clean this up.

The added testcase still fails currently, but this is due to instcombine which
isn't good enough yet. I will fix that part next.

llvm-svn: 53608
 2008-07-15 14:03:10 +00:00
Matthijs Kooijman
04d4c328ac Don't use isa when we can reuse a previous dyn_cast. 
llvm-svn: 53607
 2008-07-15 13:39:08 +00:00
Matthijs Kooijman
84194b6768 Make DeadArgElim keep liveness of the return value as a whole in addition to 
only the liveness of partial return values (for functions returning a struct).
This is more explicit to prevent unwanted changes in the return value. 

In particular, deadargelim now canonicalizes a function returning {i32} to
returning i32 and {} to void, if the struct returned is not used in its
entirety, but only the single element is used.

llvm-svn: 53606
 2008-07-15 13:36:06 +00:00
Matthijs Kooijman
79a8eb547c Let DAE keep a list of live functions, instead of simply marking all arguments 
and return values live for those functions. This doesn't change anything yet,
but prepares for the coming commits.

llvm-svn: 53601
 2008-07-15 09:11:16 +00:00
Matthijs Kooijman
e9af814669 Split DAE::MarkLive into MarkLive and PropagateLiveness. 
llvm-svn: 53600
 2008-07-15 09:00:17 +00:00
Matthijs Kooijman
2ce5709e31 Pass around const RetOrArg references instead of copying values. Also, mark 
RetOrArg::getDescription() as const.

llvm-svn: 53599
 2008-07-15 08:56:49 +00:00
Matthijs Kooijman
f2860b9fb3 Simplify debug code by using RetOrArg::getDescription(). 
llvm-svn: 53598
 2008-07-15 08:53:36 +00:00
Matthijs Kooijman
90d08addb0 Fix indentation (intentionally left out of the previous commit). 
llvm-svn: 53592
 2008-07-15 08:47:32 +00:00
Matthijs Kooijman
06642d3812 Move the deadargelim code for intrinsically alive functions into its own 
method, to slightly simplify control flow.

llvm-svn: 53591
 2008-07-15 08:45:12 +00:00
Dan Gohman
162668fa78 Fix uninitialized use of the Changed variable. 
llvm-svn: 53564
 2008-07-14 17:55:01 +00:00
Chris Lattner
8882b1c41c Reapply r53540, now with the matching header! 
llvm-svn: 53557
 2008-07-14 17:32:59 +00:00
Duncan Sands
68b0383057 Revert r53540 - it does not compile. 
llvm-svn: 53549
 2008-07-14 07:59:28 +00:00
Chris Lattner
2831ad28be If a function calls setjmp, never inline it into other functions. This is 
a hack around the fact that we don't represent the CFG correctly for sj/lj.
It fixes PR2486.

llvm-svn: 53540
 2008-07-14 00:46:56 +00:00
Chris Lattner
6f5ea6e49c simplify some code, shuffle and insertelt always return a vector. 
llvm-svn: 53538
 2008-07-14 00:32:20 +00:00
Chris Lattner
16395e51f4 Fix PR2506 by being a bit more careful about reverse fact propagation when 
disproving a condition.  This actually compiles the existing testcase
(udiv_select_to_select_shift) to:

define i64 @test(i64 %X, i1 %Cond) {
entry:
	%divisor1.t = lshr i64 %X, 3		; <i64> [#uses=1]
	%quotient2 = lshr i64 %X, 3		; <i64> [#uses=1]
	%sum = add i64 %divisor1.t, %quotient2		; <i64> [#uses=1]
	ret i64 %sum
}

instead of:

define i64 @test(i64 %X, i1 %Cond) {
entry:
	%quotient1.v = select i1 %Cond, i64 3, i64 4		; <i64> [#uses=1]
	%quotient1 = lshr i64 %X, %quotient1.v		; <i64> [#uses=1]
	%quotient2 = lshr i64 %X, 3		; <i64> [#uses=1]
	%sum = add i64 %quotient1, %quotient2		; <i64> [#uses=1]
	ret i64 %sum
}

llvm-svn: 53534
 2008-07-14 00:15:52 +00:00
Chris Lattner
80b03a1b49 Fix mishandling of the infinite loop case when merging two blocks. This 
fixes PR2540.

llvm-svn: 53533
 2008-07-13 22:23:11 +00:00
Chris Lattner
834ab4ec1b more refactoring. Use early exits instead of really complex logic. 
No functionality change.

llvm-svn: 53532
 2008-07-13 22:04:41 +00:00
Chris Lattner
5eed37224a improve comments. 
llvm-svn: 53531
 2008-07-13 21:55:46 +00:00
Chris Lattner
9aada1d755 factor another large hunk of code out into its own function. 
No functionality change.

llvm-svn: 53530
 2008-07-13 21:53:26 +00:00
Chris Lattner
55eaae1e0c Final bit of simplification for FoldBranchToCommonDest. 
llvm-svn: 53528
 2008-07-13 21:20:19 +00:00
Chris Lattner
1b317ea48a simplify logic a bit 
llvm-svn: 53527
 2008-07-13 21:15:11 +00:00
Chris Lattner
2e25b8f444 Refactor some code out into its own helper function, getting rid of crazy multiline 
conditionals and commenting the code better.

No functionality change.

llvm-svn: 53526
 2008-07-13 21:12:01 +00:00
Nick Lewycky
f76aa23b54 Enhance analysis of srem. 
Remove dead code analyzing urem. 'urem' of power-of-2 is canonicalized to an
'and' instruction.

llvm-svn: 53506
 2008-07-12 05:04:38 +00:00
Dan Gohman
3707f1daba Use find instead of lower_bound. 
llvm-svn: 53474
 2008-07-11 20:58:19 +00:00
Owen Anderson
8e462e9a82 Don't call lookupNumber more than we have to. 
llvm-svn: 53470
 2008-07-11 20:05:13 +00:00
Nick Lewycky
45e127ab20 Document 'mask' in this calculation. 
llvm-svn: 53454
 2008-07-11 08:16:26 +00:00
Nick Lewycky
da405e1155 Remove misleading constant from comment. 
llvm-svn: 53452
 2008-07-11 07:36:19 +00:00
Nick Lewycky
f95b64acaa Add another optimization from PR2330. Also catch some missing cases that are 
similar.

llvm-svn: 53451
 2008-07-11 07:20:53 +00:00
Chris Lattner
3994bed1a9 a missed optimization that Eli spotted 
llvm-svn: 53449
 2008-07-11 06:40:29 +00:00