caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
45,916 Commits 1 Branch 0 Tags
9cfd2f8e577789cf9ddf4792ceee0d2ccd825921
Commit Graph

113 Commits

Author SHA1 Message Date
Duncan Sands
2c741145a7 Supress a gcc-4.3 warning. 
llvm-svn: 53771
 2008-07-18 21:06:02 +00:00
Owen Anderson
04a6e0ba8c Make PRE actually handle critical edges (by splitting them). Confirmed that bootstrap passes with this change. 
llvm-svn: 53762
 2008-07-18 18:03:38 +00:00
Owen Anderson
addbe3eed1 Enable PRE. My last batch of changes fixed the miscompile. 
llvm-svn: 53730
 2008-07-17 19:41:00 +00:00
Owen Anderson
c062381c7b Factor MergeBlockIntoPredecessor out into BasicBlockUtils. 
llvm-svn: 53705
 2008-07-17 00:01:40 +00:00
Owen Anderson
ac31096311 There's no need to iterate block merging and PRE. In fact, iterating the latter 
could cause problems for memdep when it breaks critical edges.

llvm-svn: 53691
 2008-07-16 17:52:31 +00:00
Owen Anderson
24768e3dc4 Revert this, as it seems to still be broken. 
llvm-svn: 53627
 2008-07-15 17:59:02 +00:00
Owen Anderson
9d1f497a28 Enable local PRE by default. 
llvm-svn: 53616
 2008-07-15 16:28:23 +00:00
Owen Anderson
53d546e40b Have GVN do a pre-pass over the CFG that folds away unconditional branches where possible. This allows local PRE to be more aggressive. 
llvm-svn: 53615
 2008-07-15 16:28:06 +00:00
Owen Anderson
8e462e9a82 Don't call lookupNumber more than we have to. 
llvm-svn: 53470
 2008-07-11 20:05:13 +00:00
Owen Anderson
3ea90a7d55 Use information already present in the ValueTable to fast-fail when we know there won't be a value number match. This speeds up GVN on a case where there are very few redundancies by ~25%. 
llvm-svn: 53108
 2008-07-03 17:44:33 +00:00
Owen Anderson
6acc782dad Avoid a redundant call. 
llvm-svn: 53040
 2008-07-02 18:15:31 +00:00
Owen Anderson
b22a640fe4 A better fix for PR2503 that doesn't pessimize GVN in the presence of unreachable blocks. 
llvm-svn: 53032
 2008-07-02 17:20:16 +00:00
Evan Cheng
403e567043 Disable PRE. It's breaking bootstrapping. 
llvm-svn: 52643
 2008-06-23 21:22:35 +00:00
Owen Anderson
54e02194a1 Tighten the conditions under which we do PRE, remove some unneeded code, and correct our preserved analyses list, since we 
do now change the CFG by splitting critical edges during PRE.

llvm-svn: 52631
 2008-06-23 17:49:45 +00:00
Evan Cheng
42bbca11cc Enable PRE. 
llvm-svn: 52574
 2008-06-21 07:26:53 +00:00
Owen Anderson
78fbcafb53 Really disable PRE. 
llvm-svn: 52531
 2008-06-20 08:59:13 +00:00
Owen Anderson
1b3ea963f7 Change around the data structures used to store availability sets, resulting in a GVN+PRE that is faster that GVN alone was before. 
llvm-svn: 52521
 2008-06-20 01:15:47 +00:00
Evan Cheng
9598f930f3 Disable PRE for now. It seems to be breaking llvm-gcc bootstrapping. 
llvm-svn: 52518
 2008-06-20 01:01:07 +00:00
Owen Anderson
e780d66657 Add a hidden -disable-pre flag for testing purposes. This should be removed 
once benchmarking is completed.

llvm-svn: 52506
 2008-06-19 19:57:25 +00:00
Owen Anderson
fdf9f168b5 PRE requires that critical edges be split. 
llvm-svn: 52505
 2008-06-19 19:54:19 +00:00
Owen Anderson
ff21db851d Be sure to remove values from the value numbering table after we delete them. 
This fixes a failure on povray.

llvm-svn: 52499
 2008-06-19 17:53:26 +00:00
Owen Anderson
45d3701fce Revert support for insertvalue and extractvalue instructions for the moment. 
GVN expects that all inputs which to an instruction fall somewhere in the value
hierarchy, which isn't true for these.

llvm-svn: 52496
 2008-06-19 17:25:39 +00:00
Owen Anderson
3ea800fbad Add support for extractvalue and insertvalue instructions in GVN. 
llvm-svn: 52472
 2008-06-18 21:59:00 +00:00
Owen Anderson
6a903bc601 Add local PRE to GVN. This only operates in cases where it would not increase code size, namely when the instantiated expression 
would only need to be created in one predecessor.

llvm-svn: 52471
 2008-06-18 21:41:49 +00:00
Owen Anderson
75f3732b23 We don't want to find dependencies within the same block in this case. It leads to incorrect results because 
we're detecting something at or after the call we're querying on.

llvm-svn: 52433
 2008-06-17 22:27:06 +00:00
Owen Anderson
accdca1b03 Switch GVN to use ScopedHashTable. 
llvm-svn: 52242
 2008-06-12 19:25:32 +00:00
Matthijs Kooijman
5afc2740b7 Update comments and documentation to reflect that GCSE and ValueNumbering are 
deprecated by the GVN and GVNPRE passes.

llvm-svn: 51983
 2008-06-05 07:55:49 +00:00
Owen Anderson
61c7f2a633 Remove unneeded #include. 
llvm-svn: 51955
 2008-06-04 18:28:10 +00:00
Nate Begeman
65720c968c Teach GVN to not assert on vector comparisons 
llvm-svn: 51230
 2008-05-18 19:49:05 +00:00
Owen Anderson
17816b321f Fix Analysis/BasicAA/pure-const-dce.ll. This turned out to be a correctness 
bug as well as a missed optimization.  We weren't properly checking for local
dependencies before moving on to non-local ones when doing non-local read-only 
call CSE.

llvm-svn: 51082
 2008-05-13 23:18:30 +00:00
Owen Anderson
8c2391d00d Make the non-local CSE safety checks slightly more thorough. 
llvm-svn: 51035
 2008-05-13 13:41:23 +00:00
Owen Anderson
69057b80c7 Add support for non-local CSE of read-only calls. 
llvm-svn: 51024
 2008-05-13 08:17:22 +00:00
Owen Anderson
f792860255 Go back to passing the analyses around as parameters. 
llvm-svn: 50995
 2008-05-12 20:15:55 +00:00
Owen Anderson
4afb1c864a Move the various analyses used by GVN into static variables so we don't have to keep passing them around or refetching them. 
llvm-svn: 50963
 2008-05-12 08:15:27 +00:00
Owen Anderson
a5b96ecef9 Remove unneeded #include's. 
llvm-svn: 50035
 2008-04-21 07:47:38 +00:00
Owen Anderson
f9ae76d89c Make GVN able to remove unnecessary calls to read-only functions again. 
llvm-svn: 49842
 2008-04-17 05:36:50 +00:00
Owen Anderson
1e73f29a7f Fix PR2213 by simultaneously making GVN more aggressive with the return values 
of calls and less aggressive with non-readnone calls.

llvm-svn: 49516
 2008-04-11 05:11:49 +00:00
Owen Anderson
ef9a6fd5c2 Factor a bunch of functionality related to memcpy and memset transforms out of 
GVN and into its own pass.

llvm-svn: 49419
 2008-04-09 08:23:16 +00:00
Owen Anderson
8ee792d1b6 Remove accidentally duplicated code. 
llvm-svn: 49418
 2008-04-09 07:55:01 +00:00
Owen Anderson
ed92b41a39 Add operator= implementations to SparseBitVector, allowing it to be used in GVN. This results 
in both time and memory savings for GVN.  For example, one testcase went from 10.5s to 6s with
this patch.

llvm-svn: 49345
 2008-04-07 17:38:23 +00:00
Owen Anderson
0c1e634cbb Make GVN more memory efficient, particularly on code that contains a large number of 
allocations, which GVN can't optimize anyways.

llvm-svn: 49329
 2008-04-07 09:59:07 +00:00
Gabor Greif
e9ecc68d8f API changes for class Use size reduction, wave 1. 
Specifically, introduction of XXX::Create methods
for Users that have a potentially variable number of
Uses.

llvm-svn: 49277
 2008-04-06 20:25:17 +00:00
Chris Lattner
4311ad2dae change iterator invalidation avoidance to just move the iterator backward 
when something changes, instead of moving forward.  This allows us to 
simplify memset lowering, inserting the memset at the end of the range of 
stuff we're touching instead of at the start.

This, in turn, allows us to make use of the addressing instructions already
used in the function instead of inserting our own.  For example, we now
codegen:

	%tmp41 = getelementptr [8 x i8]* %ref_idx, i32 0, i32 0		; <i8*> [#uses=2]
	call void @llvm.memset.i64( i8* %tmp41, i8 -1, i64 8, i32 1 )

instead of:

	%tmp20 = getelementptr [8 x i8]* %ref_idx, i32 0, i32 7		; <i8*> [#uses=1]
	%ptroffset = getelementptr i8* %tmp20, i64 -7		; <i8*> [#uses=1]
	call void @llvm.memset.i64( i8* %ptroffset, i8 -1, i64 8, i32 1 )

llvm-svn: 48940
 2008-03-29 05:15:47 +00:00
Chris Lattner
ac95515741 make the common case of a single store (which clearly shouldn't be turned 
into a memset!) faster by avoiding an allocation of an std::list node.

llvm-svn: 48939
 2008-03-29 04:52:12 +00:00
Chris Lattner
d528b21a65 give form-memset a significantly more sane heuristic, enable it by default. 
llvm-svn: 48937
 2008-03-29 04:36:18 +00:00
Chris Lattner
d62964a7d8 make memset inference significantly more powerful: it can now handle 
memsets that initialize "structs of arrays" and other store sequences
that are not sequential.  This is still only enabled if you pass 
-form-memset-from-stores.  The flag is not heavily tested and I haven't
analyzed the perf regressions when -form-memset-from-stores is passed
either, but this causes no make check regressions.

llvm-svn: 48909
 2008-03-28 06:45:13 +00:00
Evan Cheng
21a8e3d260 Temporarily disabling memset forming optimization. Add an option. 
llvm-svn: 48720
 2008-03-24 05:28:38 +00:00
Chris Lattner
53ccb62712 implement an initial hack at a straight-line store -> memset optimization. 
This fires dozens of times across spec and multisource, but I don't know
if it actually speeds stuff up.  Hopefully the testers will show something
nice :)

llvm-svn: 48680
 2008-03-22 05:37:16 +00:00
Chris Lattner
168be766a8 implement the logic for memset insertion and store deletion. 
llvm-svn: 48679
 2008-03-22 04:13:49 +00:00
Chris Lattner
f5d41c67af This is a partially implemented and currently disabled start of a store 
merging optimization.  Nothing to see here, hopefully more later :)

llvm-svn: 48670
 2008-03-22 00:31:52 +00:00