clang-p2996

caio/clang-p2996

Fork 0

Commit Graph

Author	SHA1	Message	Date
Pavel Labath	fdb2d99eaf	Fix-up r278299 for windows FD_SETSIZE on windows limits the number of file descriptors, rather than their individual magnitude (the underlying implementation uses an array rather than a bitset). This meant that the assert in the SelectHelper was incorrect, and failing all the time. Fix that. I am not sure whether this should be #ifdef MSVC, or #ifdef WINDOWS, but my feeling is that a more posix-conforming implementation on windows would choose the bitset implementation, so I'm sticking with the former. llvm-svn: 278500	2016-08-12 11:20:21 +00:00
Greg Clayton	ee1f578d62	Centralize all select() calls into one place so that we can take advantage of system specific optimizations to deal with more file descriptors than FD_SETSIZE on some systems. <rdar://problem/25325383> https://reviews.llvm.org/D22950 llvm-svn: 278299	2016-08-10 22:43:48 +00:00

Author

SHA1

Message

Date

Pavel Labath

fdb2d99eaf

Fix-up r278299 for windows

FD_SETSIZE on windows limits the number of file descriptors, rather than their individual
magnitude (the underlying implementation uses an array rather than a bitset). This meant that the
assert in the SelectHelper was incorrect, and failing all the time. Fix that.

I am not sure whether this should be #ifdef MSVC, or #ifdef WINDOWS, but my feeling is that a
more posix-conforming implementation on windows would choose the bitset implementation, so I'm
sticking with the former.

llvm-svn: 278500

2016-08-12 11:20:21 +00:00

Greg Clayton

ee1f578d62

Centralize all select() calls into one place so that we can take advantage of system specific optimizations to deal with more file descriptors than FD_SETSIZE on some systems.

<rdar://problem/25325383>
https://reviews.llvm.org/D22950

llvm-svn: 278299

2016-08-10 22:43:48 +00:00

2 Commits