caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
31,724 Commits 1 Branch 0 Tags
da17029218cf0c19cf0341dda1ba557471e33871
Commit Graph

3100 Commits

Author SHA1 Message Date
Chris Lattner
3b2917bfcf * Pull some code out into the definedInRegion/definedInCaller methods 
* Add a stub for the severSplitPHINodes which will allow us to bbextract
  bb's with PHI nodes in them soon.
* Remove unused arguments from findInputsOutputs
* Dramatically simplify the code in findInputsOutputs.  In particular,
  nothing really cares whether or not a PHI node is using something.
* Move moveCodeToFunction to after emitCallAndSwitchStatement as that's the
  order they get called.
* Fix a bug where we would code extract a region that included a call to
  vastart.  Like 'alloca', calls to vastart must stay in the function that
  they are defined in.
* Add some comments.

llvm-svn: 13482
 2004-05-12 06:01:40 +00:00
Chris Lattner
ffc4926263 Generate substantially better code when there are a limited number of exits 
from the extracted region.  If the return has 0 or 1 exit blocks, the new
function returns void.  If it has 2 exits, it returns bool, otherwise it
returns a ushort as before.

This allows us to use a conditional branch instruction when there are two
exit blocks, as often happens during block extraction.

llvm-svn: 13481
 2004-05-12 04:14:24 +00:00
Chris Lattner
3d1ca67fdd Two minor improvements: 
1. Get rid of the silly abort block.  When doing bb extraction, we get one
     abort block for every block extracted, which is kinda annoying.
  2. If the switch ends up having a single destination, turn it into an
     unconditional branch.

I would like to add support for conditional branches, but to do this we will
want to have the function return a bool instead of a ushort.

llvm-svn: 13478
 2004-05-12 03:22:33 +00:00
Chris Lattner
8ec5f88c79 Fix stupid bug in my checkin yesterday 
llvm-svn: 13429
 2004-05-08 22:41:42 +00:00
Chris Lattner
5f667a6f58 Implement folding of GEP's like: 
%tmp.0 = getelementptr [50 x sbyte]* %ar, uint 0, int 5         ; <sbyte*> [#uses=2]
        %tmp.7 = getelementptr sbyte* %tmp.0, int 8             ; <sbyte*> [#uses=1]

together.  This patch actually allows us to simplify and generalize the code.

llvm-svn: 13415
 2004-05-07 22:09:22 +00:00
Chris Lattner
d9e5813821 Fix PR336: The instcombine pass asserts when visiting load instruction 
llvm-svn: 13400
 2004-05-07 15:35:56 +00:00
Chris Lattner
9490849028 Do not mark instructions in unreachable sections of the function as live. 
This fixes PR332 and ADCE/2004-05-04-UnreachableBlock.llx

llvm-svn: 13349
 2004-05-04 17:00:46 +00:00
Chris Lattner
dd1a86d858 Minor efficiency tweak, suggested by Patrick Meredith 
llvm-svn: 13341
 2004-05-04 15:19:33 +00:00
Brian Gaeke
5237476f75 Fix typo 
llvm-svn: 13340
 2004-05-03 23:52:07 +00:00
Brian Gaeke
e96196081e In InsertProfilingInitCall(), make it legal to pass in a null array, in 
which case you'll get a null array and zero passed to the profiling function.

llvm-svn: 13336
 2004-05-03 22:06:33 +00:00
Brian Gaeke
088dd3e121 Add initial implementation of basic-block tracing instrumentation pass. 
llvm-svn: 13335
 2004-05-03 22:06:32 +00:00
Chris Lattner
be6f06818c Do not clone arbitrary condition instructions. 
llvm-svn: 13316
 2004-05-02 05:19:36 +00:00
Chris Lattner
51a6dbcb65 Do not infinitely "unroll" single BB loops. 
llvm-svn: 13315
 2004-05-02 05:02:03 +00:00
Chris Lattner
1e94ed606e Dont' merge terminators that are needed to select PHI node values. 
llvm-svn: 13312
 2004-05-02 01:00:44 +00:00
Chris Lattner
2e93c4275e Implement SimplifyCFG/branch-cond-merge.ll 
Turning "if (A < B && B < C)" into "if (A < B & B < C)"

llvm-svn: 13311
 2004-05-01 23:35:43 +00:00
Chris Lattner
63d75af920 Make sure to reprocess instructions used by deleted instructions to avoid 
missing opportunities for combination.

llvm-svn: 13309
 2004-05-01 23:27:23 +00:00
Chris Lattner
b643a9e675 Make sure the instruction combiner doesn't lose track of instructions 
when replacing them, missing the opportunity to do simplifications

llvm-svn: 13308
 2004-05-01 23:19:52 +00:00
Chris Lattner
4cbd160b45 Fix my missing parens 
llvm-svn: 13307
 2004-05-01 22:41:51 +00:00
Chris Lattner
88da6f7b52 Implement SimplifyCFG/branch-cond-prop.ll 
llvm-svn: 13306
 2004-05-01 22:36:37 +00:00
Chris Lattner
652064e3b8 Fix a major pessimization in the instcombiner. If an allocation instruction 
is only used by a cast, and the casted type is the same size as the original
allocation, it would eliminate the cast by folding it into the allocation.

Unfortunately, it was placing the new allocation instruction right before
the cast, which could pull (for example) alloca instructions into the body
of a function.  This turns statically allocatable allocas into expensive
dynamically allocated allocas, which is bad bad bad.

This fixes the problem by placing the new allocation instruction at the same
place the old one was, duh. :)

llvm-svn: 13289
 2004-04-30 04:37:52 +00:00
Chris Lattner
2d3a7a6ff0 Changes to fix up the inst_iterator to pass to boost iterator checks. This 
patch was graciously contributed by Vladimir Prus.

llvm-svn: 13185
 2004-04-27 15:13:33 +00:00
Chris Lattner
e20c334e65 Instcombine X/-1 --> 0-X 
llvm-svn: 13172
 2004-04-26 14:01:59 +00:00
Misha Brukman
3596f0a180 * Allow aggregating extracted function arguments (controlled by flag) 
* Commandline option (for now) controls that flag that is passed in

llvm-svn: 13141
 2004-04-23 23:54:17 +00:00
Chris Lattner
83cd87efcd Move the scev expansion code into this pass, where it belongs. There is 
still room for cleanup, but at least the code modification is out of the
analysis now.

llvm-svn: 13135
 2004-04-23 21:29:48 +00:00
Misha Brukman
98aa516a9c Clarify the logic: the flag is renamed to `deleteFn' to signify it will delete 
the function instead of isolating it. This also means the condition is reversed.

llvm-svn: 13112
 2004-04-22 23:00:51 +00:00
Misha Brukman
e0682426f0 Add a flag to choose between isolating a function or deleting the function from 
the Module. The default behavior keeps functionality as before: the chosen
function is the one that remains.

llvm-svn: 13111
 2004-04-22 22:52:22 +00:00
Chris Lattner
c27302c79f Disable a previous patch that was causing indvars to loop infinitely :( 
llvm-svn: 13108
 2004-04-22 15:12:36 +00:00
Chris Lattner
c1a682dda0 Fix an extremely serious thinko I made in revision 1.60 of this file. 
llvm-svn: 13106
 2004-04-22 14:59:40 +00:00
Chris Lattner
af532f27e7 Implement a todo, rewriting all possible scev expressions inside of the 
loop.  This eliminates the extra add from the previous case, but it's
not clear that this will be a performance win overall.  Tommorows test
results will tell. :)

llvm-svn: 13103
 2004-04-21 23:36:08 +00:00
Chris Lattner
fb9a299f68 This code really wants to iterate over the OPERANDS of an instruction, not 
over its USES.  If it's dead it doesn't have any uses!  :)

Thanks to the fabulous and mysterious Bill Wendling for pointing this out.  :)

llvm-svn: 13102
 2004-04-21 22:29:37 +00:00
Chris Lattner
dc7cc35088 Implement a fixme. The helps loops that have induction variables of different 
types in them.  Instead of creating an induction variable for all types, it
creates a single induction variable and casts to the other sizes.  This generates
this code:

no_exit:                ; preds = %entry, %no_exit
        %indvar = phi uint [ %indvar.next, %no_exit ], [ 0, %entry ]            ; <uint> [#uses=4]
***     %j.0.0 = cast uint %indvar to short             ; <short> [#uses=1]
        %indvar = cast uint %indvar to int              ; <int> [#uses=1]
        %tmp.7 = getelementptr short* %P, uint %indvar          ; <short*> [#uses=1]
        store short %j.0.0, short* %tmp.7
        %inc.0 = add int %indvar, 1             ; <int> [#uses=2]
        %tmp.2 = setlt int %inc.0, %N           ; <bool> [#uses=1]
        %indvar.next = add uint %indvar, 1              ; <uint> [#uses=1]
        br bool %tmp.2, label %no_exit, label %loopexit

instead of:

no_exit:                ; preds = %entry, %no_exit
        %indvar = phi ushort [ %indvar.next, %no_exit ], [ 0, %entry ]          ; <ushort> [#uses=2]
***     %indvar = phi uint [ %indvar.next, %no_exit ], [ 0, %entry ]            ; <uint> [#uses=3]
        %indvar = cast uint %indvar to int              ; <int> [#uses=1]
        %indvar = cast ushort %indvar to short          ; <short> [#uses=1]
        %tmp.7 = getelementptr short* %P, uint %indvar          ; <short*> [#uses=1]
        store short %indvar, short* %tmp.7
        %inc.0 = add int %indvar, 1             ; <int> [#uses=2]
        %tmp.2 = setlt int %inc.0, %N           ; <bool> [#uses=1]
        %indvar.next = add uint %indvar, 1
***     %indvar.next = add ushort %indvar, 1
        br bool %tmp.2, label %no_exit, label %loopexit

This is an improvement in register pressure, but probably doesn't happen that
often.

The more important fix will be to get rid of the redundant add.

llvm-svn: 13101
 2004-04-21 22:22:01 +00:00
Chris Lattner
be8bb804c5 Fix an incredibly nasty iterator invalidation problem. I am too spoiled by ilists :) 
Eventually it would be nice if CallGraph maintained an ilist of CallGraphNode's instead
of a vector of pointers to them, but today is not that day.

llvm-svn: 13100
 2004-04-21 20:44:33 +00:00
Alkis Evlogimenos
f68f40ea42 Include cerrno (gcc-3.4 fix) 
llvm-svn: 13091
 2004-04-21 16:11:40 +00:00
Chris Lattner
a9691fe70d Fix typeo 
llvm-svn: 13089
 2004-04-21 14:23:18 +00:00
Chris Lattner
c87784f1fc REALLY fix PR324: don't delete linkonce functions until after the SCC traversal 
is done, which avoids invalidating iterators in the SCC traversal routines

llvm-svn: 13088
 2004-04-20 22:06:53 +00:00
Chris Lattner
c1aa21f5a7 Fix PR325 
llvm-svn: 13081
 2004-04-20 20:26:03 +00:00
Chris Lattner
514934051a Fix PR324 and testcase: Inline/2004-04-20-InlineLinkOnce.llx 
llvm-svn: 13080
 2004-04-20 20:20:59 +00:00
Chris Lattner
f48f777d4c Initial checkin of a simple loop unswitching pass. It still needs work, 
but it's a start, and seems to do it's basic job.

llvm-svn: 13068
 2004-04-19 18:07:02 +00:00
Chris Lattner
bc02177fdc Add #include 
llvm-svn: 13057
 2004-04-19 03:01:23 +00:00
Chris Lattner
fc44a25bcb Move isLoopInvariant to the Loop class 
llvm-svn: 13051
 2004-04-18 22:46:08 +00:00
Chris Lattner
827826320d Correct rewriting of exit blocks after my last patch 
llvm-svn: 13048
 2004-04-18 22:27:10 +00:00
Chris Lattner
35eaa55cfc Loop exit sets are no longer explicitly held, they are dynamically computed on demand. 
llvm-svn: 13046
 2004-04-18 22:15:13 +00:00
Chris Lattner
d72c3eb54e Change the ExitBlocks list from being explicitly contained in the Loop 
structure to being dynamically computed on demand.  This makes updating
loop information MUCH easier.

llvm-svn: 13045
 2004-04-18 22:14:10 +00:00
Chris Lattner
d15250240c Reduce the unrolling limit 
llvm-svn: 13040
 2004-04-18 18:06:14 +00:00
Chris Lattner
30ae18155d If the preheader of the loop was the entry block of the function, make sure 
that the exit block of the loop becomes the new entry block of the function.

This was causing a verifier assertion on 252.eon.

llvm-svn: 13039
 2004-04-18 17:38:42 +00:00
Chris Lattner
230bcb6b35 Be much more careful about how we update instructions outside of the loop 
using instructions inside of the loop.  This should fix the MishaTest failure
from last night.

llvm-svn: 13038
 2004-04-18 17:32:39 +00:00
Chris Lattner
4d52e1e401 After unrolling our single basic block loop, fold it into the preheader and exit 
block.  The primary motivation for doing this is that we can now unroll nested loops.

This makes a pretty big difference in some cases.  For example, in 183.equake,
we are now beating the native compiler with the CBE, and we are a lot closer
with LLC.

I'm now going to play around a bit with the unroll factor and see what effect
it really has.

llvm-svn: 13034
 2004-04-18 06:27:43 +00:00
Chris Lattner
f2cc841619 Fix a bug: this does not preserve the CFG! 
While we're at it, add support for updating loop information correctly.

llvm-svn: 13033
 2004-04-18 05:38:37 +00:00
Chris Lattner
946b255977 Initial checkin of a simple loop unroller. This pass is extremely basic and 
limited.  Even in it's extremely simple state (it can only *fully* unroll single
basic block loops that execute a constant number of times), it already helps improve
performance a LOT on some benchmarks, particularly with the native code generators.

llvm-svn: 13028
 2004-04-18 05:20:17 +00:00
Chris Lattner
c14da9600b Make the tail duplication threshold accessible from the command line instead of hardcoded 
llvm-svn: 13025
 2004-04-18 00:52:43 +00:00