As discussed in PR #142353, the current testsuite of the `clang` Python bindings has several issues: - It `libclang.so` cannot be loaded into `python` to run the testsuite, the whole `ninja check-all` aborts. - The result of running the testsuite isn't report like the `lit`-based tests, rendering them almost invisible. - The testsuite is disabled in a non-obvious way (`RUN_PYTHON_TESTS`) in `tests/CMakeLists.txt`, which again doesn't show up in the test results. All these issues can be avoided by integrating the Python bindings tests with `lit`, which is what this patch does: - The actual test lives in `clang/test/bindings/python/bindings.sh` and is run by `lit`. - The current `clang/bindings/python/tests` directory (minus the now-subperfluous `CMakeLists.txt`) is moved into the same directory. - The check if `libclang` is loadable (originally from PR #142353) is now handled via a new `lit` feature, `libclang-loadable`. - The various ways to disable the tests have been turned into `XFAIL`s as appropriate. This isn't complete and not completely tested yet. Tested on `sparc-sun-solaris2.11`, `sparcv9-sun-solaris2.11`, `i386-pc-solaris2.11`, `amd64-pc-solaris2.11`, `i686-pc-linux-gnu`, and `x86_64-pc-linux-gnu`. Co-authored-by: Rainer Orth <ro@gcc.gnu.org>
42 lines
1.2 KiB
YAML
42 lines
1.2 KiB
YAML
name: Libclang Python Binding Tests
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
on:
|
|
workflow_dispatch:
|
|
push:
|
|
branches:
|
|
- 'main'
|
|
paths:
|
|
- 'clang/bindings/python/**'
|
|
- 'clang/test/bindings/python/**'
|
|
- 'clang/tools/libclang/**'
|
|
- '.github/workflows/libclang-python-tests.yml'
|
|
- '.github/workflows/llvm-project-tests.yml'
|
|
pull_request:
|
|
paths:
|
|
- 'clang/bindings/python/**'
|
|
- 'clang/test/bindings/python/**'
|
|
- 'clang/tools/libclang/**'
|
|
- '.github/workflows/libclang-python-tests.yml'
|
|
- '.github/workflows/llvm-project-tests.yml'
|
|
|
|
jobs:
|
|
check-clang-python:
|
|
# Build libclang and then run the libclang Python binding's unit tests.
|
|
name: Build and run Python unit tests
|
|
if: github.repository == 'llvm/llvm-project'
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
python-version: ["3.8", "3.13"]
|
|
uses: ./.github/workflows/llvm-project-tests.yml
|
|
with:
|
|
build_target: check-clang-python
|
|
projects: clang
|
|
# There is an issue running on "windows-2019".
|
|
# See https://github.com/llvm/llvm-project/issues/76601#issuecomment-1873049082.
|
|
os_list: '["ubuntu-24.04"]'
|
|
python_version: ${{ matrix.python-version }}
|