0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
24 lines
1.2 KiB
Objective-C
24 lines
1.2 KiB
Objective-C
// RUN: %clang_cc1 -fobjc-arc -verify %s
|
|
|
|
#if __has_feature(arc_cf_code_audited)
|
|
#define CF_IMPLICIT_BRIDGING_ENABLED _Pragma("clang arc_cf_code_audited begin")
|
|
#define CF_IMPLICIT_BRIDGING_DISABLED _Pragma("clang arc_cf_code_audited end")
|
|
#endif
|
|
#define CF_BRIDGED_TYPE(T) __attribute__((objc_bridge(T)))
|
|
|
|
typedef const struct CF_BRIDGED_TYPE(NSURL) __CFURL * CFURLRef;
|
|
typedef signed long long CFIndex;
|
|
typedef unsigned char Boolean;
|
|
typedef unsigned char UInt8;
|
|
typedef const struct __CFAllocator * CFAllocatorRef;
|
|
const CFAllocatorRef kCFAllocatorDefault;
|
|
|
|
CF_IMPLICIT_BRIDGING_ENABLED
|
|
CFURLRef CFURLCreateFromFileSystemRepresentation(CFAllocatorRef allocator, const UInt8 *buffer, CFIndex bufLen, Boolean isDirectory); // expected-note {{passing argument to parameter 'buffer' here}}
|
|
CF_IMPLICIT_BRIDGING_DISABLED
|
|
|
|
void saveImageToJPG(const char *filename)
|
|
{
|
|
CFURLRef url = CFURLCreateFromFileSystemRepresentation(kCFAllocatorDefault, filename, 10, 0); // expected-warning {{passing 'const char *' to parameter of type 'const UInt8 *' (aka 'const unsigned char *') converts between pointers to integer types where one is of the unique plain 'char' type and the other is not}}
|
|
}
|