6ad2987a72
This section contains metadata that's only relevant for Identical Code
Folding at link time, we should not include it in the output.
We still treat it like a regular section during input file parsing (e.g.
create a `ConcatInputSection` for it), as we want its relocations to be
parsed. But it should not be passed to `addInputSection`, as that's what
assigns it to an `OutputSection` and adds it to the `inputSections`
vector which specifies the inputs to dead-stripping and relocation
scanning.
This fixes a "__DATA,__llvm_addrsig, offset 0: fixups overlap" error
when using `--icf=safe` alongside `-fixup_chains`. This occurs because
all `__llvm_addrsig` sections are 8 bytes large, and the relocations
which signify functions whose addresses are taken are all at offset 0.
This makes the fix in 5fa24ac2 ("Category Merger: add support for
addrsig references") obsolete, as we no longer try to resolve symbols
referenced in `__llvm_addrsig` when writing the output file. When we do
iterate its relocations in `markAddrSigSymbols`, we do not try to
resolve their addresses.
74 lines
2.7 KiB
LLVM
74 lines
2.7 KiB
LLVM
; REQUIRES: aarch64
|
|
|
|
; RUN: rm -rf %t; mkdir %t
|
|
|
|
; RUN: llc -filetype=obj %s -O3 -o %t/icf-obj.o -enable-machine-outliner=never -mtriple arm64-apple-macos -addrsig
|
|
; RUN: %lld -arch arm64 -lSystem --icf=safe -dylib -o %t/icf-safe.dylib %t/icf-obj.o
|
|
; RUN: %lld -arch arm64 -lSystem --icf=all -dylib -o %t/icf-all.dylib %t/icf-obj.o
|
|
; RUN: llvm-objdump %t/icf-safe.dylib -d -h --macho | FileCheck %s --check-prefixes=ICFSAFE,CHECK
|
|
; RUN: llvm-objdump %t/icf-all.dylib -d -h --macho | FileCheck %s --check-prefixes=ICFALL,CHECK
|
|
|
|
; RUN: llvm-as %s -o %t/icf-bitcode.o
|
|
; RUN: %lld -arch arm64 -lSystem --icf=safe -dylib -o %t/icf-safe-bitcode.dylib %t/icf-bitcode.o
|
|
; RUN: %lld -arch arm64 -lSystem --icf=all -dylib -o %t/icf-all-bitcode.dylib %t/icf-bitcode.o
|
|
; RUN: llvm-objdump %t/icf-safe-bitcode.dylib -d -h --macho | FileCheck %s --check-prefixes=ICFSAFE,CHECK
|
|
; RUN: llvm-objdump %t/icf-all-bitcode.dylib -d -h --macho | FileCheck %s --check-prefixes=ICFALL,CHECK
|
|
|
|
;; Regression test: if we tried writing __llvm_addrsig to the output, -fixup_chains would fail with a "fixups overlap"
|
|
;; error, as the relocations (which reference the address-taken functions) are all at offset 0.
|
|
; RUN: %lld -arch arm64 -lSystem --icf=safe -fixup_chains -dylib -o %t/icf-safe-chained.dylib %t/icf-obj.o
|
|
; RUN: llvm-objdump %t/icf-safe-chained.dylib -d -h --macho | FileCheck %s --check-prefixes=ICFSAFE,CHECK
|
|
|
|
; ICFSAFE-LABEL: _callAllFunctions
|
|
; ICFSAFE: bl _func02
|
|
; ICFSAFE-NEXT: bl _func02
|
|
; ICFSAFE-NEXT: bl _func03_takeaddr
|
|
|
|
; ICFALL-LABEL: _callAllFunctions
|
|
; ICFALL: bl _func03_takeaddr
|
|
; ICFALL-NEXT: bl _func03_takeaddr
|
|
; ICFALL-NEXT: bl _func03_takeaddr
|
|
|
|
; CHECK-LABEL: Sections:
|
|
; CHECK-NOT: __llvm_addrsig
|
|
|
|
target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"
|
|
target triple = "arm64-apple-macos11.0"
|
|
|
|
@result = global i32 0, align 4
|
|
|
|
define void @func01() local_unnamed_addr noinline {
|
|
entry:
|
|
%0 = load volatile i32, ptr @result, align 4
|
|
%add = add nsw i32 %0, 1
|
|
store volatile i32 %add, ptr @result, align 4
|
|
ret void
|
|
}
|
|
|
|
define void @func02() local_unnamed_addr noinline {
|
|
entry:
|
|
%0 = load volatile i32, ptr @result, align 4
|
|
%add = add nsw i32 %0, 1
|
|
store volatile i32 %add, ptr @result, align 4
|
|
ret void
|
|
}
|
|
|
|
define void @func03_takeaddr() noinline {
|
|
entry:
|
|
%0 = load volatile i32, ptr @result, align 4
|
|
%add = add nsw i32 %0, 1
|
|
store volatile i32 %add, ptr @result, align 4
|
|
ret void
|
|
}
|
|
|
|
define void @callAllFunctions() local_unnamed_addr {
|
|
entry:
|
|
tail call void @func01()
|
|
tail call void @func02()
|
|
tail call void @func03_takeaddr()
|
|
%0 = load volatile i32, ptr @result, align 4
|
|
%add = add nsw i32 %0, ptrtoint (ptr @func03_takeaddr to i32)
|
|
store volatile i32 %add, ptr @result, align 4
|
|
ret void
|
|
}
|