Files
clang-p2996/lldb/unittests/Platform/Android/AdbClientTest.cpp
Emre Kultursay 7ff2de4f0c Do not list adb devices when a device id is given
Summary:
On Android, this method gets called twice: first when establishing
a host-server connection, then when attaching to a process id.

Each call takes several seconds to finish (especially slower on Windows)
and eliminating the call for the typical case improves latency significantly.

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D79586
2020-05-29 11:36:11 +02:00

52 lines
1.4 KiB
C++

//===-- AdbClientTest.cpp -------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "gtest/gtest.h"
#include "Plugins/Platform/Android/AdbClient.h"
#include <cstdlib>
static void set_env(const char *var, const char *value) {
#ifdef _WIN32
_putenv_s(var, value);
#else
setenv(var, value, true);
#endif
}
using namespace lldb;
using namespace lldb_private;
namespace lldb_private {
namespace platform_android {
class AdbClientTest : public ::testing::Test {
public:
void SetUp() override { set_env("ANDROID_SERIAL", ""); }
void TearDown() override { set_env("ANDROID_SERIAL", ""); }
};
TEST(AdbClientTest, CreateByDeviceId) {
AdbClient adb;
Status error = AdbClient::CreateByDeviceID("device1", adb);
EXPECT_TRUE(error.Success());
EXPECT_EQ("device1", adb.GetDeviceID());
}
TEST(AdbClientTest, CreateByDeviceId_ByEnvVar) {
set_env("ANDROID_SERIAL", "device2");
AdbClient adb;
Status error = AdbClient::CreateByDeviceID("", adb);
EXPECT_TRUE(error.Success());
EXPECT_EQ("device2", adb.GetDeviceID());
}
} // end namespace platform_android
} // end namespace lldb_private