5e50dd048e
This commit restructures how TypeID is implemented to ideally avoid the current problems related to shared libraries. This is done by changing the "implicit" fallback path to use the name of the type, instead of using a static template variable (which breaks shared libraries). The major downside to this is that it adds some additional initialization costs for the implicit path. Given the use of type names for uniqueness in the fallback, we also no longer allow types defined in anonymous namespaces to have an implicit TypeID. To simplify defining an ID for these classes, a new `MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID` macro was added to allow for explicitly defining a TypeID directly on an internal class. To help identify when types are using the fallback, `-debug-only=typeid` can be used to log which types are using implicit ids. This change generally only requires changes to the test passes, which are all defined in anonymous namespaces, and thus can't use the fallback any longer. Differential Revision: https://reviews.llvm.org/D122775
87 lines
2.6 KiB
C++
87 lines
2.6 KiB
C++
//===- DialectConversion.cpp - Dialect conversion unit tests --------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/IR/PatternMatch.h"
|
|
#include "mlir/Parser/Parser.h"
|
|
#include "mlir/Pass/PassManager.h"
|
|
#include "mlir/Transforms/GreedyPatternRewriteDriver.h"
|
|
#include "mlir/Transforms/Passes.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace mlir;
|
|
|
|
namespace {
|
|
|
|
struct DisabledPattern : public RewritePattern {
|
|
DisabledPattern(MLIRContext *context)
|
|
: RewritePattern("test.foo", /*benefit=*/0, context,
|
|
/*generatedNamed=*/{}) {
|
|
setDebugName("DisabledPattern");
|
|
}
|
|
|
|
LogicalResult matchAndRewrite(Operation *op,
|
|
PatternRewriter &rewriter) const override {
|
|
if (op->getNumResults() != 1)
|
|
return failure();
|
|
rewriter.eraseOp(op);
|
|
return success();
|
|
}
|
|
};
|
|
|
|
struct EnabledPattern : public RewritePattern {
|
|
EnabledPattern(MLIRContext *context)
|
|
: RewritePattern("test.foo", /*benefit=*/0, context,
|
|
/*generatedNamed=*/{}) {
|
|
setDebugName("EnabledPattern");
|
|
}
|
|
|
|
LogicalResult matchAndRewrite(Operation *op,
|
|
PatternRewriter &rewriter) const override {
|
|
if (op->getNumResults() == 1)
|
|
return failure();
|
|
rewriter.eraseOp(op);
|
|
return success();
|
|
}
|
|
};
|
|
|
|
struct TestDialect : public Dialect {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestDialect)
|
|
|
|
static StringRef getDialectNamespace() { return "test"; }
|
|
|
|
TestDialect(MLIRContext *context)
|
|
: Dialect(getDialectNamespace(), context, TypeID::get<TestDialect>()) {
|
|
allowUnknownOperations();
|
|
}
|
|
|
|
void getCanonicalizationPatterns(RewritePatternSet &results) const override {
|
|
results.add<DisabledPattern, EnabledPattern>(results.getContext());
|
|
}
|
|
};
|
|
|
|
TEST(CanonicalizerTest, TestDisablePatterns) {
|
|
MLIRContext context;
|
|
context.getOrLoadDialect<TestDialect>();
|
|
PassManager mgr(&context);
|
|
mgr.addPass(
|
|
createCanonicalizerPass(GreedyRewriteConfig(), {"DisabledPattern"}));
|
|
|
|
const char *const code = R"mlir(
|
|
%0:2 = "test.foo"() {sym_name = "A"} : () -> (i32, i32)
|
|
%1 = "test.foo"() {sym_name = "B"} : () -> (f32)
|
|
)mlir";
|
|
|
|
OwningOpRef<ModuleOp> module = parseSourceString<ModuleOp>(code, &context);
|
|
ASSERT_TRUE(succeeded(mgr.run(*module)));
|
|
|
|
EXPECT_TRUE(module->lookupSymbol("B"));
|
|
EXPECT_FALSE(module->lookupSymbol("A"));
|
|
}
|
|
|
|
} // end anonymous namespace
|