Files
clang-p2996/clang-tools-extra/test/cpp11-migrate/UseNullptr/basic.cpp
Ariel J. Bernal 005daf1bc6 Fix UseNullptr fails to replace explict casts surrounded by another implicit
cast

UseNullptr previously matched the implicit cast to const pointer as well as
the explicit cast within that has an implicit cast to nullptr as a descendant.

-Refactored UseNullptr to avoid special-casing certain kinds of cast sequences
-Added test cases.

llvm-svn: 178907
2013-04-05 20:32:36 +00:00

279 lines
6.2 KiB
C++

// RUN: grep -Ev "// *[A-Z-]+:" %s > %t.cpp
// RUN: grep -Ev "// *[A-Z-]+:" %S/Inputs/basic.h > %T/basic.h
// RUN: cpp11-migrate -use-nullptr %t.cpp -- -I %S
// RUN: FileCheck -input-file=%t.cpp %s
// RUN: FileCheck -input-file=%T/basic.h %S/Inputs/basic.h
#include "Inputs/basic.h"
const unsigned int g_null = 0;
#define NULL 0
// CHECK: #define NULL 0
void test_assignment() {
int *p1 = 0;
// CHECK: int *p1 = nullptr;
p1 = 0;
// CHECK: p1 = nullptr;
int *p2 = NULL;
// CHECK: int *p2 = nullptr;
p2 = p1;
// CHECK: p2 = p1;
const int null = 0;
int *p3 = null;
// CHECK: int *p3 = nullptr;
p3 = NULL;
// CHECK: p3 = nullptr;
int *p4 = p3;
// CHECK: int *p4 = p3;
p4 = null;
// CHECK: p4 = nullptr;
int i1 = 0;
// CHECK: int i1 = 0;
int i2 = NULL;
// CHECK: int i2 = NULL;
int i3 = null;
// CHECK: int i3 = null;
int *p5, *p6, *p7;
p5 = p6 = p7 = NULL;
// CHECK: p5 = p6 = p7 = nullptr;
}
struct Foo {
Foo(int *p = NULL) : m_p1(p) {}
// CHECK: Foo(int *p = nullptr) : m_p1(p) {}
void bar(int *p = 0) {}
// CHECK: void bar(int *p = nullptr) {}
void baz(int i = 0) {}
// CHECK: void baz(int i = 0) {}
int *m_p1;
static int *m_p2;
};
int *Foo::m_p2 = NULL;
// CHECK: int *Foo::m_p2 = nullptr;
template <typename T>
struct Bar {
Bar(T *p) : m_p(p) {
m_p = static_cast<T*>(NULL);
// CHECK: m_p = static_cast<T*>(nullptr);
m_p = static_cast<T*>(reinterpret_cast<int*>((void*)NULL));
// CHECK: m_p = static_cast<T*>(nullptr);
m_p = static_cast<T*>(p ? p : static_cast<void*>(g_null));
// CHECK: m_p = static_cast<T*>(p ? p : static_cast<void*>(nullptr));
T *p2 = static_cast<T*>(reinterpret_cast<int*>((void*)NULL));
// CHECK: T *p2 = static_cast<T*>(nullptr);
m_p = NULL;
// CHECK: m_p = nullptr;
int i = static_cast<int>(0.f);
// CHECK: int i = static_cast<int>(0.f);
T *i2 = static_cast<int>(0.f);
// CHECK: T *i2 = nullptr;
}
T *m_p;
};
struct Baz {
Baz() : i(0) {}
int i;
};
void test_cxx_cases() {
Foo f(g_null);
// CHECK: Foo f(nullptr);
f.bar(NULL);
// CHECK: f.bar(nullptr);
f.baz(g_null);
// CHECK: f.baz(g_null);
f.m_p1 = 0;
// CHECK: f.m_p1 = nullptr;
Bar<int> b(g_null);
// CHECK: Bar<int> b(nullptr);
Baz b2;
int Baz::*memptr(0);
// CHECK: int Baz::*memptr(nullptr);
memptr = 0;
// CHECK: memptr = nullptr;
}
void test_function_default_param1(void *p = 0);
// CHECK: void test_function_default_param1(void *p = nullptr);
void test_function_default_param2(void *p = NULL);
// CHECK: void test_function_default_param2(void *p = nullptr);
void test_function_default_param3(void *p = g_null);
// CHECK: void test_function_default_param3(void *p = nullptr);
void test_function(int *p) {}
// CHECK: void test_function(int *p) {}
void test_function_no_ptr_param(int i) {}
void test_function_call() {
test_function(0);
// CHECK: test_function(nullptr);
test_function(NULL);
// CHECK: test_function(nullptr);
test_function(g_null);
// CHECK: test_function(nullptr);
test_function_no_ptr_param(0);
// CHECK: test_function_no_ptr_param(0);
}
char *test_function_return1() {
return 0;
// CHECK: return nullptr;
}
void *test_function_return2() {
return NULL;
// CHECK: return nullptr;
}
long *test_function_return3() {
return g_null;
// CHECK: return nullptr;
}
int test_function_return4() {
return 0;
// CHECK: return 0;
}
int test_function_return5() {
return NULL;
// CHECK: return NULL;
}
int test_function_return6() {
return g_null;
// CHECK: return g_null;
}
// Test parentheses expressions resulting in a nullptr.
int *test_parentheses_expression1() {
return(0);
// CHECK: return(nullptr);
}
int *test_parentheses_expression2() {
return(int(0.f));
// CHECK: return(nullptr);
}
int *test_nested_parentheses_expression() {
return((((0))));
// CHECK: return((((nullptr))));
}
void *test_parentheses_explicit_cast() {
return(static_cast<void*>(0));
// CHECK: return(static_cast<void*>(nullptr));
}
void *test_parentheses_explicit_cast_sequence1() {
return(static_cast<void*>(static_cast<int*>((void*)NULL)));
// CHECK: return(static_cast<void*>(nullptr));
}
void *test_parentheses_explicit_cast_sequence2() {
return(static_cast<void*>(reinterpret_cast<int*>((float*)int(0.f))));
// CHECK: return(static_cast<void*>(nullptr));
}
// Test explicit cast expressions resulting in nullptr
struct Bam {
Bam(int *a) {}
Bam(float *a) {}
Bam operator=(int *a) { return Bam(a); }
Bam operator=(float *a) { return Bam(a); }
};
void ambiguous_function(int *a) {}
void ambiguous_function(float *a) {}
void const_ambiguous_function(const int *p) {}
void const_ambiguous_function(const float *p) {}
void test_explicit_cast_ambiguous1() {
ambiguous_function((int*)0);
// CHECK: ambiguous_function((int*)nullptr);
}
void test_explicit_cast_ambiguous2() {
ambiguous_function((int*)(0));
// CHECK: ambiguous_function((int*)nullptr);
}
void test_explicit_cast_ambiguous3() {
ambiguous_function(static_cast<int*>(reinterpret_cast<int*>((float*)0)));
// CHECK: ambiguous_function(static_cast<int*>(nullptr));
}
Bam test_explicit_cast_ambiguous4() {
return(((int*)(0)));
// CHECK: return(((int*)nullptr));
}
void test_explicit_cast_ambiguous5() {
// Test for ambiguous overloaded constructors
Bam k((int*)(0));
// CHECK: Bam k((int*)nullptr);
// Test for ambiguous overloaded operators
k = (int*)0;
// CHECK: k = (int*)nullptr;
}
void test_const_pointers_abiguous() {
const_ambiguous_function((int*)0);
// CHECK: const_ambiguous_function((int*)nullptr);
}
// Test where the implicit cast to null is surrounded by another implict cast
// with possible explict casts in-between.
void test_const_pointers() {
const int *const_p1 = 0;
// CHECK: const int *const_p1 = nullptr;
const int *const_p2 = NULL;
// CHECK: const int *const_p2 = nullptr;
const int *const_p3 = (int)0;
// CHECK: const int *const_p3 = nullptr;
const int *const_p4 = (int)0.0f;
// CHECK: const int *const_p4 = nullptr;
const int *const_p5 = (int*)0;
// CHECK: const int *const_p5 = (int*)nullptr;
int *t;
const int *const_p6 = static_cast<int*>(t ? t : static_cast<int*>(0));
// CHECK: const int *const_p6 = static_cast<int*>(t ? t : static_cast<int*>(nullptr));
}