b725142c8d
Summary:
The Scalar class claims to follow the C type conversion rules. This is
true for the Promote function, but it is not true for the implicit
conversions done in the getter methods.
These functions had a subtle bug: when extending the type, they used the
signedness of the *target* type in order to determine whether to do
sign-extension or zero-extension. This is not how things work in C,
which uses the signedness of the *source* type. I.e., C does
(sign-)extension before it does signed->unsigned conversion, and not the
other way around.
This means that: (unsigned long)(int)-1
is equal to (unsigned long)0xffffffffffffffff
and not (unsigned long)0x00000000ffffffff
Unsurprisingly, we have accumulated code which depended on this
inconsistent behavior. It mainly manifested itself as code calling
"ULongLong/SLongLong" as a way to get the value of the Scalar object in
a primitive type that is "large enough". Previously, the ULongLong
conversion did not do sign-extension, but now it does.
This patch makes the Scalar getters consistent with the declared
semantics, and fixes the couple of call sites that were using it
incorrectly.
Reviewers: teemperor, JDevlieghere
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D82772
92 lines
2.9 KiB
Python
92 lines
2.9 KiB
Python
"""
|
|
Test the IR interpreter
|
|
"""
|
|
|
|
|
|
import unittest2
|
|
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class IRInterpreterTestCase(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
NO_DEBUG_INFO_TESTCASE = True
|
|
|
|
def setUp(self):
|
|
# Call super's setUp().
|
|
TestBase.setUp(self)
|
|
# Find the line number to break for main.c.
|
|
self.line = line_number('main.c',
|
|
'// Set breakpoint here')
|
|
|
|
# Disable confirmation prompt to avoid infinite wait
|
|
self.runCmd("settings set auto-confirm true")
|
|
self.addTearDownHook(
|
|
lambda: self.runCmd("settings clear auto-confirm"))
|
|
|
|
def build_and_run(self):
|
|
"""Test the IR interpreter"""
|
|
self.build()
|
|
|
|
self.runCmd("file " + self.getBuildArtifact("a.out"), CURRENT_EXECUTABLE_SET)
|
|
|
|
lldbutil.run_break_set_by_file_and_line(
|
|
self, "main.c", self.line, num_expected_locations=1, loc_exact=False)
|
|
|
|
self.runCmd("run", RUN_SUCCEEDED)
|
|
|
|
@add_test_categories(['pyapi'])
|
|
# getpid() is POSIX, among other problems, see bug
|
|
@expectedFailureAll(
|
|
oslist=['windows'],
|
|
bugnumber="http://llvm.org/pr21765")
|
|
@expectedFailureNetBSD
|
|
def test_ir_interpreter(self):
|
|
self.build_and_run()
|
|
|
|
options = lldb.SBExpressionOptions()
|
|
options.SetLanguage(lldb.eLanguageTypeC_plus_plus)
|
|
|
|
set_up_expressions = ["int $i = 9", "int $j = 3", "int $k = 5",
|
|
"unsigned long long $ull = -1", "unsigned $u = -1"]
|
|
|
|
expressions = ["$i + $j",
|
|
"$i - $j",
|
|
"$i * $j",
|
|
"$i / $j",
|
|
"$i % $k",
|
|
"$i << $j",
|
|
"$i & $j",
|
|
"$i | $j",
|
|
"$i ^ $j",
|
|
"($ull & -1) == $u"]
|
|
|
|
for expression in set_up_expressions:
|
|
self.frame().EvaluateExpression(expression, options)
|
|
|
|
for expression in expressions:
|
|
interp_expression = expression
|
|
jit_expression = "(int)getpid(); " + expression
|
|
|
|
interp_result = self.frame().EvaluateExpression(
|
|
interp_expression, options).GetValueAsSigned()
|
|
jit_result = self.frame().EvaluateExpression(
|
|
jit_expression, options).GetValueAsSigned()
|
|
|
|
self.assertEqual(
|
|
interp_result,
|
|
jit_result,
|
|
"While evaluating " +
|
|
expression)
|
|
|
|
def test_type_conversions(self):
|
|
target = self.dbg.GetDummyTarget()
|
|
short_val = target.EvaluateExpression("(short)-1")
|
|
self.assertEqual(short_val.GetValueAsSigned(), -1)
|
|
long_val = target.EvaluateExpression("(long) "+ short_val.GetName())
|
|
self.assertEqual(long_val.GetValueAsSigned(), -1)
|