When parsing DWARF and laying out bit-fields we currently don't take into account whether we have a base class or not. Currently if the first field is a bit-field but the bit offset is due a field we inherit from a base class we currently treat it as an unnamed bit-field and therefore add an extra field. This fix will not check if we have a base class and assume that this offset is due to members we are inheriting from the base. We are currently seeing asserts during codegen when debugging clang::DiagnosticOptions. This assumption will fail in the case where the first field in the derived class in an unnamed bit-field. Fixing the first field being an unnamed bit-field looks like it will require a larger change since we will need a way to track or discover the last field offset of the bases(s). Differential Revision: https://reviews.llvm.org/D76808
94 lines
1.5 KiB
C++
94 lines
1.5 KiB
C++
#include <stdint.h>
|
|
|
|
int main(int argc, char const *argv[]) {
|
|
struct LargeBitsA {
|
|
unsigned int : 30, a : 20;
|
|
} lba;
|
|
|
|
struct LargeBitsB {
|
|
unsigned int a : 1, : 11, : 12, b : 20;
|
|
} lbb;
|
|
|
|
struct LargeBitsC {
|
|
unsigned int : 13, : 9, a : 1, b : 1, c : 5, d : 1, e : 20;
|
|
} lbc;
|
|
|
|
struct LargeBitsD {
|
|
char arr[3];
|
|
unsigned int : 30, a : 20;
|
|
} lbd;
|
|
|
|
// This case came up when debugging clang and models RecordDeclBits
|
|
struct BitExampleFromClangDeclContext {
|
|
class fields {
|
|
uint64_t : 13;
|
|
uint64_t : 9;
|
|
|
|
uint64_t a: 1;
|
|
uint64_t b: 1;
|
|
uint64_t c: 1;
|
|
uint64_t d: 1;
|
|
uint64_t e: 1;
|
|
uint64_t f: 1;
|
|
uint64_t g: 1;
|
|
uint64_t h: 1;
|
|
uint64_t i: 1;
|
|
uint64_t j: 1;
|
|
uint64_t k: 1;
|
|
|
|
// In order to reproduce the crash for this case we need the
|
|
// members of fields to stay private :-(
|
|
friend struct BitExampleFromClangDeclContext;
|
|
};
|
|
|
|
union {
|
|
struct fields f;
|
|
};
|
|
|
|
BitExampleFromClangDeclContext() {
|
|
f.a = 1;
|
|
f.b = 0;
|
|
f.c = 1;
|
|
f.d = 0;
|
|
f.e = 1;
|
|
f.f = 0;
|
|
f.g = 1;
|
|
f.h = 0;
|
|
f.i = 1;
|
|
f.j = 0;
|
|
f.k = 1;
|
|
}
|
|
} clang_example;
|
|
|
|
class B {
|
|
public:
|
|
uint32_t b_a;
|
|
};
|
|
|
|
class D : public B {
|
|
public:
|
|
uint32_t d_a : 1;
|
|
} derived;
|
|
|
|
lba.a = 2;
|
|
|
|
lbb.a = 1;
|
|
lbb.b = 3;
|
|
|
|
lbc.a = 1;
|
|
lbc.b = 0;
|
|
lbc.c = 4;
|
|
lbc.d = 1;
|
|
lbc.e = 20;
|
|
|
|
lbd.arr[0] = 'a';
|
|
lbd.arr[1] = 'b';
|
|
lbd.arr[2] = '\0';
|
|
lbd.a = 5;
|
|
|
|
derived.b_a = 2;
|
|
derived.d_a = 1;
|
|
|
|
return 0; // Set break point at this line.
|
|
}
|