127bf44385
This completes the implementation of P1091R3 and P1381R1. This patch allow the capture of structured bindings both for C++20+ and C++17, with extension/compat warning. In addition, capturing an anonymous union member, a bitfield, or a structured binding thereof now has a better diagnostic. We only support structured bindings - as opposed to other kinds of structured statements/blocks. We still emit an error for those. In addition, support for structured bindings capture is entirely disabled in OpenMP mode as this needs more investigation - a specific diagnostic indicate the feature is not yet supported there. Note that the rest of P1091R3 (static/thread_local structured bindings) was already implemented. at the request of @shafik, i can confirm the correct behavior of lldb wit this change. Fixes https://github.com/llvm/llvm-project/issues/54300 Fixes https://github.com/llvm/llvm-project/issues/54300 Fixes https://github.com/llvm/llvm-project/issues/52720 Reviewed By: aaron.ballman Differential Revision: https://reviews.llvm.org/D122768
108 lines
3.4 KiB
C++
108 lines
3.4 KiB
C++
//=======- UncountedLambdaCapturesChecker.cpp --------------------*- C++ -*-==//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "DiagOutputUtils.h"
|
|
#include "PtrTypesSemantics.h"
|
|
#include "clang/AST/CXXInheritance.h"
|
|
#include "clang/AST/RecursiveASTVisitor.h"
|
|
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
|
|
namespace {
|
|
class UncountedLambdaCapturesChecker
|
|
: public Checker<check::ASTDecl<TranslationUnitDecl>> {
|
|
private:
|
|
BugType Bug{this, "Lambda capture of uncounted variable",
|
|
"WebKit coding guidelines"};
|
|
mutable BugReporter *BR;
|
|
|
|
public:
|
|
void checkASTDecl(const TranslationUnitDecl *TUD, AnalysisManager &MGR,
|
|
BugReporter &BRArg) const {
|
|
BR = &BRArg;
|
|
|
|
// The calls to checkAST* from AnalysisConsumer don't
|
|
// visit template instantiations or lambda classes. We
|
|
// want to visit those, so we make our own RecursiveASTVisitor.
|
|
struct LocalVisitor : public RecursiveASTVisitor<LocalVisitor> {
|
|
const UncountedLambdaCapturesChecker *Checker;
|
|
explicit LocalVisitor(const UncountedLambdaCapturesChecker *Checker)
|
|
: Checker(Checker) {
|
|
assert(Checker);
|
|
}
|
|
|
|
bool shouldVisitTemplateInstantiations() const { return true; }
|
|
bool shouldVisitImplicitCode() const { return false; }
|
|
|
|
bool VisitLambdaExpr(LambdaExpr *L) {
|
|
Checker->visitLambdaExpr(L);
|
|
return true;
|
|
}
|
|
};
|
|
|
|
LocalVisitor visitor(this);
|
|
visitor.TraverseDecl(const_cast<TranslationUnitDecl *>(TUD));
|
|
}
|
|
|
|
void visitLambdaExpr(LambdaExpr *L) const {
|
|
for (const LambdaCapture &C : L->captures()) {
|
|
if (C.capturesVariable()) {
|
|
ValueDecl *CapturedVar = C.getCapturedVar();
|
|
if (auto *CapturedVarType = CapturedVar->getType().getTypePtrOrNull()) {
|
|
Optional<bool> IsUncountedPtr = isUncountedPtr(CapturedVarType);
|
|
if (IsUncountedPtr && *IsUncountedPtr) {
|
|
reportBug(C, CapturedVar, CapturedVarType);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
void reportBug(const LambdaCapture &Capture, ValueDecl *CapturedVar,
|
|
const Type *T) const {
|
|
assert(CapturedVar);
|
|
|
|
SmallString<100> Buf;
|
|
llvm::raw_svector_ostream Os(Buf);
|
|
|
|
if (Capture.isExplicit()) {
|
|
Os << "Captured ";
|
|
} else {
|
|
Os << "Implicitly captured ";
|
|
}
|
|
if (T->isPointerType()) {
|
|
Os << "raw-pointer ";
|
|
} else {
|
|
assert(T->isReferenceType());
|
|
Os << "reference ";
|
|
}
|
|
|
|
printQuotedQualifiedName(Os, Capture.getCapturedVar());
|
|
Os << " to uncounted type is unsafe.";
|
|
|
|
PathDiagnosticLocation BSLoc(Capture.getLocation(), BR->getSourceManager());
|
|
auto Report = std::make_unique<BasicBugReport>(Bug, Os.str(), BSLoc);
|
|
BR->emitReport(std::move(Report));
|
|
}
|
|
};
|
|
} // namespace
|
|
|
|
void ento::registerUncountedLambdaCapturesChecker(CheckerManager &Mgr) {
|
|
Mgr.registerChecker<UncountedLambdaCapturesChecker>();
|
|
}
|
|
|
|
bool ento::shouldRegisterUncountedLambdaCapturesChecker(
|
|
const CheckerManager &mgr) {
|
|
return true;
|
|
}
|