e28a70daf4
We prioritize non-* wildcards overs VER_NDX_LOCAL/VER_NDX_GLOBAL "*".
This patch generalizes the rule to "*" of other versions and thus fixes PR40176.
I don't feel strongly about this GNU linkers' behavior but the
generalization simplifies code.
Delete `config->defaultSymbolVersion` which was used to special case
VER_NDX_LOCAL/VER_NDX_GLOBAL "*".
In `SymbolTable::scanVersionScript`, custom versions are handled the same
way as VER_NDX_LOCAL/VER_NDX_GLOBAL. So merge
`config->versionScript{Locals,Globals}` into `config->versionDefinitions`.
Overall this seems to simplify the code.
In `SymbolTable::assign{Exact,Wildcard}Versions`,
`sym->verdefIndex == config->defaultSymbolVersion` is changed to
`verdefIndex == UINT32_C(-1)`.
This allows us to give duplicate assignment diagnostics for
`{ global: foo; };` `V1 { global: foo; };`
In test/linkerscript/version-script.s:
vs_index of an undefined symbol changes from 0 to 1. This doesn't matter (arguably 1 is better because the binding is STB_GLOBAL) because vs_index of an undefined symbol is ignored.
Reviewed By: ruiu
Differential Revision: https://reviews.llvm.org/D65716
llvm-svn: 367869
20 lines
689 B
ArmAsm
20 lines
689 B
ArmAsm
# REQUIRES: x86
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t.o
|
|
|
|
# RUN: echo 'foo { foo*; }; bar { *; };' > %t.ver
|
|
# RUN: ld.lld --version-script %t.ver %t.o -shared -o %t.so --fatal-warnings
|
|
# RUN: llvm-readelf --dyn-syms %t.so | FileCheck --check-prefix=FOO %s
|
|
|
|
# RUN: echo 'foo { foo*; }; bar { f*; };' > %t.ver
|
|
# RUN: ld.lld --version-script %t.ver %t.o -shared -o %t.so --fatal-warnings
|
|
# RUN: llvm-readelf --dyn-syms %t.so | FileCheck --check-prefix=BAR %s
|
|
|
|
## If both a non-* glob and a * match, non-* wins.
|
|
## This is GNU linkers' behavior. We don't feel strongly this should be supported.
|
|
# FOO: GLOBAL DEFAULT 7 foo@@foo
|
|
|
|
# BAR: GLOBAL DEFAULT 7 foo@@bar
|
|
|
|
.globl foo
|
|
foo:
|