Remove the test override of `target.prefer-dynamic-value`. Previously, the lldb default was `no-dynamic-values`. In rG9aa7e8e9ffbe (in 2015), the default was changed to `no-run-target`, but at that time the tests were changed to be run with `no-dynamic-value`. I don't know the reasons for not changing the tests, perhaps to avoid determining which tests to change, and what about them to change. Because `no-run-target` is the lldb default, I think it makes sense to make it the test default too. It puts the test config closer to what's used in practice. This change removes the `target.prefer-dynamic-value` override, and for those tests that failed, they have been updated to explicitly use `no-dynamic-values`. Future changes could update these tests to use dynamic values too, or they can be left as is to exercise non-dynamic typing. Differential Revision: https://reviews.llvm.org/D132382
63 lines
2.0 KiB
Python
63 lines
2.0 KiB
Python
"""
|
|
Test that the po command acts correctly.
|
|
"""
|
|
|
|
|
|
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class PoVerbosityTestCase(TestBase):
|
|
|
|
def setUp(self):
|
|
# Call super's setUp().
|
|
TestBase.setUp(self)
|
|
# Find the line number to break for main.cpp.
|
|
self.line = line_number('main.m',
|
|
'// Stop here')
|
|
|
|
@add_test_categories(["objc"])
|
|
def test(self):
|
|
"""Test that the po command acts correctly."""
|
|
self.build()
|
|
|
|
# This is the function to remove the custom formats in order to have a
|
|
# clean slate for the next test case.
|
|
def cleanup():
|
|
self.runCmd('type summary clear', check=False)
|
|
self.runCmd('type synthetic clear', check=False)
|
|
|
|
# Execute the cleanup function during test case tear down.
|
|
self.addTearDownHook(cleanup)
|
|
|
|
"""Test expr + formatters for good interoperability."""
|
|
self.runCmd("file " + self.getBuildArtifact("a.out"), CURRENT_EXECUTABLE_SET)
|
|
|
|
lldbutil.run_break_set_by_file_and_line(
|
|
self, "main.m", self.line, loc_exact=True)
|
|
|
|
self.runCmd("run", RUN_SUCCEEDED)
|
|
|
|
self.runCmd("settings set target.prefer-dynamic-value no-dynamic-values")
|
|
|
|
self.expect("expr -O -v -- foo",
|
|
substrs=['(id) $', ' = 0x', '1 = 2', '2 = 3;'])
|
|
self.expect("expr -O -vfull -- foo",
|
|
substrs=['(id) $', ' = 0x', '1 = 2', '2 = 3;'])
|
|
self.expect("expr -O -- foo", matching=False,
|
|
substrs=['(id) $'])
|
|
|
|
self.expect("expr -O -- 22", matching=False,
|
|
substrs=['(int) $'])
|
|
self.expect("expr -O -- 22",
|
|
substrs=['22'])
|
|
|
|
self.expect("expr -O -vfull -- 22",
|
|
substrs=['(int) $', ' = 22'])
|
|
|
|
self.expect("expr -O -v -- 22",
|
|
substrs=['(int) $', ' = 22'])
|