c21dfa9e49
Remove the test override of `target.prefer-dynamic-value`. Previously, the lldb default was `no-dynamic-values`. In rG9aa7e8e9ffbe (in 2015), the default was changed to `no-run-target`, but at that time the tests were changed to be run with `no-dynamic-value`. I don't know the reasons for not changing the tests, perhaps to avoid determining which tests to change, and what about them to change. Because `no-run-target` is the lldb default, I think it makes sense to make it the test default too. It puts the test config closer to what's used in practice. This change removes the `target.prefer-dynamic-value` override, and for those tests that failed, they have been updated to explicitly use `no-dynamic-values`. Future changes could update these tests to use dynamic values too, or they can be left as is to exercise non-dynamic typing. Differential Revision: https://reviews.llvm.org/D132382
67 lines
2.2 KiB
Python
67 lines
2.2 KiB
Python
"""Test that types defined in shared libraries work correctly."""
|
|
|
|
|
|
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class TestRealDefinition(TestBase):
|
|
|
|
def test_frame_var_after_stop_at_interface(self):
|
|
"""Test that we can find the implementation for an objective C type"""
|
|
if self.getArchitecture() == 'i386':
|
|
self.skipTest("requires modern objc runtime")
|
|
self.build()
|
|
|
|
lldbutil.run_to_source_breakpoint(
|
|
self,
|
|
'// Set breakpoint where Bar is an interface',
|
|
lldb.SBFileSpec("Foo.m", False))
|
|
|
|
# Break inside the foo function which takes a bar_ptr argument.
|
|
self.expect('breakpoint set -p "// Set breakpoint in main"')
|
|
self.runCmd("continue", RUN_SUCCEEDED)
|
|
|
|
# Run at stop at main
|
|
lldbutil.check_breakpoint(self, bpno = 1, expected_hit_count = 1)
|
|
|
|
self.runCmd("settings set target.prefer-dynamic-value no-dynamic-values")
|
|
|
|
# This should display correctly.
|
|
self.expect(
|
|
"frame variable foo->_bar->_hidden_ivar",
|
|
VARIABLES_DISPLAYED_CORRECTLY,
|
|
substrs=[
|
|
"(NSString *)",
|
|
"foo->_bar->_hidden_ivar = 0x"])
|
|
|
|
def test_frame_var_after_stop_at_implementation(self):
|
|
"""Test that we can find the implementation for an objective C type"""
|
|
if self.getArchitecture() == 'i386':
|
|
self.skipTest("requires modern objc runtime")
|
|
self.build()
|
|
|
|
lldbutil.run_to_source_breakpoint(
|
|
self,
|
|
'// Set breakpoint where Bar is an implementation',
|
|
lldb.SBFileSpec("Bar.m", False))
|
|
|
|
self.expect('breakpoint set -p "// Set breakpoint in main"')
|
|
self.runCmd("continue", RUN_SUCCEEDED)
|
|
|
|
# Run at stop at main
|
|
lldbutil.check_breakpoint(self, bpno = 1, expected_hit_count = 1)
|
|
|
|
self.runCmd("settings set target.prefer-dynamic-value no-dynamic-values")
|
|
|
|
# This should display correctly.
|
|
self.expect(
|
|
"frame variable foo->_bar->_hidden_ivar",
|
|
VARIABLES_DISPLAYED_CORRECTLY,
|
|
substrs=[
|
|
"(NSString *)",
|
|
"foo->_bar->_hidden_ivar = 0x"])
|