Files
clang-p2996/llvm/lib/ExecutionEngine/JITLink/COFFDirectiveParser.cpp
serge-sans-paille d9ab3e82f3 [clang] Use a StringRef instead of a raw char pointer to store builtin and call information
This avoids recomputing string length that is already known at compile time.

It has a slight impact on preprocessing / compile time, see

https://llvm-compile-time-tracker.com/compare.php?from=3f36d2d579d8b0e8824d9dd99bfa79f456858f88&to=e49640c507ddc6615b5e503144301c8e41f8f434&stat=instructions:u

This a recommit of e953ae5bbc and the subsequent fixes caa713559b and 06b90e2e9c.

The above patchset caused some version of GCC to take eons to compile clang/lib/Basic/Targets/AArch64.cpp, as spotted in aa171833ab.
The fix is to make BuiltinInfo tables a compilation unit static variable, instead of a private static variable.

Differential Revision: https://reviews.llvm.org/D139881
2022-12-27 09:55:19 +01:00

81 lines
3.2 KiB
C++

//===-- COFFDirectiveParser.cpp - JITLink coff directive parser --*- C++ -*===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//
// MSVC COFF directive parser
//
//===----------------------------------------------------------------------===//
#include "COFFDirectiveParser.h"
#include <array>
using namespace llvm;
using namespace jitlink;
#define DEBUG_TYPE "jitlink"
// Create prefix string literals used in Options.td
#define PREFIX(NAME, VALUE) \
static constexpr StringLiteral NAME##_init[] = VALUE; \
static constexpr ArrayRef<StringLiteral> NAME(NAME##_init, \
std::size(NAME##_init) - 1);
#include "COFFOptions.inc"
#undef PREFIX
// Create table mapping all options defined in COFFOptions.td
static constexpr opt::OptTable::Info infoTable[] = {
#define OPTION(X1, X2, ID, KIND, GROUP, ALIAS, X7, X8, X9, X10, X11, X12) \
{X1, \
X2, \
X10, \
X11, \
COFF_OPT_##ID, \
opt::Option::KIND##Class, \
X9, \
X8, \
COFF_OPT_##GROUP, \
COFF_OPT_##ALIAS, \
X7, \
X12},
#include "COFFOptions.inc"
#undef OPTION
};
class COFFOptTable : public opt::OptTable {
public:
COFFOptTable() : OptTable(infoTable, true) {}
};
static COFFOptTable optTable;
Expected<opt::InputArgList> COFFDirectiveParser::parse(StringRef Str) {
SmallVector<StringRef, 16> Tokens;
SmallVector<const char *, 16> Buffer;
cl::TokenizeWindowsCommandLineNoCopy(Str, saver, Tokens);
for (StringRef Tok : Tokens) {
bool HasNul = Tok.end() != Str.end() && Tok.data()[Tok.size()] == '\0';
Buffer.push_back(HasNul ? Tok.data() : saver.save(Tok).data());
}
unsigned missingIndex;
unsigned missingCount;
auto Result = optTable.ParseArgs(Buffer, missingIndex, missingCount);
if (missingCount)
return make_error<JITLinkError>(Twine("COFF directive parsing failed: ") +
Result.getArgString(missingIndex) +
" missing argument");
LLVM_DEBUG({
for (auto *arg : Result.filtered(COFF_OPT_UNKNOWN))
dbgs() << "Unknown coff option argument: " << arg->getAsString(Result)
<< "\n";
});
return std::move(Result);
}