d29f93bda5
Fixes a bug introduced by D91589.
When folding `(sext (not i1 x)) -> (add (zext i1 x), -1)`, we try to replace the not first when possible. If we replace the not in-visit, then the now invalidated node will be returned, and subsequently we will return an invalid sext. In cases where the not is replaced in-visit we can simply return SDValue, as the not in the current sext should have already been replaced.
Thanks @jgorbe, for finding the below reproducer.
The following reduced test case crashes clang when built with `clang -O1 -frounding-math`:
```
template <class> class a {
int b() { return c == 0.0 ? 0 : -1; }
int c;
};
template class a<long>;
```
A debug build of clang produces this "assertion failed" error:
```
clang: /home/jgorbe/code/llvm/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:264: void {anonymous}::DAGCombiner::AddToWorklist(llvm::
SDNode*): Assertion `N->getOpcode() != ISD::DELETED_NODE && "Deleted Node added to Worklist"' failed.
```
Reviewed By: spatel
Differential Revision: https://reviews.llvm.org/D93274
65 lines
1.9 KiB
LLVM
65 lines
1.9 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
|
|
; RUN: llc < %s -mtriple=s390x-linux-gnu | FileCheck %s
|
|
|
|
;; fold (sext (not x)) -> (add (zext x) -1)
|
|
define i32 @sext_of_not(i1 %x) {
|
|
; CHECK-LABEL: sext_of_not:
|
|
; CHECK: # %bb.0:
|
|
; CHECK-NEXT: nilf %r2, 1
|
|
; CHECK-NEXT: ahi %r2, -1
|
|
; CHECK-NEXT: br %r14
|
|
%xor = xor i1 %x, 1
|
|
%sext = sext i1 %xor to i32
|
|
ret i32 %sext
|
|
}
|
|
|
|
;; fold (sext (not (setcc a, b, cc))) -> (sext (setcc a, b, !cc))
|
|
define i32 @sext_of_not_cmp(i32 %x) {
|
|
; CHECK-LABEL: sext_of_not_cmp:
|
|
; CHECK: # %bb.0:
|
|
; CHECK-NEXT: chi %r2, 7
|
|
; CHECK-NEXT: ipm %r2
|
|
; CHECK-NEXT: afi %r2, 1879048192
|
|
; CHECK-NEXT: sra %r2, 31
|
|
; CHECK-NEXT: br %r14
|
|
%cmp = icmp eq i32 %x, 7
|
|
%xor = xor i1 %cmp, 1
|
|
%sext = sext i1 %xor to i32
|
|
ret i32 %sext
|
|
}
|
|
|
|
;; fold (sext (not (setcc a, b, cc))) -> (sext (setcc a, b, !cc))
|
|
;; make sure we don't crash if the not gets replaced in-visit
|
|
define i32 @sext_of_not_fsetccs(double %x) {
|
|
; CHECK-LABEL: sext_of_not_fsetccs:
|
|
; CHECK: # %bb.0:
|
|
; CHECK-NEXT: ltdbr %f0, %f0
|
|
; CHECK-NEXT: ipm %r0
|
|
; CHECK-NEXT: afi %r0, 1879048192
|
|
; CHECK-NEXT: srl %r0, 31
|
|
; CHECK-NEXT: lcr %r2, %r0
|
|
; CHECK-NEXT: br %r14
|
|
%cmp = call i1 @llvm.experimental.constrained.fcmp.f64(double %x, double 0.000000e+00, metadata !"oeq", metadata !"fpexcept.ignore")
|
|
%xor = xor i1 %cmp, 1
|
|
%sext = sext i1 %xor to i32
|
|
ret i32 %sext
|
|
}
|
|
|
|
declare i1 @llvm.experimental.constrained.fcmp.f64(double, double, metadata, metadata)
|
|
|
|
;; TODO: fold (add (zext (setcc a, b, cc)), -1) -> (sext (setcc a, b, !cc))
|
|
define i32 @dec_of_zexted_cmp(i32 %x) {
|
|
; CHECK-LABEL: dec_of_zexted_cmp:
|
|
; CHECK: # %bb.0:
|
|
; CHECK-NEXT: chi %r2, 7
|
|
; CHECK-NEXT: ipm %r2
|
|
; CHECK-NEXT: afi %r2, -268435456
|
|
; CHECK-NEXT: srl %r2, 31
|
|
; CHECK-NEXT: ahi %r2, -1
|
|
; CHECK-NEXT: br %r14
|
|
%cmp = icmp eq i32 %x, 7
|
|
%zext = zext i1 %cmp to i32
|
|
%dec = sub i32 %zext, 1
|
|
ret i32 %dec
|
|
}
|