5e50dd048e
This commit restructures how TypeID is implemented to ideally avoid the current problems related to shared libraries. This is done by changing the "implicit" fallback path to use the name of the type, instead of using a static template variable (which breaks shared libraries). The major downside to this is that it adds some additional initialization costs for the implicit path. Given the use of type names for uniqueness in the fallback, we also no longer allow types defined in anonymous namespaces to have an implicit TypeID. To simplify defining an ID for these classes, a new `MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID` macro was added to allow for explicitly defining a TypeID directly on an internal class. To help identify when types are using the fallback, `-debug-only=typeid` can be used to log which types are using implicit ids. This change generally only requires changes to the test passes, which are all defined in anonymous namespaces, and thus can't use the fallback any longer. Differential Revision: https://reviews.llvm.org/D122775
70 lines
2.3 KiB
C++
70 lines
2.3 KiB
C++
//===- TestConstantFold.cpp - Pass to test constant folding ---------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/Pass/Pass.h"
|
|
#include "mlir/Transforms/FoldUtils.h"
|
|
|
|
using namespace mlir;
|
|
|
|
namespace {
|
|
/// Simple constant folding pass.
|
|
struct TestConstantFold
|
|
: public PassWrapper<TestConstantFold, OperationPass<>> {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestConstantFold)
|
|
|
|
StringRef getArgument() const final { return "test-constant-fold"; }
|
|
StringRef getDescription() const final {
|
|
return "Test operation constant folding";
|
|
}
|
|
// All constants in the operation post folding.
|
|
SmallVector<Operation *> existingConstants;
|
|
|
|
void foldOperation(Operation *op, OperationFolder &helper);
|
|
void runOnOperation() override;
|
|
};
|
|
} // namespace
|
|
|
|
void TestConstantFold::foldOperation(Operation *op, OperationFolder &helper) {
|
|
auto processGeneratedConstants = [this](Operation *op) {
|
|
existingConstants.push_back(op);
|
|
};
|
|
|
|
// Attempt to fold the specified operation, including handling unused or
|
|
// duplicated constants.
|
|
(void)helper.tryToFold(op, processGeneratedConstants);
|
|
}
|
|
|
|
void TestConstantFold::runOnOperation() {
|
|
existingConstants.clear();
|
|
|
|
// Collect and fold the operations within the operation.
|
|
SmallVector<Operation *, 8> ops;
|
|
getOperation()->walk([&](Operation *op) { ops.push_back(op); });
|
|
|
|
// Fold the constants in reverse so that the last generated constants from
|
|
// folding are at the beginning. This creates somewhat of a linear ordering to
|
|
// the newly generated constants that matches the operation order and improves
|
|
// the readability of test cases.
|
|
OperationFolder helper(&getContext());
|
|
for (Operation *op : llvm::reverse(ops))
|
|
foldOperation(op, helper);
|
|
|
|
// By the time we are done, we may have simplified a bunch of code, leaving
|
|
// around dead constants. Check for them now and remove them.
|
|
for (auto *cst : existingConstants) {
|
|
if (cst->use_empty())
|
|
cst->erase();
|
|
}
|
|
}
|
|
|
|
namespace mlir {
|
|
namespace test {
|
|
void registerTestConstantFold() { PassRegistration<TestConstantFold>(); }
|
|
} // namespace test
|
|
} // namespace mlir
|