3d334df587
std::format is currently experimental, so there is technically no deployment target requirement for it (since the only symbols required for it are in `libc++experimental.a`). However, some parts of std::format depend indirectly on the floating point std::to_chars implementation, which does have deployment target requirements. This patch removes all the availability format for std::format and updates the XFAILs in the tests to properly explain why they fail on old deployment targets, when they do. It also changes a couple of tests to avoid depending on floating-point std::to_chars when it isn't fundamental to the test. Finally, some tests are marked as XFAIL but I added a comment saying TODO FMT This test should not require std::to_chars(floating-point) These tests do not fundamentally depend on floating-point std::to_chars, however they end up failing because calling std::format even without a floating-point argument to format will end up requiring floating-point std::to_chars. I believe this is an implementation artifact that could be avoided in all cases where we know the format string at compile-time. In the tests, I added the TODO comment only to the places where we could do better and actually avoid relying on floating-point std::to_chars because we know the format string at compile-time. Differential Revision: https://reviews.llvm.org/D134598
83 lines
2.5 KiB
C++
83 lines
2.5 KiB
C++
// -*- C++ -*-
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef _LIBCPP___FORMAT_FORMAT_ARGS_H
|
|
#define _LIBCPP___FORMAT_FORMAT_ARGS_H
|
|
|
|
#include <__availability>
|
|
#include <__config>
|
|
#include <__format/format_arg.h>
|
|
#include <__format/format_arg_store.h>
|
|
#include <__format/format_fwd.h>
|
|
#include <cstddef>
|
|
#include <cstdint>
|
|
|
|
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
|
|
# pragma GCC system_header
|
|
#endif
|
|
|
|
_LIBCPP_BEGIN_NAMESPACE_STD
|
|
|
|
#if _LIBCPP_STD_VER >= 20
|
|
|
|
template <class _Context>
|
|
class _LIBCPP_TEMPLATE_VIS basic_format_args {
|
|
public:
|
|
_LIBCPP_HIDE_FROM_ABI basic_format_args() noexcept = default;
|
|
|
|
template <class... _Args>
|
|
_LIBCPP_HIDE_FROM_ABI basic_format_args(const __format_arg_store<_Context, _Args...>& __store) noexcept
|
|
: __size_(sizeof...(_Args)) {
|
|
if constexpr (sizeof...(_Args) != 0) {
|
|
if constexpr (__format::__use_packed_format_arg_store(sizeof...(_Args))) {
|
|
__values_ = __store.__storage.__values_;
|
|
__types_ = __store.__storage.__types_;
|
|
} else
|
|
__args_ = __store.__storage.__args_;
|
|
}
|
|
}
|
|
|
|
_LIBCPP_HIDE_FROM_ABI
|
|
basic_format_arg<_Context> get(size_t __id) const noexcept {
|
|
if (__id >= __size_)
|
|
return basic_format_arg<_Context>{};
|
|
|
|
if (__format::__use_packed_format_arg_store(__size_))
|
|
return basic_format_arg<_Context>{__format::__get_packed_type(__types_, __id), __values_[__id]};
|
|
|
|
return __args_[__id];
|
|
}
|
|
|
|
_LIBCPP_HIDE_FROM_ABI size_t __size() const noexcept { return __size_; }
|
|
|
|
private:
|
|
size_t __size_{0};
|
|
// [format.args]/5
|
|
// [Note 1: Implementations are encouraged to optimize the representation of
|
|
// basic_format_args for small number of formatting arguments by storing
|
|
// indices of type alternatives separately from values and packing the
|
|
// former. - end note]
|
|
union {
|
|
struct {
|
|
const __basic_format_arg_value<_Context>* __values_;
|
|
uint64_t __types_;
|
|
};
|
|
const basic_format_arg<_Context>* __args_;
|
|
};
|
|
};
|
|
|
|
template <class _Context, class... _Args>
|
|
basic_format_args(__format_arg_store<_Context, _Args...>) -> basic_format_args<_Context>;
|
|
|
|
#endif //_LIBCPP_STD_VER >= 20
|
|
|
|
_LIBCPP_END_NAMESPACE_STD
|
|
|
|
#endif // _LIBCPP___FORMAT_FORMAT_ARGS_H
|