c11051a400
I had initially assumed this was the problem with https://github.com/llvm/llvm-project/issues/55271#issuecomment-1133426243 But it turns out that was a simpler issue. This patch is still more correct than what we were doing before so figured I'd submit it anyway. No test case because I'm not sure how to get an undef around until expansion. Looking at the test deltas I wonder if it be valid to combine (sext_inreg (freeze (aextload X))) -> (freeze (sextload X)). Reviewed By: efriedma Differential Revision: https://reviews.llvm.org/D126175
170 lines
4.8 KiB
LLVM
170 lines
4.8 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
|
|
; RUN: llc < %s -mtriple=i686-unknown-unknown | FileCheck %s --check-prefix=X86 --check-prefix=X86-NO-CMOV
|
|
; RUN: llc < %s -mtriple=i686-unknown-unknown -mattr=+cmov | FileCheck %s --check-prefix=X86 --check-prefix=X86-CMOV
|
|
; RUN: llc < %s -mtriple=x86_64-unknown-unknown | FileCheck %s --check-prefix=X64
|
|
|
|
;; Integer absolute value, should produce something at least as good as:
|
|
;; movl %edi, %eax
|
|
;; negl %eax
|
|
;; cmovll %edi, %eax
|
|
;; ret
|
|
; rdar://10695237
|
|
define i8 @test_i8(i8 %a) nounwind {
|
|
; X86-LABEL: test_i8:
|
|
; X86: # %bb.0:
|
|
; X86-NEXT: movb {{[0-9]+}}(%esp), %al
|
|
; X86-NEXT: movl %eax, %ecx
|
|
; X86-NEXT: sarb $7, %cl
|
|
; X86-NEXT: xorb %cl, %al
|
|
; X86-NEXT: subb %cl, %al
|
|
; X86-NEXT: retl
|
|
;
|
|
; X64-LABEL: test_i8:
|
|
; X64: # %bb.0:
|
|
; X64-NEXT: movl %edi, %eax
|
|
; X64-NEXT: movl %eax, %ecx
|
|
; X64-NEXT: sarb $7, %cl
|
|
; X64-NEXT: xorb %cl, %al
|
|
; X64-NEXT: subb %cl, %al
|
|
; X64-NEXT: # kill: def $al killed $al killed $eax
|
|
; X64-NEXT: retq
|
|
%tmp1neg = sub i8 0, %a
|
|
%b = icmp sgt i8 %a, -1
|
|
%abs = select i1 %b, i8 %a, i8 %tmp1neg
|
|
ret i8 %abs
|
|
}
|
|
|
|
define i16 @test_i16(i16 %a) nounwind {
|
|
; X86-NO-CMOV-LABEL: test_i16:
|
|
; X86-NO-CMOV: # %bb.0:
|
|
; X86-NO-CMOV-NEXT: movzwl {{[0-9]+}}(%esp), %eax
|
|
; X86-NO-CMOV-NEXT: movswl %ax, %ecx
|
|
; X86-NO-CMOV-NEXT: sarl $15, %ecx
|
|
; X86-NO-CMOV-NEXT: xorl %ecx, %eax
|
|
; X86-NO-CMOV-NEXT: subl %ecx, %eax
|
|
; X86-NO-CMOV-NEXT: # kill: def $ax killed $ax killed $eax
|
|
; X86-NO-CMOV-NEXT: retl
|
|
;
|
|
; X86-CMOV-LABEL: test_i16:
|
|
; X86-CMOV: # %bb.0:
|
|
; X86-CMOV-NEXT: movzwl {{[0-9]+}}(%esp), %ecx
|
|
; X86-CMOV-NEXT: movl %ecx, %eax
|
|
; X86-CMOV-NEXT: negw %ax
|
|
; X86-CMOV-NEXT: cmovsw %cx, %ax
|
|
; X86-CMOV-NEXT: retl
|
|
;
|
|
; X64-LABEL: test_i16:
|
|
; X64: # %bb.0:
|
|
; X64-NEXT: movl %edi, %eax
|
|
; X64-NEXT: negw %ax
|
|
; X64-NEXT: cmovsw %di, %ax
|
|
; X64-NEXT: retq
|
|
%tmp1neg = sub i16 0, %a
|
|
%b = icmp sgt i16 %a, -1
|
|
%abs = select i1 %b, i16 %a, i16 %tmp1neg
|
|
ret i16 %abs
|
|
}
|
|
|
|
define i32 @test_i32(i32 %a) nounwind {
|
|
; X86-NO-CMOV-LABEL: test_i32:
|
|
; X86-NO-CMOV: # %bb.0:
|
|
; X86-NO-CMOV-NEXT: movl {{[0-9]+}}(%esp), %eax
|
|
; X86-NO-CMOV-NEXT: movl %eax, %ecx
|
|
; X86-NO-CMOV-NEXT: sarl $31, %ecx
|
|
; X86-NO-CMOV-NEXT: xorl %ecx, %eax
|
|
; X86-NO-CMOV-NEXT: subl %ecx, %eax
|
|
; X86-NO-CMOV-NEXT: retl
|
|
;
|
|
; X86-CMOV-LABEL: test_i32:
|
|
; X86-CMOV: # %bb.0:
|
|
; X86-CMOV-NEXT: movl {{[0-9]+}}(%esp), %ecx
|
|
; X86-CMOV-NEXT: movl %ecx, %eax
|
|
; X86-CMOV-NEXT: negl %eax
|
|
; X86-CMOV-NEXT: cmovsl %ecx, %eax
|
|
; X86-CMOV-NEXT: retl
|
|
;
|
|
; X64-LABEL: test_i32:
|
|
; X64: # %bb.0:
|
|
; X64-NEXT: movl %edi, %eax
|
|
; X64-NEXT: negl %eax
|
|
; X64-NEXT: cmovsl %edi, %eax
|
|
; X64-NEXT: retq
|
|
%tmp1neg = sub i32 0, %a
|
|
%b = icmp sgt i32 %a, -1
|
|
%abs = select i1 %b, i32 %a, i32 %tmp1neg
|
|
ret i32 %abs
|
|
}
|
|
|
|
define i64 @test_i64(i64 %a) nounwind {
|
|
; X86-LABEL: test_i64:
|
|
; X86: # %bb.0:
|
|
; X86-NEXT: movl {{[0-9]+}}(%esp), %edx
|
|
; X86-NEXT: movl %edx, %ecx
|
|
; X86-NEXT: sarl $31, %ecx
|
|
; X86-NEXT: xorl %ecx, %edx
|
|
; X86-NEXT: movl {{[0-9]+}}(%esp), %eax
|
|
; X86-NEXT: xorl %ecx, %eax
|
|
; X86-NEXT: subl %ecx, %eax
|
|
; X86-NEXT: sbbl %ecx, %edx
|
|
; X86-NEXT: retl
|
|
;
|
|
; X64-LABEL: test_i64:
|
|
; X64: # %bb.0:
|
|
; X64-NEXT: movq %rdi, %rax
|
|
; X64-NEXT: negq %rax
|
|
; X64-NEXT: cmovsq %rdi, %rax
|
|
; X64-NEXT: retq
|
|
%tmp1neg = sub i64 0, %a
|
|
%b = icmp sgt i64 %a, -1
|
|
%abs = select i1 %b, i64 %a, i64 %tmp1neg
|
|
ret i64 %abs
|
|
}
|
|
|
|
define i128 @test_i128(i128 %a) nounwind {
|
|
; X86-LABEL: test_i128:
|
|
; X86: # %bb.0:
|
|
; X86-NEXT: pushl %ebx
|
|
; X86-NEXT: pushl %edi
|
|
; X86-NEXT: pushl %esi
|
|
; X86-NEXT: movl {{[0-9]+}}(%esp), %eax
|
|
; X86-NEXT: movl {{[0-9]+}}(%esp), %ecx
|
|
; X86-NEXT: movl %ecx, %edx
|
|
; X86-NEXT: sarl $31, %edx
|
|
; X86-NEXT: xorl %edx, %ecx
|
|
; X86-NEXT: movl {{[0-9]+}}(%esp), %esi
|
|
; X86-NEXT: xorl %edx, %esi
|
|
; X86-NEXT: movl {{[0-9]+}}(%esp), %edi
|
|
; X86-NEXT: xorl %edx, %edi
|
|
; X86-NEXT: movl {{[0-9]+}}(%esp), %ebx
|
|
; X86-NEXT: xorl %edx, %ebx
|
|
; X86-NEXT: subl %edx, %ebx
|
|
; X86-NEXT: sbbl %edx, %edi
|
|
; X86-NEXT: sbbl %edx, %esi
|
|
; X86-NEXT: sbbl %edx, %ecx
|
|
; X86-NEXT: movl %ebx, (%eax)
|
|
; X86-NEXT: movl %edi, 4(%eax)
|
|
; X86-NEXT: movl %esi, 8(%eax)
|
|
; X86-NEXT: movl %ecx, 12(%eax)
|
|
; X86-NEXT: popl %esi
|
|
; X86-NEXT: popl %edi
|
|
; X86-NEXT: popl %ebx
|
|
; X86-NEXT: retl $4
|
|
;
|
|
; X64-LABEL: test_i128:
|
|
; X64: # %bb.0:
|
|
; X64-NEXT: movq %rsi, %rdx
|
|
; X64-NEXT: movq %rdi, %rax
|
|
; X64-NEXT: movq %rsi, %rcx
|
|
; X64-NEXT: sarq $63, %rcx
|
|
; X64-NEXT: xorq %rcx, %rdx
|
|
; X64-NEXT: xorq %rcx, %rax
|
|
; X64-NEXT: subq %rcx, %rax
|
|
; X64-NEXT: sbbq %rcx, %rdx
|
|
; X64-NEXT: retq
|
|
%tmp1neg = sub i128 0, %a
|
|
%b = icmp sgt i128 %a, -1
|
|
%abs = select i1 %b, i128 %a, i128 %tmp1neg
|
|
ret i128 %abs
|
|
}
|
|
|