Don't count register uses when determining the maximum number of registers used by a function. Count only the defs. This is really an underestimate of the true register usage, but in practice that's not a problem because if a function uses a register, then it has either defined it earlier, or some other function that executed before has defined it. In particular, the register counts are used: 1. When launching an entry function - in which case we're safe because the register counts of the entry function will include the register counts of all callees. 2. At function boundaries in dynamic VGPR mode. In this case it's safe because whenever we set the new VGPR allocation we take into account the outgoing_vgpr_count set by the middle-end. The main advantage of doing this is that the artificial VGPR arguments used only for preserving the inactive lanes when using the llvm.amdgcn.init.whole.wave intrinsic are no longer counted. This enables us to allocate only the registers we need in dynamic VGPR mode. --------- Co-authored-by: Thomas Symalla <5754458+tsymalla@users.noreply.github.com>
52 lines
1.8 KiB
LLVM
52 lines
1.8 KiB
LLVM
; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx908 < %s | FileCheck -check-prefixes=CHECK,GFX908 %s
|
|
; RUN: not llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx90a < %s 2> %t.err | FileCheck -check-prefixes=CHECK,GFX90A %s
|
|
; RUN: FileCheck --implicit-check-not=error -check-prefix=ERR < %t.err %s
|
|
|
|
; Test undefined behavior where a function ends up needing AGPRs that
|
|
; was marked with "amdgpu-agpr-alloc="="0". There should be no asserts.
|
|
|
|
; TODO: Should this be an error, or let UB happen?
|
|
|
|
; ERR: error: <unknown>:0:0: no registers from class available to allocate in function 'kernel_illegal_agpr_use_asm'
|
|
; ERR: error: <unknown>:0:0: no registers from class available to allocate in function 'func_illegal_agpr_use_asm'
|
|
|
|
; CHECK: {{^}}kernel_illegal_agpr_use_asm:
|
|
; CHECK: ; use a0
|
|
|
|
; GFX908: NumVgprs: 3
|
|
; GFX90A: NumVgprs: 1
|
|
; CHECK: NumAgprs: 0
|
|
define amdgpu_kernel void @kernel_illegal_agpr_use_asm() #0 {
|
|
call void asm sideeffect "; use $0", "a"(i32 poison)
|
|
ret void
|
|
}
|
|
|
|
; CHECK: {{^}}func_illegal_agpr_use_asm:
|
|
; CHECK: ; use a0
|
|
|
|
; CHECK: NumVgprs: 0
|
|
; CHECK: NumAgprs: 0
|
|
define void @func_illegal_agpr_use_asm() #0 {
|
|
call void asm sideeffect "; use $0", "a"(i32 poison)
|
|
ret void
|
|
}
|
|
|
|
; CHECK-LABEL: {{^}}kernel_calls_mfma.f32.32x32x1f32:
|
|
; GFX908: v_accvgpr_write_b32
|
|
; GFX90A-NOT: v_accvgpr_write_b32
|
|
|
|
; GFX908: NumVgprs: 5
|
|
; GFX908: NumAgprs: 32
|
|
; GFX90A: NumVgprs: 35
|
|
; GFX90A: NumAgprs: 0
|
|
|
|
; GFX908: TotalNumVgprs: 32
|
|
; GFX90A: TotalNumVgprs: 35
|
|
define amdgpu_kernel void @kernel_calls_mfma.f32.32x32x1f32(ptr addrspace(1) %out, float %a, float %b, <32 x float> %c) #0 {
|
|
%result = call <32 x float> @llvm.amdgcn.mfma.f32.32x32x1f32(float %a, float %b, <32 x float> %c, i32 0, i32 0, i32 0)
|
|
store <32 x float> %result, ptr addrspace(1) %out
|
|
ret void
|
|
}
|
|
|
|
attributes #0 = { "amdgpu-agpr-alloc"="0" }
|