141d390dcb
The parser will accept a wide variety of illegal attempts at forming an ATOMIC construct, leaving it to the semantic analysis to diagnose any issues. This consolidates the analysis into one place and allows us to produce more informative diagnostics. The parser's outcome will be parser::OpenMPAtomicConstruct object holding the directive, parser::Body, and an optional end-directive. The prior variety of OmpAtomicXyz classes, as well as OmpAtomicClause have been removed. READ, WRITE, etc. are now proper clauses. The semantic analysis consistently operates on "evaluation" representations, mainly evaluate::Expr (as SomeExpr) and evaluate::Assignment. The results of the semantic analysis are stored in a mutable member of the OpenMPAtomicConstruct node. This follows a precedent of having `typedExpr` member in parser::Expr, for example. This allows the lowering code to avoid duplicated handling of AST nodes. Using a BLOCK construct containing multiple statements for an ATOMIC construct that requires multiple statements is now allowed. In fact, any nesting of such BLOCK constructs is allowed. This implementation will parse, and perform semantic checks for both conditional-update and conditional-update-capture, although no MLIR will be generated for those. Instead, a TODO error will be issues prior to lowering. The allowed forms of the ATOMIC construct were based on the OpenMP 6.0 spec.
346 lines
12 KiB
Fortran
346 lines
12 KiB
Fortran
! REQUIRES: openmp_runtime
|
|
|
|
! RUN: %python %S/../test_errors.py %s %flang_fc1 %openmp_flags -fopenmp-version=50
|
|
! Semantic checks for OpenMP 5.0 standard 2.17.7 atomic Construct.
|
|
|
|
use omp_lib
|
|
implicit none
|
|
integer :: i, j = 10, k=-100, a
|
|
! 2.17.7.1
|
|
! Handled inside parser.
|
|
! OpenMP constructs may not be encountered during execution of an atomic region
|
|
|
|
! 2.17.7.2
|
|
! At most one memory-order-clause may appear on the construct.
|
|
|
|
!READ
|
|
!ERROR: At most one SEQ_CST clause can appear on the ATOMIC directive
|
|
!$omp atomic seq_cst seq_cst read
|
|
i = j
|
|
!ERROR: At most one SEQ_CST clause can appear on the ATOMIC directive
|
|
!$omp atomic read seq_cst seq_cst
|
|
i = j
|
|
!ERROR: At most one SEQ_CST clause can appear on the ATOMIC directive
|
|
!$omp atomic seq_cst read seq_cst
|
|
i = j
|
|
|
|
!ERROR: At most one ACQUIRE clause can appear on the ATOMIC directive
|
|
!$omp atomic acquire acquire read
|
|
i = j
|
|
!ERROR: At most one ACQUIRE clause can appear on the ATOMIC directive
|
|
!$omp atomic read acquire acquire
|
|
i = j
|
|
!ERROR: At most one ACQUIRE clause can appear on the ATOMIC directive
|
|
!$omp atomic acquire read acquire
|
|
i = j
|
|
|
|
!ERROR: At most one RELAXED clause can appear on the ATOMIC directive
|
|
!$omp atomic relaxed relaxed read
|
|
i = j
|
|
!ERROR: At most one RELAXED clause can appear on the ATOMIC directive
|
|
!$omp atomic read relaxed relaxed
|
|
i = j
|
|
!ERROR: At most one RELAXED clause can appear on the ATOMIC directive
|
|
!$omp atomic relaxed read relaxed
|
|
i = j
|
|
|
|
!UPDATE
|
|
!ERROR: At most one SEQ_CST clause can appear on the ATOMIC directive
|
|
!$omp atomic seq_cst seq_cst update
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
!ERROR: At most one SEQ_CST clause can appear on the ATOMIC directive
|
|
!$omp atomic update seq_cst seq_cst
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
!ERROR: At most one SEQ_CST clause can appear on the ATOMIC directive
|
|
!$omp atomic seq_cst update seq_cst
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
|
|
!ERROR: At most one RELEASE clause can appear on the ATOMIC directive
|
|
!$omp atomic release release update
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
!ERROR: At most one RELEASE clause can appear on the ATOMIC directive
|
|
!$omp atomic update release release
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
!ERROR: At most one RELEASE clause can appear on the ATOMIC directive
|
|
!$omp atomic release update release
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
|
|
!ERROR: At most one RELAXED clause can appear on the ATOMIC directive
|
|
!$omp atomic relaxed relaxed update
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
!ERROR: At most one RELAXED clause can appear on the ATOMIC directive
|
|
!$omp atomic update relaxed relaxed
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
!ERROR: At most one RELAXED clause can appear on the ATOMIC directive
|
|
!$omp atomic relaxed update relaxed
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
|
|
!CAPTURE
|
|
!ERROR: At most one SEQ_CST clause can appear on the ATOMIC directive
|
|
!$omp atomic seq_cst seq_cst capture
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
!ERROR: At most one SEQ_CST clause can appear on the ATOMIC directive
|
|
!$omp atomic capture seq_cst seq_cst
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
|
|
!ERROR: At most one SEQ_CST clause can appear on the ATOMIC directive
|
|
!$omp atomic seq_cst capture seq_cst
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
|
|
!ERROR: At most one RELEASE clause can appear on the ATOMIC directive
|
|
!$omp atomic release release capture
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
|
|
!ERROR: At most one RELEASE clause can appear on the ATOMIC directive
|
|
!$omp atomic capture release release
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
|
|
!ERROR: At most one RELEASE clause can appear on the ATOMIC directive
|
|
!$omp atomic release capture release
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
|
|
!ERROR: At most one RELAXED clause can appear on the ATOMIC directive
|
|
!$omp atomic relaxed relaxed capture
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
|
|
!ERROR: At most one RELAXED clause can appear on the ATOMIC directive
|
|
!$omp atomic capture relaxed relaxed
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
|
|
!ERROR: At most one RELAXED clause can appear on the ATOMIC directive
|
|
!$omp atomic relaxed capture relaxed
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
|
|
!ERROR: At most one ACQ_REL clause can appear on the ATOMIC directive
|
|
!$omp atomic acq_rel acq_rel capture
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
|
|
!ERROR: At most one ACQ_REL clause can appear on the ATOMIC directive
|
|
!$omp atomic capture acq_rel acq_rel
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
|
|
!ERROR: At most one ACQ_REL clause can appear on the ATOMIC directive
|
|
!$omp atomic acq_rel capture acq_rel
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
|
|
!ERROR: At most one ACQUIRE clause can appear on the ATOMIC directive
|
|
!$omp atomic acquire acquire capture
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
|
|
!ERROR: At most one ACQUIRE clause can appear on the ATOMIC directive
|
|
!$omp atomic capture acquire acquire
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
|
|
!ERROR: At most one ACQUIRE clause can appear on the ATOMIC directive
|
|
!$omp atomic acquire capture acquire
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
|
|
!WRITE
|
|
!ERROR: At most one SEQ_CST clause can appear on the ATOMIC directive
|
|
!$omp atomic seq_cst seq_cst write
|
|
i = j
|
|
!ERROR: At most one SEQ_CST clause can appear on the ATOMIC directive
|
|
!$omp atomic write seq_cst seq_cst
|
|
i = j
|
|
|
|
!ERROR: At most one SEQ_CST clause can appear on the ATOMIC directive
|
|
!$omp atomic seq_cst write seq_cst
|
|
i = j
|
|
|
|
!ERROR: At most one RELEASE clause can appear on the ATOMIC directive
|
|
!$omp atomic release release write
|
|
i = j
|
|
!ERROR: At most one RELEASE clause can appear on the ATOMIC directive
|
|
!$omp atomic write release release
|
|
i = j
|
|
!ERROR: At most one RELEASE clause can appear on the ATOMIC directive
|
|
!$omp atomic release write release
|
|
i = j
|
|
!ERROR: At most one RELAXED clause can appear on the ATOMIC directive
|
|
!$omp atomic relaxed relaxed write
|
|
i = j
|
|
!ERROR: At most one RELAXED clause can appear on the ATOMIC directive
|
|
!$omp atomic write relaxed relaxed
|
|
i = j
|
|
!ERROR: At most one RELAXED clause can appear on the ATOMIC directive
|
|
!$omp atomic relaxed write relaxed
|
|
i = j
|
|
|
|
!No atomic-clause
|
|
!ERROR: At most one RELAXED clause can appear on the ATOMIC directive
|
|
!$omp atomic relaxed relaxed
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
!ERROR: At most one SEQ_CST clause can appear on the ATOMIC directive
|
|
!$omp atomic seq_cst seq_cst
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
!ERROR: At most one RELEASE clause can appear on the ATOMIC directive
|
|
!$omp atomic release release
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
|
|
! 2.17.7.3
|
|
! At most one hint clause may appear on the construct.
|
|
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic hint(omp_sync_hint_speculative) hint(omp_sync_hint_speculative) read
|
|
i = j
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic hint(omp_sync_hint_nonspeculative) read hint(omp_sync_hint_nonspeculative)
|
|
i = j
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic read hint(omp_sync_hint_uncontended) hint (omp_sync_hint_uncontended)
|
|
i = j
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic hint(omp_sync_hint_contended) hint(omp_sync_hint_speculative) write
|
|
i = j
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic hint(omp_sync_hint_nonspeculative) write hint(omp_sync_hint_nonspeculative)
|
|
i = j
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic write hint(omp_sync_hint_none) hint (omp_sync_hint_uncontended)
|
|
i = j
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic hint(omp_sync_hint_contended) hint(omp_sync_hint_speculative) write
|
|
i = j
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic hint(omp_sync_hint_nonspeculative) write hint(omp_sync_hint_nonspeculative)
|
|
i = j
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic write hint(omp_sync_hint_none) hint (omp_sync_hint_uncontended)
|
|
i = j
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic hint(omp_sync_hint_contended) hint(omp_sync_hint_speculative) update
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic hint(omp_sync_hint_nonspeculative) update hint(omp_sync_hint_nonspeculative)
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic update hint(omp_sync_hint_none) hint (omp_sync_hint_uncontended)
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic hint(omp_sync_hint_contended) hint(omp_sync_hint_speculative)
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic hint(omp_sync_hint_none) hint(omp_sync_hint_nonspeculative)
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic hint(omp_sync_hint_none) hint (omp_sync_hint_uncontended)
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic hint(omp_sync_hint_contended) hint(omp_sync_hint_speculative) capture
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic hint(omp_sync_hint_nonspeculative) capture hint(omp_sync_hint_nonspeculative)
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
!ERROR: At most one HINT clause can appear on the ATOMIC directive
|
|
!$omp atomic capture hint(omp_sync_hint_none) hint (omp_sync_hint_uncontended)
|
|
i = j
|
|
j = k
|
|
!$omp end atomic
|
|
! 2.17.7.4
|
|
! If atomic-clause is read then memory-order-clause must not be acq_rel or release.
|
|
|
|
!$omp atomic acq_rel read
|
|
i = j
|
|
!$omp atomic read acq_rel
|
|
i = j
|
|
|
|
!$omp atomic release read
|
|
i = j
|
|
!$omp atomic read release
|
|
i = j
|
|
|
|
! 2.17.7.5
|
|
! If atomic-clause is write then memory-order-clause must not be acq_rel or acquire.
|
|
|
|
!$omp atomic acq_rel write
|
|
i = j
|
|
!$omp atomic write acq_rel
|
|
i = j
|
|
|
|
!$omp atomic acquire write
|
|
i = j
|
|
!$omp atomic write acquire
|
|
i = j
|
|
|
|
|
|
! 2.17.7.6
|
|
! If atomic-clause is update or not present then memory-order-clause must not be acq_rel or acquire.
|
|
|
|
!$omp atomic acq_rel update
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
!$omp atomic update acq_rel
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
|
|
!$omp atomic acquire update
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
|
|
!$omp atomic update acquire
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
|
|
!$omp atomic acq_rel
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
|
|
!$omp atomic acquire
|
|
!ERROR: The atomic variable i should appear as an argument in the update operation
|
|
i = j
|
|
end program
|
|
|