Previously MappedBlockStream owned its own BumpPtrAllocator that it would allocate from when a read crossed a block boundary. This way it could still return the user a contiguous buffer of the requested size. However, It's not uncommon to open a stream, read some stuff, close it, and then save the information for later. After all, since the entire file is mapped into memory, the data should always be available as long as the file is open. Of course, the exception to this is when the data isn't *in* the file, but rather in some buffer that we temporarily allocated to present this contiguous view. And this buffer would get destroyed as soon as the strema was closed. The fix here is to force the user to specify the allocator, this way it can provide an allocator that has whatever lifetime it chooses. Differential Revision: https://reviews.llvm.org/D33858 llvm-svn: 304623
75 lines
2.4 KiB
C++
75 lines
2.4 KiB
C++
//===- InfoStreamBuilder.cpp - PDB Info Stream Creation ---------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/DebugInfo/PDB/Native/InfoStreamBuilder.h"
|
|
|
|
#include "llvm/DebugInfo/MSF/MSFBuilder.h"
|
|
#include "llvm/DebugInfo/MSF/MappedBlockStream.h"
|
|
#include "llvm/DebugInfo/PDB/Native/InfoStream.h"
|
|
#include "llvm/DebugInfo/PDB/Native/NamedStreamMap.h"
|
|
#include "llvm/DebugInfo/PDB/Native/PDBFileBuilder.h"
|
|
#include "llvm/DebugInfo/PDB/Native/RawError.h"
|
|
#include "llvm/DebugInfo/PDB/Native/RawTypes.h"
|
|
#include "llvm/Support/BinaryStreamWriter.h"
|
|
|
|
using namespace llvm;
|
|
using namespace llvm::codeview;
|
|
using namespace llvm::msf;
|
|
using namespace llvm::pdb;
|
|
|
|
InfoStreamBuilder::InfoStreamBuilder(msf::MSFBuilder &Msf,
|
|
NamedStreamMap &NamedStreams)
|
|
: Msf(Msf), Ver(PdbRaw_ImplVer::PdbImplVC70), Sig(-1), Age(0),
|
|
NamedStreams(NamedStreams) {}
|
|
|
|
void InfoStreamBuilder::setVersion(PdbRaw_ImplVer V) { Ver = V; }
|
|
|
|
void InfoStreamBuilder::setSignature(uint32_t S) { Sig = S; }
|
|
|
|
void InfoStreamBuilder::setAge(uint32_t A) { Age = A; }
|
|
|
|
void InfoStreamBuilder::setGuid(PDB_UniqueId G) { Guid = G; }
|
|
|
|
void InfoStreamBuilder::addFeature(PdbRaw_FeatureSig Sig) {
|
|
Features.push_back(Sig);
|
|
}
|
|
|
|
Error InfoStreamBuilder::finalizeMsfLayout() {
|
|
uint32_t Length = sizeof(InfoStreamHeader) + NamedStreams.finalize() +
|
|
(Features.size() + 1) * sizeof(uint32_t);
|
|
if (auto EC = Msf.setStreamSize(StreamPDB, Length))
|
|
return EC;
|
|
return Error::success();
|
|
}
|
|
|
|
Error InfoStreamBuilder::commit(const msf::MSFLayout &Layout,
|
|
WritableBinaryStreamRef Buffer) const {
|
|
auto InfoS = WritableMappedBlockStream::createIndexedStream(
|
|
Layout, Buffer, StreamPDB, Msf.getAllocator());
|
|
BinaryStreamWriter Writer(*InfoS);
|
|
|
|
InfoStreamHeader H;
|
|
H.Age = Age;
|
|
H.Signature = Sig;
|
|
H.Version = Ver;
|
|
H.Guid = Guid;
|
|
if (auto EC = Writer.writeObject(H))
|
|
return EC;
|
|
|
|
if (auto EC = NamedStreams.commit(Writer))
|
|
return EC;
|
|
if (auto EC = Writer.writeInteger(0))
|
|
return EC;
|
|
for (auto E : Features) {
|
|
if (auto EC = Writer.writeEnum(E))
|
|
return EC;
|
|
}
|
|
return Error::success();
|
|
}
|