This was a pure virtual base class whose purpose was to abstract away the notion of how you retrieve the layout of a discontiguous stream of blocks in an Msf file. This led to too many layers of abstraction making it difficult to figure out what was going on and extend things. Ultimately, a stream's layout is decided by its length and the array of block numbers that it lives on. So rather than have an abstract base class which can return this in any number of ways, it's more straightforward to simply store them as fields of a trivial struct, and also to give a more appropriate name. This patch does that. It renames IMsfStreamData to MsfStreamLayout, and deletes the 2 concrete implementations, DirectoryStreamData and IndexedStreamData. MsfStreamLayout is a trivial struct with the necessary data. llvm-svn: 277018
83 lines
2.7 KiB
C++
83 lines
2.7 KiB
C++
//===- ModStream.cpp - PDB Module Info Stream Access ----------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/DebugInfo/PDB/Raw/ModStream.h"
|
|
|
|
#include "llvm/DebugInfo/Msf/StreamReader.h"
|
|
#include "llvm/DebugInfo/PDB/Raw/ModInfo.h"
|
|
#include "llvm/DebugInfo/PDB/Raw/PDBFile.h"
|
|
#include "llvm/DebugInfo/PDB/Raw/RawError.h"
|
|
#include "llvm/DebugInfo/PDB/Raw/RawTypes.h"
|
|
|
|
using namespace llvm;
|
|
using namespace llvm::msf;
|
|
using namespace llvm::pdb;
|
|
|
|
ModStream::ModStream(const ModInfo &Module,
|
|
std::unique_ptr<MappedBlockStream> Stream)
|
|
: Mod(Module), Stream(std::move(Stream)) {}
|
|
|
|
ModStream::~ModStream() {}
|
|
|
|
Error ModStream::reload() {
|
|
StreamReader Reader(*Stream);
|
|
|
|
uint32_t SymbolSize = Mod.getSymbolDebugInfoByteSize();
|
|
uint32_t C11Size = Mod.getLineInfoByteSize();
|
|
uint32_t C13Size = Mod.getC13LineInfoByteSize();
|
|
|
|
if (C11Size > 0 && C13Size > 0)
|
|
return llvm::make_error<RawError>(raw_error_code::corrupt_file,
|
|
"Module has both C11 and C13 line info");
|
|
|
|
StreamRef S;
|
|
|
|
uint32_t SymbolSubstreamSig = 0;
|
|
if (auto EC = Reader.readInteger(SymbolSubstreamSig))
|
|
return EC;
|
|
if (auto EC = Reader.readArray(SymbolsSubstream, SymbolSize - 4))
|
|
return EC;
|
|
|
|
if (auto EC = Reader.readStreamRef(LinesSubstream, C11Size))
|
|
return EC;
|
|
if (auto EC = Reader.readStreamRef(C13LinesSubstream, C13Size))
|
|
return EC;
|
|
|
|
StreamReader LineReader(C13LinesSubstream);
|
|
if (auto EC = LineReader.readArray(LineInfo, LineReader.bytesRemaining()))
|
|
return EC;
|
|
|
|
uint32_t GlobalRefsSize;
|
|
if (auto EC = Reader.readInteger(GlobalRefsSize))
|
|
return EC;
|
|
if (auto EC = Reader.readStreamRef(GlobalRefsSubstream, GlobalRefsSize))
|
|
return EC;
|
|
if (Reader.bytesRemaining() > 0)
|
|
return llvm::make_error<RawError>(raw_error_code::corrupt_file,
|
|
"Unexpected bytes in module stream.");
|
|
|
|
return Error::success();
|
|
}
|
|
|
|
iterator_range<codeview::CVSymbolArray::Iterator>
|
|
ModStream::symbols(bool *HadError) const {
|
|
// It's OK if the stream is empty.
|
|
if (SymbolsSubstream.getUnderlyingStream().getLength() == 0)
|
|
return llvm::make_range(SymbolsSubstream.end(), SymbolsSubstream.end());
|
|
return llvm::make_range(SymbolsSubstream.begin(HadError),
|
|
SymbolsSubstream.end());
|
|
}
|
|
|
|
iterator_range<codeview::ModuleSubstreamArray::Iterator>
|
|
ModStream::lines(bool *HadError) const {
|
|
return llvm::make_range(LineInfo.begin(HadError), LineInfo.end());
|
|
}
|
|
|
|
Error ModStream::commit() { return Error::success(); }
|