647804a84a
Adjustments should be considered properly; we should copy the unadjusted object over the whole temporary base region. If the unadjusted object is no longer available in the Environment, invalidate the temporary base region, and then copy the adjusted object into the adjusted sub-region of the temporary region. This fixes a regression introduced by r288263, that caused various false positives, due to copying only adjusted object into the adjusted region; the rest of the base region therefore remained undefined. Before r288263, the adjusted value was copied over the unadjusted region, which is incorrect, but accidentally worked better due to how region store disregards compound value bindings to non-base regions. An additional test machinery is introduced to make sure that despite making two binds, we only notify checkers once for both of them, without exposing the partially copied objects. This fix is a hack over a hack. The proper fix would be to model C++ temporaries in the CFG, and after that dealing with adjustments would no longer be necessary, and the values we need would no longer disappear from the Environment. rdar://problem/30658168 Differential Revision: https://reviews.llvm.org/D30534 llvm-svn: 298924
37 lines
1.1 KiB
C++
37 lines
1.1 KiB
C++
// RUN: %clang_cc1 -analyze -analyzer-checker=debug.AnalysisOrder -analyzer-config debug.AnalysisOrder:Bind=true -analyzer-config debug.AnalysisOrder:RegionChanges=true %s 2>&1 | FileCheck %s
|
|
|
|
struct Super {
|
|
virtual void m();
|
|
};
|
|
struct Sub : Super {
|
|
virtual void m() {}
|
|
};
|
|
|
|
void testTemporaries() {
|
|
// This triggers RegionChanges twice:
|
|
// - Once for zero-initialization of the structure.
|
|
// - Once for creating a temporary region and copying the structure there.
|
|
// FIXME: This code shouldn't really produce the extra temporary, however
|
|
// that's how we behave for now.
|
|
Sub().m();
|
|
}
|
|
|
|
void seeIfCheckBindWorks() {
|
|
// This should trigger checkBind. The rest of the code shouldn't.
|
|
// This also triggers checkRegionChanges after that.
|
|
// Note that this function is analyzed first, so the messages would be on top.
|
|
int x = 1;
|
|
}
|
|
|
|
// seeIfCheckBindWorks():
|
|
// CHECK: Bind
|
|
// CHECK-NEXT: RegionChanges
|
|
|
|
// testTemporaries():
|
|
// CHECK-NEXT: RegionChanges
|
|
// CHECK-NEXT: RegionChanges
|
|
|
|
// Make sure there's no further output.
|
|
// CHECK-NOT: Bind
|
|
// CHECK-NOT: RegionChanges
|