8a1cd91016
Summary: This should improve optimized debug info for address-taken variables at the cost of inaccurate debug info in some situations. We patched this into clang and deployed this change to Chromium developers, and this significantly improved debuggability of optimized code. The long-term solution to PR34136 seems more and more like it's going to take a while, so I would like to commit this change under a flag so that it can be used as a stop-gap measure. This flag should really help so for C++ aggregates like std::string and std::vector, which are typically address-taken, even after inlining, and cannot be SROA-ed. Reviewers: aprantl, dblaikie, probinson, dberlin Subscribers: hiraditya, llvm-commits Differential Revision: https://reviews.llvm.org/D36596 llvm-svn: 313108
60 lines
2.6 KiB
LLVM
60 lines
2.6 KiB
LLVM
; RUN: opt -instcombine -instcombine-lower-dbg-declare=1 -S < %s | FileCheck %s
|
|
; RUN: opt -instcombine -instcombine-lower-dbg-declare=0 -S < %s | FileCheck %s --check-prefix=DECLARE
|
|
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-pc-linux-gnu"
|
|
|
|
%foo = type { i64, i32, i32 }
|
|
|
|
; Function Attrs: nounwind readnone
|
|
declare void @llvm.dbg.declare(metadata, metadata, metadata) #0
|
|
declare void @llvm.dbg.value(metadata, metadata, metadata) #0
|
|
|
|
; Function Attrs: sspreq
|
|
define void @julia_fastshortest_6256() #1 {
|
|
top:
|
|
%cp = alloca %foo, align 8
|
|
call void @llvm.dbg.declare(metadata %foo* %cp, metadata !1, metadata !16), !dbg !17
|
|
br i1 undef, label %idxend, label %fail
|
|
|
|
fail: ; preds = %top
|
|
unreachable
|
|
|
|
idxend: ; preds = %top
|
|
; CHECK-NOT: call void @llvm.dbg.value(metadata %foo* %cp,
|
|
%0 = load volatile %foo, %foo* %cp, align 8
|
|
; CHECK: call void @llvm.dbg.value(metadata %foo %0,
|
|
store volatile %foo %0, %foo* undef, align 8
|
|
ret void
|
|
}
|
|
|
|
; Keep the declare if we keep the alloca.
|
|
; DECLARE-LABEL: define void @julia_fastshortest_6256()
|
|
; DECLARE: %cp = alloca %foo, align 8
|
|
; DECLARE: call void @llvm.dbg.declare(metadata %foo* %cp,
|
|
|
|
attributes #0 = { nounwind readnone }
|
|
attributes #1 = { sspreq }
|
|
|
|
!llvm.module.flags = !{!0}
|
|
!llvm.dbg.cu = !{!18}
|
|
|
|
!0 = !{i32 1, !"Debug Info Version", i32 3}
|
|
!1 = !DILocalVariable(name: "cp", scope: !2, file: !3, line: 106, type: !12)
|
|
!2 = distinct !DISubprogram(name: "fastshortest", linkageName: "julia_fastshortest_6256", scope: null, file: !3, type: !4, isLocal: false, isDefinition: true, isOptimized: true, unit: !18, variables: !11)
|
|
!3 = !DIFile(filename: "grisu/fastshortest.jl", directory: ".")
|
|
!4 = !DISubroutineType(types: !5)
|
|
!5 = !{!6, !7}
|
|
!6 = !DIBasicType(name: "Float64", size: 64, align: 64, encoding: DW_ATE_unsigned)
|
|
!7 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !8, size: 64, align: 64)
|
|
!8 = !DICompositeType(tag: DW_TAG_structure_type, name: "jl_value_t", file: !9, line: 71, align: 64, elements: !10)
|
|
!9 = !DIFile(filename: "julia.h", directory: "")
|
|
!10 = !{!7}
|
|
!11 = !{}
|
|
!12 = !DICompositeType(tag: DW_TAG_structure_type, name: "Float", size: 128, align: 64, elements: !13, runtimeLang: DW_LANG_Julia)
|
|
!13 = !{!14, !15, !15}
|
|
!14 = !DIBasicType(name: "UInt64", size: 64, align: 64, encoding: DW_ATE_unsigned)
|
|
!15 = !DIBasicType(name: "Int32", size: 32, align: 32, encoding: DW_ATE_unsigned)
|
|
!16 = !DIExpression()
|
|
!17 = !DILocation(line: 106, scope: !2)
|
|
!18 = distinct !DICompileUnit(language: DW_LANG_Julia, file: !3)
|