1b4f161978
Testing `openmp` on Solaris/amd64 shows a large number of failures, all
due to the same issue:
```
# .---command stderr------------
# | openmp/runtime/test/ompt/misc/interoperability.cpp:67:16: error: CHECK-SAME: expected string not found in input
# | // CHECK-SAME: parent_task_frame.reenter={{0x[0-f]+}}
# | ^
# | <stdin>:5:101: note: scanning from here
# | 281474976710658: ompt_event_parallel_begin: parent_task_id=281474976710659, parent_task_frame.exit=0, parent_task_frame.reenter=7fffbedffe90, parallel_id=281474976710661, requested_team_size=2, codeptr_ra=408b8e, invoker=2
```
The testsuite expects pointers to be printed with a `0x` prefix when
using the `%p` format, while Solaris `libc` just prints them in hex
without a prefix.
However, this difference is completely benign. ISO C (up to C23,
7.23.6.1) states
```
p The argument shall be a pointer to void or a pointer to a character
type. The value of the pointer is converted to a sequence of printing
characters, in an implementation-defined manner.
```
I saw two ways around this:
- replace every instance of `%p` with a macro (`KMP_PTR_FMT`, defined as
`"%p"` or `"0x%p" as appropriate), or
- adjust the testsuite to make the `0x` prefix optional
The second route seemed less intrusive and more readable, so that's what
this patch does. While large, it's also completely mechanical.
Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.
73 lines
2.3 KiB
C
73 lines
2.3 KiB
C
// RUN: %libomp-compile && %libomp-run | FileCheck %s
|
|
// REQUIRES: ompt
|
|
#include "callback.h"
|
|
#include <omp.h>
|
|
|
|
int main() {
|
|
#pragma omp parallel num_threads(1)
|
|
{
|
|
// ompt_get_callback()
|
|
ompt_callback_t callback;
|
|
ompt_get_callback(ompt_callback_thread_begin, &callback);
|
|
printf("%" PRIu64 ": &on_ompt_callback_thread_begin=%p\n",
|
|
ompt_get_thread_data()->value, &on_ompt_callback_thread_begin);
|
|
printf("%" PRIu64 ": ompt_get_callback() result=%p\n",
|
|
ompt_get_thread_data()->value, callback);
|
|
|
|
// ompt_get_state()
|
|
printf("%" PRIu64 ": ompt_get_state()=%d\n", ompt_get_thread_data()->value,
|
|
ompt_get_state(NULL));
|
|
|
|
// ompt_enumerate_states()
|
|
int state = ompt_state_undefined;
|
|
const char *state_name;
|
|
int steps = 0;
|
|
while (ompt_enumerate_states(state, &state, &state_name) && steps < 1000) {
|
|
steps++;
|
|
if (!state_name)
|
|
printf("%" PRIu64 ": state_name is NULL\n",
|
|
ompt_get_thread_data()->value);
|
|
}
|
|
if (steps >= 1000) {
|
|
// enumeration did not end after 1000 steps
|
|
printf("%" PRIu64 ": states enumeration did not end\n",
|
|
ompt_get_thread_data()->value);
|
|
}
|
|
|
|
// ompt_enumerate_mutex_impls()
|
|
int impl = ompt_mutex_impl_none;
|
|
const char *impl_name;
|
|
steps = 0;
|
|
while (ompt_enumerate_mutex_impls(impl, &impl, &impl_name) &&
|
|
steps < 1000) {
|
|
steps++;
|
|
if (!impl_name)
|
|
printf("%" PRIu64 ": impl_name is NULL\n",
|
|
ompt_get_thread_data()->value);
|
|
}
|
|
if (steps >= 1000) {
|
|
// enumeration did not end after 1000 steps
|
|
printf("%" PRIu64 ": mutex_impls enumeration did not end\n",
|
|
ompt_get_thread_data()->value);
|
|
}
|
|
}
|
|
|
|
// Check if libomp supports the callbacks for this test.
|
|
|
|
// CHECK: 0: NULL_POINTER=[[NULL:.*$]]
|
|
|
|
// CHECK: {{^}}[[THREAD_ID:[0-9]+]]: &on_ompt_callback_thread_begin
|
|
// CHECK-SAME: =[[FUNCTION_POINTER:(0x)?[0-f]+]]
|
|
// CHECK: {{^}}[[THREAD_ID]]: ompt_get_callback() result=[[FUNCTION_POINTER]]
|
|
|
|
// CHECK: {{^}}[[THREAD_ID]]: ompt_get_state()=1
|
|
|
|
// CHECK-NOT: {{^}}[[THREAD_ID]]: state_name is NULL
|
|
// CHECK-NOT: {{^}}[[THREAD_ID]]: states enumeration did not end
|
|
|
|
// CHECK-NOT: {{^}}[[THREAD_ID]]: impl_name is NULL
|
|
// CHECK-NOT: {{^}}[[THREAD_ID]]: mutex_impls enumeration did not end
|
|
|
|
return 0;
|
|
}
|