Testing `openmp` on Solaris/amd64 shows a large number of failures, all
due to the same issue:
```
# .---command stderr------------
# | openmp/runtime/test/ompt/misc/interoperability.cpp:67:16: error: CHECK-SAME: expected string not found in input
# | // CHECK-SAME: parent_task_frame.reenter={{0x[0-f]+}}
# | ^
# | <stdin>:5:101: note: scanning from here
# | 281474976710658: ompt_event_parallel_begin: parent_task_id=281474976710659, parent_task_frame.exit=0, parent_task_frame.reenter=7fffbedffe90, parallel_id=281474976710661, requested_team_size=2, codeptr_ra=408b8e, invoker=2
```
The testsuite expects pointers to be printed with a `0x` prefix when
using the `%p` format, while Solaris `libc` just prints them in hex
without a prefix.
However, this difference is completely benign. ISO C (up to C23,
7.23.6.1) states
```
p The argument shall be a pointer to void or a pointer to a character
type. The value of the pointer is converted to a sequence of printing
characters, in an implementation-defined manner.
```
I saw two ways around this:
- replace every instance of `%p` with a macro (`KMP_PTR_FMT`, defined as
`"%p"` or `"0x%p" as appropriate), or
- adjust the testsuite to make the `0x` prefix optional
The second route seemed less intrusive and more readable, so that's what
this patch does. While large, it's also completely mechanical.
Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.
91 lines
4.1 KiB
C
91 lines
4.1 KiB
C
// RUN: %libomp-compile && env OMP_THREAD_LIMIT=2 %libomp-run | FileCheck %s
|
|
// RUN: %libomp-compile && env OMP_THREAD_LIMIT=2 %libomp-run | %sort-threads \
|
|
// RUN: | FileCheck --check-prefix=THREADS %s
|
|
|
|
// REQUIRES: ompt
|
|
|
|
#include "callback.h"
|
|
|
|
int main() {
|
|
#pragma omp parallel num_threads(4)
|
|
{
|
|
print_ids(0);
|
|
print_ids(1);
|
|
}
|
|
print_fuzzy_address(1);
|
|
|
|
// Check if libomp supports the callbacks for this test.
|
|
// CHECK-NOT: {{^}}0: Could not register callback
|
|
|
|
// Make sure initial data pointers are null.
|
|
// CHECK-NOT: 0: parallel_data initially not null
|
|
// CHECK-NOT: 0: task_data initially not null
|
|
// CHECK-NOT: 0: thread_data initially not null
|
|
|
|
// Only check callback names, arguments are verified in THREADS below.
|
|
// CHECK: {{^}}[[MASTER_ID:[0-9]+]]: ompt_event_parallel_begin
|
|
|
|
// CHECK-DAG: {{^}}[[MASTER_ID]]: ompt_event_implicit_task_begin
|
|
// CHECK-DAG: {{^}}[[MASTER_ID]]: ompt_event_implicit_task_end
|
|
|
|
// Note that we cannot ensure that the worker threads have already called
|
|
// barrier_end and implicit_task_end before parallel_end!
|
|
|
|
// CHECK-DAG: {{^}}[[THREAD_ID:[0-9]+]]: ompt_event_implicit_task_begin
|
|
// CHECK-DAG: {{^}}[[THREAD_ID]]: ompt_event_barrier_implicit_parallel_begin
|
|
|
|
// CHECK: {{^}}[[MASTER_ID]]: ompt_event_parallel_end
|
|
|
|
// THREADS: 0: NULL_POINTER=[[NULL:.*$]]
|
|
// THREADS: {{^}}[[MASTER_ID:[0-9]+]]: ompt_event_thread_begin
|
|
// THREADS-SAME: thread_type=ompt_thread_initial=1, thread_id=[[MASTER_ID]]
|
|
// THREADS: {{^}}[[MASTER_ID]]: ompt_event_parallel_begin
|
|
// THREADS-SAME: parent_task_id=[[PARENT_TASK_ID:[0-9]+]]
|
|
// THREADS-SAME: parent_task_frame.exit=[[NULL]]
|
|
// THREADS-SAME: parent_task_frame.reenter={{(0x)?[0-f]+}}
|
|
// THREADS-SAME: parallel_id=[[PARALLEL_ID:[0-9]+]], requested_team_size=4
|
|
// THREADS-SAME: codeptr_ra=[[RETURN_ADDRESS:(0x)?[0-f]+]]{{[0-f][0-f]}}
|
|
|
|
// THREADS: {{^}}[[MASTER_ID]]: ompt_event_implicit_task_begin
|
|
// THREADS-SAME: parallel_id=[[PARALLEL_ID]]
|
|
// THREADS-SAME: task_id=[[IMPLICIT_TASK_ID:[0-9]+]]
|
|
// THREADS: {{^}}[[MASTER_ID]]: task level 0
|
|
// THREADS-SAME: parallel_id=[[PARALLEL_ID]], task_id=[[IMPLICIT_TASK_ID]]
|
|
// THREADS: {{^}}[[MASTER_ID]]: task level 1
|
|
// THREADS-SAME: parallel_id=[[IMPLICIT_PARALLEL_ID:[0-9]+]]
|
|
// THREADS-SAME: task_id=[[PARENT_TASK_ID]]
|
|
|
|
// THREADS-NOT: {{^}}[[MASTER_ID]]: ompt_event_implicit_task_end
|
|
// THREADS: {{^}}[[MASTER_ID]]: ompt_event_barrier_implicit_parallel_begin
|
|
// THREADS-SAME: parallel_id=[[PARALLEL_ID]], task_id=[[IMPLICIT_TASK_ID]]
|
|
// parallel_id is 0 because the region ended in the barrier!
|
|
// THREADS: {{^}}[[MASTER_ID]]: ompt_event_barrier_implicit_parallel_end
|
|
// THREADS-SAME: parallel_id=0, task_id=[[IMPLICIT_TASK_ID]]
|
|
// THREADS: {{^}}[[MASTER_ID]]: ompt_event_implicit_task_end
|
|
// THREADS-SAME: parallel_id=0, task_id=[[IMPLICIT_TASK_ID]]
|
|
// THREADS: {{^}}[[MASTER_ID]]: ompt_event_parallel_end
|
|
// THREADS-SAME: parallel_id=[[PARALLEL_ID]], task_id=[[PARENT_TASK_ID]]
|
|
// THREADS: {{^}}[[MASTER_ID]]: fuzzy_address={{.*}}[[RETURN_ADDRESS]]
|
|
|
|
// THREADS: {{^}}[[THREAD_ID:[0-9]+]]: ompt_event_thread_begin
|
|
// THREADS-SAME: thread_type=ompt_thread_worker=2, thread_id=[[THREAD_ID]]
|
|
// THREADS: {{^}}[[THREAD_ID]]: ompt_event_implicit_task_begin
|
|
// THREADS-SAME: parallel_id=[[PARALLEL_ID]]
|
|
// THREADS-SAME: task_id=[[IMPLICIT_TASK_ID:[0-9]+]]
|
|
// THREADS: {{^}}[[THREAD_ID]]: task level 0
|
|
// THREADS-SAME: parallel_id=[[PARALLEL_ID]], task_id=[[IMPLICIT_TASK_ID]]
|
|
// THREADS: {{^}}[[THREAD_ID]]: task level 1
|
|
// THREADS-SAME: parallel_id=[[IMPLICIT_PARALLEL_ID]]
|
|
// THREADS-SAME: task_id=[[PARENT_TASK_ID]]
|
|
// THREADS-NOT: {{^}}[[THREAD_ID]]: ompt_event_implicit_task_end
|
|
// THREADS: {{^}}[[THREAD_ID]]: ompt_event_barrier_implicit_parallel_begin
|
|
// THREADS-SAME: parallel_id=[[PARALLEL_ID]], task_id=[[IMPLICIT_TASK_ID]]
|
|
// parallel_id is 0 because the region ended in the barrier!
|
|
// THREADS: {{^}}[[THREAD_ID]]: ompt_event_barrier_implicit_parallel_end
|
|
// THREADS-SAME: parallel_id=0, task_id=[[IMPLICIT_TASK_ID]]
|
|
// THREADS: {{^}}[[THREAD_ID]]: ompt_event_implicit_task_end
|
|
// THREADS-SAME: parallel_id=0, task_id=[[IMPLICIT_TASK_ID]]
|
|
|
|
return 0;
|
|
}
|