16bf43398a
Detected by evil-izing the widely used `MoveOnly` testing type. I had to patch some tests that were themselves using its comma operator, but I think that's a worthwhile cost in order to catch more places in our headers that needed comma-proofing. The trick here is that even `++ptr, SomeClass()` can find a comma operator by ADL, if `ptr` is of type `Evil*`. (A comma between two operands of non-class-or-enum type is always treated as the built-in comma, without ADL. But if either operand is class-or-enum, then ADL happens for _both_ operands' types.) Differential Revision: https://reviews.llvm.org/D109414
71 lines
2.1 KiB
C++
71 lines
2.1 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef MOVEONLY_H
|
|
#define MOVEONLY_H
|
|
|
|
#include "test_macros.h"
|
|
|
|
#if TEST_STD_VER >= 11
|
|
|
|
#include <cstddef>
|
|
#include <functional>
|
|
|
|
class MoveOnly
|
|
{
|
|
MoveOnly(const MoveOnly&);
|
|
MoveOnly& operator=(const MoveOnly&);
|
|
|
|
int data_;
|
|
public:
|
|
constexpr MoveOnly(int data = 1) : data_(data) {}
|
|
TEST_CONSTEXPR_CXX14 MoveOnly(MoveOnly&& x)
|
|
: data_(x.data_) {x.data_ = 0;}
|
|
TEST_CONSTEXPR_CXX14 MoveOnly& operator=(MoveOnly&& x)
|
|
{data_ = x.data_; x.data_ = 0; return *this;}
|
|
|
|
constexpr int get() const {return data_;}
|
|
|
|
friend constexpr bool operator==(const MoveOnly& x, const MoveOnly& y)
|
|
{ return x.data_ == y.data_; }
|
|
friend constexpr bool operator!=(const MoveOnly& x, const MoveOnly& y)
|
|
{ return x.data_ != y.data_; }
|
|
friend constexpr bool operator< (const MoveOnly& x, const MoveOnly& y)
|
|
{ return x.data_ < y.data_; }
|
|
friend constexpr bool operator<=(const MoveOnly& x, const MoveOnly& y)
|
|
{ return x.data_ <= y.data_; }
|
|
friend constexpr bool operator> (const MoveOnly& x, const MoveOnly& y)
|
|
{ return x.data_ > y.data_; }
|
|
friend constexpr bool operator>=(const MoveOnly& x, const MoveOnly& y)
|
|
{ return x.data_ >= y.data_; }
|
|
|
|
TEST_CONSTEXPR_CXX14 MoveOnly operator+(const MoveOnly& x) const
|
|
{ return MoveOnly{data_ + x.data_}; }
|
|
TEST_CONSTEXPR_CXX14 MoveOnly operator*(const MoveOnly& x) const
|
|
{ return MoveOnly{data_ * x.data_}; }
|
|
|
|
template<class T, class U>
|
|
friend void operator,(T t, U u) = delete;
|
|
};
|
|
|
|
namespace std {
|
|
|
|
template <>
|
|
struct hash<MoveOnly>
|
|
{
|
|
typedef MoveOnly argument_type;
|
|
typedef size_t result_type;
|
|
constexpr size_t operator()(const MoveOnly& x) const {return x.get();}
|
|
};
|
|
|
|
}
|
|
|
|
#endif // TEST_STD_VER >= 11
|
|
|
|
#endif // MOVEONLY_H
|