Files
clang-p2996/llvm/test/CodeGen/PowerPC/fma-precision.ll
Jinsong Ji 3996311ee1 [DAGCombine] reassoc flag shouldn't enable contract
According to IR LangRef, the FMF flag:

contract
Allow floating-point contraction (e.g. fusing a multiply followed by an
addition into a fused multiply-and-add).

reassoc
Allow reassociation transformations for floating-point instructions.
This may dramatically change results in floating-point.

My understanding is that these two flags shouldn't imply each other,
as we might have a SDNode that can be reassociated with others, but
not contractble.

eg: We may want following fmul/fad/fsub to freely reassoc, but don't
want fma being generated here.

   %F = fmul reassoc double %A, %B         ; <double> [#uses=1]
   %G = fmul reassoc double %C, %D         ; <double> [#uses=1]
   %H = fadd reassoc double %F, %G         ; <double> [#uses=1]
   %I = fsub reassoc double %H, %E         ; <double> [#uses=1]

Before https://reviews.llvm.org/D45710, `reassoc` flag actually
did not imply isContratable either.

The current implementation also only check the flag in fadd node,
ignoring fmul node, this patch update that as well.

Reviewed By: spatel, qiucf

Differential Revision: https://reviews.llvm.org/D104247
2021-06-21 21:15:43 +00:00

164 lines
5.7 KiB
LLVM

; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc < %s -verify-machineinstrs -mcpu=pwr9 -mtriple=powerpc64le-linux-gnu | FileCheck %s
; Verify that the fold of a*b-c*d respect the uses of a*b
define double @fsub1(double %a, double %b, double %c, double %d) {
; CHECK-LABEL: fsub1:
; CHECK: # %bb.0: # %entry
; CHECK-NEXT: xsmuldp 0, 2, 1
; CHECK-NEXT: fmr 1, 0
; CHECK-NEXT: xsnmsubadp 1, 4, 3
; CHECK-NEXT: xsmuldp 1, 0, 1
; CHECK-NEXT: blr
entry:
%mul = fmul contract reassoc double %b, %a
%mul1 = fmul contract reassoc double %d, %c
%sub = fsub contract reassoc nsz double %mul, %mul1
%mul3 = fmul contract reassoc double %mul, %sub
ret double %mul3
}
; Verify that the fold of a*b-c*d respect the uses of c*d
define double @fsub2(double %a, double %b, double %c, double %d) {
; CHECK-LABEL: fsub2:
; CHECK: # %bb.0: # %entry
; CHECK-NEXT: xsmuldp 0, 4, 3
; CHECK-NEXT: fmr 3, 0
; CHECK-NEXT: xsmsubadp 3, 2, 1
; CHECK-NEXT: xsmuldp 1, 0, 3
; CHECK-NEXT: blr
entry:
%mul = fmul contract reassoc double %b, %a
%mul1 = fmul contract reassoc double %d, %c
%sub = fsub contract reassoc double %mul, %mul1
%mul3 = fmul contract reassoc double %mul1, %sub
ret double %mul3
}
; Verify that the fold of a*b-c*d if there is no uses of a*b and c*d
define double @fsub3(double %a, double %b, double %c, double %d) {
; CHECK-LABEL: fsub3:
; CHECK: # %bb.0: # %entry
; CHECK-NEXT: xsmuldp 0, 4, 3
; CHECK-NEXT: xsmsubadp 0, 2, 1
; CHECK-NEXT: fmr 1, 0
; CHECK-NEXT: blr
entry:
%mul = fmul contract reassoc double %b, %a
%mul1 = fmul contract reassoc double %d, %c
%sub = fsub contract reassoc double %mul, %mul1
ret double %sub
}
; Verify that the fold of a*b+c*d respect the uses of a*b
define double @fadd1(double %a, double %b, double %c, double %d) {
; CHECK-LABEL: fadd1:
; CHECK: # %bb.0: # %entry
; CHECK-NEXT: xsmuldp 0, 2, 1
; CHECK-NEXT: fmr 1, 0
; CHECK-NEXT: xsmaddadp 1, 4, 3
; CHECK-NEXT: xsmuldp 1, 0, 1
; CHECK-NEXT: blr
entry:
%mul = fmul contract reassoc double %b, %a
%mul1 = fmul contract reassoc double %d, %c
%add = fadd contract reassoc double %mul1, %mul
%mul3 = fmul contract reassoc double %mul, %add
ret double %mul3
}
; Verify that the fold of a*b+c*d respect the uses of c*d
define double @fadd2(double %a, double %b, double %c, double %d) {
; CHECK-LABEL: fadd2:
; CHECK: # %bb.0: # %entry
; CHECK-NEXT: xsmuldp 0, 4, 3
; CHECK-NEXT: fmr 3, 0
; CHECK-NEXT: xsmaddadp 3, 2, 1
; CHECK-NEXT: xsmuldp 1, 0, 3
; CHECK-NEXT: blr
entry:
%mul = fmul contract reassoc double %b, %a
%mul1 = fmul contract reassoc double %d, %c
%add = fadd contract reassoc double %mul1, %mul
%mul3 = fmul contract reassoc double %mul1, %add
ret double %mul3
}
; Verify that the fold of a*b+c*d if there is no uses of a*b and c*d
define double @fadd3(double %a, double %b, double %c, double %d) {
; CHECK-LABEL: fadd3:
; CHECK: # %bb.0: # %entry
; CHECK-NEXT: xsmuldp 1, 2, 1
; CHECK-NEXT: xsmaddadp 1, 4, 3
; CHECK-NEXT: blr
entry:
%mul = fmul contract reassoc double %b, %a
%mul1 = fmul contract reassoc double %d, %c
%add = fadd contract reassoc double %mul1, %mul
ret double %add
}
define double @fma_multi_uses1(double %a, double %b, double %c, double %d, double* %p1, double* %p2, double* %p3) {
; CHECK-LABEL: fma_multi_uses1:
; CHECK: # %bb.0:
; CHECK-NEXT: xsmuldp 1, 1, 2
; CHECK-NEXT: xsmuldp 0, 3, 4
; CHECK-NEXT: stfd 1, 0(7)
; CHECK-NEXT: stfd 1, 0(8)
; CHECK-NEXT: xsnmsubadp 1, 3, 4
; CHECK-NEXT: stfd 0, 0(9)
; CHECK-NEXT: blr
%ab = fmul contract reassoc double %a, %b
%cd = fmul contract reassoc double %c, %d
store double %ab, double* %p1 ; extra use of %ab
store double %ab, double* %p2 ; another extra use of %ab
store double %cd, double* %p3 ; extra use of %cd
%r = fsub contract reassoc nsz double %ab, %cd
ret double %r
}
define double @fma_multi_uses2(double %a, double %b, double %c, double %d, double* %p1, double* %p2, double* %p3) {
; CHECK-LABEL: fma_multi_uses2:
; CHECK: # %bb.0:
; CHECK-NEXT: xsmuldp 5, 1, 2
; CHECK-NEXT: xsmuldp 0, 3, 4
; CHECK-NEXT: stfd 5, 0(7)
; CHECK-NEXT: stfd 0, 0(8)
; CHECK-NEXT: stfd 0, 0(9)
; CHECK-NEXT: xsmsubadp 0, 1, 2
; CHECK-NEXT: fmr 1, 0
; CHECK-NEXT: blr
%ab = fmul contract reassoc double %a, %b
%cd = fmul contract reassoc double %c, %d
store double %ab, double* %p1 ; extra use of %ab
store double %cd, double* %p2 ; extra use of %cd
store double %cd, double* %p3 ; another extra use of %cd
%r = fsub contract reassoc double %ab, %cd
ret double %r
}
define double @fma_multi_uses3(double %a, double %b, double %c, double %d, double %f, double %g, double* %p1, double* %p2, double* %p3) {
; CHECK-LABEL: fma_multi_uses3:
; CHECK: # %bb.0:
; CHECK-NEXT: xsmuldp 0, 1, 2
; CHECK-NEXT: xsmuldp 1, 5, 6
; CHECK-NEXT: ld 3, 96(1)
; CHECK-NEXT: stfd 0, 0(9)
; CHECK-NEXT: stfd 0, 0(10)
; CHECK-NEXT: stfd 1, 0(3)
; CHECK-NEXT: xsnmsubadp 1, 3, 4
; CHECK-NEXT: xsnmsubadp 0, 3, 4
; CHECK-NEXT: xsadddp 1, 0, 1
; CHECK-NEXT: blr
%ab = fmul contract reassoc double %a, %b
%cd = fmul contract reassoc double %c, %d
%fg = fmul contract reassoc double %f, %g
store double %ab, double* %p1 ; extra use of %ab
store double %ab, double* %p2 ; another extra use of %ab
store double %fg, double* %p3 ; extra use of %fg
%q = fsub contract reassoc nsz double %fg, %cd ; The uses of %cd reduce to 1 after %r is folded. 2 uses of %fg, fold %cd, remove def of %cd
%r = fsub contract reassoc nsz double %ab, %cd ; Fold %r before %q. 3 uses of %ab, 2 uses of %cd, fold %cd
%add = fadd contract reassoc double %r, %q
ret double %add
}