1d5393526c
When we derive EFMM from SectionMemoryManager, it brings into EFMM extra functionality, such as the registry of exception handling sections, page permission management, etc. Such functionality is of no use to llvm-bolt and can even be detrimental (see https://github.com/llvm/llvm-project/issues/56726). Change the base class of ExecutableFileMemoryManager to MemoryManager, avoid registering EH sections, and skip memory finalization. Fixes #56726 Reviewed By: yota9 Differential Revision: https://reviews.llvm.org/D133994
82 lines
3.0 KiB
C++
82 lines
3.0 KiB
C++
//===- bolt/Rewrite/ExecutableFileMemoryManager.cpp -----------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "bolt/Rewrite/ExecutableFileMemoryManager.h"
|
|
#include "bolt/Rewrite/RewriteInstance.h"
|
|
#include "llvm/Support/MemAlloc.h"
|
|
|
|
#undef DEBUG_TYPE
|
|
#define DEBUG_TYPE "efmm"
|
|
|
|
using namespace llvm;
|
|
using namespace object;
|
|
using namespace bolt;
|
|
|
|
namespace llvm {
|
|
|
|
namespace bolt {
|
|
|
|
uint8_t *ExecutableFileMemoryManager::allocateSection(
|
|
uintptr_t Size, unsigned Alignment, unsigned SectionID,
|
|
StringRef SectionName, bool IsCode, bool IsReadOnly) {
|
|
uint8_t *Ret = static_cast<uint8_t *>(llvm::allocate_buffer(Size, Alignment));
|
|
AllocatedSections.push_back(AllocInfo{Ret, Size, Alignment});
|
|
|
|
// Register a debug section as a note section.
|
|
if (!ObjectsLoaded && RewriteInstance::isDebugSection(SectionName)) {
|
|
BinarySection &Section =
|
|
BC.registerOrUpdateNoteSection(SectionName, Ret, Size, Alignment);
|
|
Section.setSectionID(SectionID);
|
|
assert(!Section.isAllocatable() && "note sections cannot be allocatable");
|
|
return Ret;
|
|
}
|
|
|
|
if (!IsCode && (SectionName == ".strtab" || SectionName == ".symtab" ||
|
|
SectionName == "" || SectionName.startswith(".rela.")))
|
|
return Ret;
|
|
|
|
SmallVector<char, 256> Buf;
|
|
if (ObjectsLoaded > 0) {
|
|
if (BC.isELF()) {
|
|
SectionName = (Twine(SectionName) + ".bolt.extra." + Twine(ObjectsLoaded))
|
|
.toStringRef(Buf);
|
|
} else if (BC.isMachO()) {
|
|
assert((SectionName == "__text" || SectionName == "__data" ||
|
|
SectionName == "__fini" || SectionName == "__setup" ||
|
|
SectionName == "__cstring" || SectionName == "__literal16") &&
|
|
"Unexpected section in the instrumentation library");
|
|
// Sections coming from the instrumentation runtime are prefixed with "I".
|
|
SectionName = ("I" + Twine(SectionName)).toStringRef(Buf);
|
|
}
|
|
}
|
|
|
|
BinarySection &Section = BC.registerOrUpdateSection(
|
|
SectionName, ELF::SHT_PROGBITS,
|
|
BinarySection::getFlags(IsReadOnly, IsCode, true), Ret, Size, Alignment);
|
|
Section.setSectionID(SectionID);
|
|
assert(Section.isAllocatable() &&
|
|
"verify that allocatable is marked as allocatable");
|
|
|
|
LLVM_DEBUG(
|
|
dbgs() << "BOLT: allocating "
|
|
<< (IsCode ? "code" : (IsReadOnly ? "read-only data" : "data"))
|
|
<< " section : " << SectionName << " with size " << Size
|
|
<< ", alignment " << Alignment << " at " << Ret
|
|
<< ", ID = " << SectionID << "\n");
|
|
return Ret;
|
|
}
|
|
|
|
ExecutableFileMemoryManager::~ExecutableFileMemoryManager() {
|
|
for (const AllocInfo &AI : AllocatedSections)
|
|
llvm::deallocate_buffer(AI.Address, AI.Size, AI.Alignment);
|
|
}
|
|
|
|
} // namespace bolt
|
|
|
|
} // namespace llvm
|