8ee9da0232
Close https://github.com/llvm/llvm-project/issues/60996. Previously, clang will try to import function bodies from other module units to get more optimization oppotunities as much as possible. Then the motivation becomes the direct cause of the above issue. However, according to the discussion in SG15, the behavior of importing function bodies from other module units breaks the ABI compatibility. It is unwanted. So the original behavior of clang is incorrect. This patch choose to not import function bodies from other module units in all cases to follow the expectation. Note that the desired optimized BMI idea is discarded too. Since it will still break the ABI compatibility after we import function bodies seperately. The release note will be added seperately. There is a similar issue for variable definitions. I'll try to handle that in a different commit.
77 lines
2.2 KiB
C++
77 lines
2.2 KiB
C++
// RUN: rm -rf %t
|
|
// RUN: split-file %s %t
|
|
//
|
|
// RUN: %clang_cc1 -triple %itanium_abi_triple -std=c++20 %t/M.cppm \
|
|
// RUN: -emit-module-interface -o %t/M.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/Use.cpp -fprebuilt-module-path=%t \
|
|
// RUN: -triple %itanium_abi_triple \
|
|
// RUN: -S -emit-llvm -o - -disable-llvm-passes \
|
|
// RUN: | FileCheck %t/Use.cpp --check-prefix=CHECK-O0
|
|
//
|
|
// RUN: %clang_cc1 -triple %itanium_abi_triple -std=c++20 -O1 %t/M.cppm \
|
|
// RUN: -emit-module-interface -o %t/M.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/Use.cpp -fprebuilt-module-path=%t -O1 \
|
|
// RUN: -triple %itanium_abi_triple \
|
|
// RUN: -S -emit-llvm -o - -disable-llvm-passes | \
|
|
// RUN: FileCheck %t/Use.cpp --check-prefix=CHECK-O1
|
|
|
|
//--- foo.h
|
|
int func_in_gmf() {
|
|
return 43;
|
|
}
|
|
int func_in_gmf_not_called() {
|
|
return 44;
|
|
}
|
|
|
|
//--- M.cppm
|
|
module;
|
|
#include "foo.h"
|
|
export module M;
|
|
int non_exported_func() {
|
|
return 43 + func_in_gmf();
|
|
}
|
|
export int exported_func() {
|
|
return non_exported_func();
|
|
}
|
|
|
|
int non_exported_func_not_called() {
|
|
return 44;
|
|
}
|
|
export int func_not_called() {
|
|
return non_exported_func_not_called();
|
|
}
|
|
|
|
export
|
|
__attribute__((always_inline))
|
|
int always_inline_func() {
|
|
return 45;
|
|
}
|
|
|
|
//--- Use.cpp
|
|
import M;
|
|
int use() {
|
|
return exported_func() + always_inline_func();
|
|
}
|
|
|
|
// Checks that none of the function (except the always_inline_func) in the importees
|
|
// are generated in the importer's code.
|
|
// CHECK-O0: define{{.*}}_Z3usev(
|
|
// CHECK-O0: declare{{.*}}_ZW1M13exported_funcv(
|
|
// CHECK-O0: define{{.*}}available_externally{{.*}}_ZW1M18always_inline_funcv(
|
|
// CHECK-O0-NOT: func_in_gmf
|
|
// CHECK-O0-NOT: func_in_gmf_not_called
|
|
// CHECK-O0-NOT: non_exported_func
|
|
// CHECK-O0-NOT: non_exported_func_not_called
|
|
// CHECK-O0-NOT: func_not_called
|
|
|
|
// Checks that the generated code within optimizations keep the same behavior with
|
|
// O0 to keep consistent ABI.
|
|
// CHECK-O1: define{{.*}}_Z3usev(
|
|
// CHECK-O1: declare{{.*}}_ZW1M13exported_funcv(
|
|
// CHECK-O1: define{{.*}}available_externally{{.*}}_ZW1M18always_inline_funcv(
|
|
// CHECK-O1-NOT: func_in_gmf
|
|
// CHECK-O1-NOT: func_in_gmf_not_called
|
|
// CHECK-O1-NOT: non_exported_func
|
|
// CHECK-O1-NOT: non_exported_func_not_called
|
|
// CHECK-O1-NOT: func_not_called
|