46f3ade508
Previously clang AST prints the following declaration:
int fun_var_unused() {
int x __attribute__((unused)) = 0;
return x;
}
and
int __declspec(thread) x = 0;
as:
int fun_var_unused() {
int x = 0 __attribute__((unused));
return x;
}
and
int x = __declspec(thread) 0;
which is rejected by C/C++ parser. This patch modifies the logic to
print old C attributes for variables as:
int __attribute__((unused)) x = 0;
and the __declspec case as:
int __declspec(thread) x = 0;
Fixes: https://github.com/llvm/llvm-project/issues/59973
Previous version: D141714.
Differential Revision:https://reviews.llvm.org/D141714
92 lines
2.9 KiB
C++
92 lines
2.9 KiB
C++
// RUN: %clang_cc1 -verify -fopenmp -ast-print %s | FileCheck %s
|
|
// RUN: %clang_cc1 -fopenmp -x c++ -std=c++11 -emit-pch -o %t %s
|
|
// RUN: %clang_cc1 -fopenmp -std=c++11 -include-pch %t -fsyntax-only -verify %s -ast-print | FileCheck %s
|
|
|
|
// RUN: %clang_cc1 -verify -fopenmp-simd -ast-print %s | FileCheck %s
|
|
// RUN: %clang_cc1 -fopenmp-simd -x c++ -std=c++11 -emit-pch -o %t %s
|
|
// RUN: %clang_cc1 -fopenmp-simd -std=c++11 -include-pch %t -fsyntax-only -verify %s -ast-print | FileCheck %s
|
|
// expected-no-diagnostics
|
|
|
|
// It is unclear if we want to annotate the template instantiations, e.g., S<int>::foo, or not in the two
|
|
// situations shown below. Since it is always fair to drop assumptions, we do that for now.
|
|
|
|
#ifndef HEADER
|
|
#define HEADER
|
|
|
|
template <typename T>
|
|
struct S {
|
|
int a;
|
|
// CHECK: template <typename T> struct S {
|
|
// CHECK: __attribute__((assume("ompx_global_assumption"))) void foo() {
|
|
void foo() {
|
|
#pragma omp parallel
|
|
{}
|
|
}
|
|
};
|
|
|
|
// CHECK: template<> struct S<int> {
|
|
// CHECK: __attribute__((assume("ompx_global_assumption"))) void foo() {
|
|
|
|
#pragma omp begin assumes no_openmp
|
|
// CHECK: __attribute__((assume("omp_no_openmp"))) __attribute__((assume("ompx_global_assumption"))) void S_with_assumes_no_call() {
|
|
void S_with_assumes_no_call() {
|
|
S<int> s;
|
|
s.a = 0;
|
|
}
|
|
// CHECK: __attribute__((assume("omp_no_openmp"))) __attribute__((assume("ompx_global_assumption"))) void S_with_assumes_call() {
|
|
void S_with_assumes_call() {
|
|
S<int> s;
|
|
s.a = 0;
|
|
// If this is executed we have UB!
|
|
s.foo();
|
|
}
|
|
#pragma omp end assumes
|
|
|
|
// CHECK: __attribute__((assume("ompx_global_assumption"))) void S_without_assumes() {
|
|
void S_without_assumes() {
|
|
S<int> s;
|
|
s.foo();
|
|
}
|
|
|
|
#pragma omp assumes ext_global_assumption
|
|
|
|
// Same as the struct S above but the order in which we instantiate P is different, first outside of an assumes.
|
|
template <typename T>
|
|
struct P {
|
|
// CHECK: template <typename T> struct P {
|
|
// CHECK: __attribute__((assume("ompx_global_assumption"))) void foo() {
|
|
int a;
|
|
void foo() {
|
|
#pragma omp parallel
|
|
{}
|
|
}
|
|
};
|
|
|
|
// TODO: Avoid the duplication here:
|
|
|
|
// CHECK: template<> struct P<int> {
|
|
// CHECK: __attribute__((assume("ompx_global_assumption"))) __attribute__((assume("ompx_global_assumption"))) void foo() {
|
|
|
|
// CHECK: __attribute__((assume("ompx_global_assumption"))) void P_without_assumes() {
|
|
void P_without_assumes() {
|
|
P<int> p;
|
|
p.foo();
|
|
}
|
|
|
|
#pragma omp begin assumes no_openmp
|
|
// CHECK: __attribute__((assume("omp_no_openmp"))) __attribute__((assume("ompx_global_assumption"))) void P_with_assumes_no_call() {
|
|
void P_with_assumes_no_call() {
|
|
P<int> p;
|
|
p.a = 0;
|
|
}
|
|
// CHECK: __attribute__((assume("omp_no_openmp"))) __attribute__((assume("ompx_global_assumption"))) void P_with_assumes_call() {
|
|
void P_with_assumes_call() {
|
|
P<int> p;
|
|
p.a = 0;
|
|
// If this is executed we have UB!
|
|
p.foo();
|
|
}
|
|
#pragma omp end assumes
|
|
|
|
#endif
|