We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
170 lines
5.4 KiB
C
170 lines
5.4 KiB
C
// RUN: %clang_cc1 -triple %itanium_abi_triple %s -fsyntax-only -verify -pedantic
|
|
enum e {A,
|
|
B = 42LL << 32, // expected-warning {{ISO C restricts enumerator values to range of 'int'}}
|
|
C = -4, D = 12456 };
|
|
|
|
enum f { a = -2147483648, b = 2147483647 }; // ok.
|
|
|
|
enum g { // too negative
|
|
c = -2147483649, // expected-warning {{ISO C restricts enumerator values to range of 'int'}}
|
|
d = 2147483647 };
|
|
enum h { e = -2147483648, // too pos
|
|
f = 2147483648, // expected-warning {{ISO C restricts enumerator values to range of 'int'}}
|
|
i = 0xFFFF0000 // expected-warning {{too large}}
|
|
};
|
|
|
|
// minll maxull
|
|
enum x // expected-warning {{enumeration values exceed range of largest integer}}
|
|
{ y = -9223372036854775807LL-1, // expected-warning {{ISO C restricts enumerator values to range of 'int'}}
|
|
z = 9223372036854775808ULL }; // expected-warning {{ISO C restricts enumerator values to range of 'int'}}
|
|
|
|
int test(void) {
|
|
return sizeof(enum e) ;
|
|
}
|
|
|
|
enum gccForwardEnumExtension ve; // expected-warning{{ISO C forbids forward references to 'enum' types}} \
|
|
// expected-error{{tentative definition has type 'enum gccForwardEnumExtension' that is never completed}} \
|
|
// expected-note{{forward declaration of 'enum gccForwardEnumExtension'}}
|
|
|
|
int test2(int i)
|
|
{
|
|
ve + i; // expected-error{{invalid operands to binary expression}}
|
|
}
|
|
|
|
// PR2020
|
|
union u0; // expected-note {{previous use is here}}
|
|
enum u0 { U0A }; // expected-error {{use of 'u0' with tag type that does not match previous declaration}}
|
|
|
|
extern enum some_undefined_enum ve2; // expected-warning {{ISO C forbids forward references to 'enum' types}}
|
|
|
|
void test4(void) {
|
|
for (; ve2;) // expected-error {{statement requires expression of scalar type}}
|
|
;
|
|
(_Bool)ve2; // expected-error {{arithmetic or pointer type is required}}
|
|
|
|
for (; ;ve2) // expected-warning {{expression result unused}}
|
|
;
|
|
(void)ve2;
|
|
ve2; // expected-warning {{expression result unused}}
|
|
}
|
|
|
|
// PR2416
|
|
enum someenum {}; // expected-error {{use of empty enum}}
|
|
|
|
enum e0 { // expected-note {{previous definition is here}}
|
|
E0 = sizeof(enum e0 { E1 }), // expected-error {{nested redefinition}}
|
|
};
|
|
|
|
// PR3173
|
|
enum { PR3173A, PR3173B = PR3173A+50 };
|
|
|
|
// PR2753
|
|
void foo(void) {
|
|
enum xpto; // expected-warning{{ISO C forbids forward references to 'enum' types}}
|
|
enum xpto; // expected-warning{{ISO C forbids forward references to 'enum' types}}
|
|
}
|
|
|
|
typedef enum { X = 0 }; // expected-warning{{typedef requires a name}}
|
|
|
|
|
|
enum NotYetComplete { // expected-note{{definition of 'enum NotYetComplete' is not complete until the closing '}'}}
|
|
NYC1 = sizeof(enum NotYetComplete) // expected-error{{invalid application of 'sizeof' to an incomplete type 'enum NotYetComplete'}}
|
|
};
|
|
|
|
/// PR3688
|
|
struct s1 {
|
|
enum e1 (*bar)(void); // expected-warning{{ISO C forbids forward references to 'enum' types}}
|
|
};
|
|
|
|
enum e1 { YES, NO };
|
|
|
|
static enum e1 badfunc(struct s1 *q) {
|
|
return q->bar();
|
|
}
|
|
|
|
|
|
// Make sure we don't a.k.a. anonymous enums.
|
|
typedef enum {
|
|
an_enumerator = 20
|
|
} an_enum;
|
|
char * s = (an_enum) an_enumerator; // expected-error {{incompatible integer to pointer conversion initializing 'char *' with an expression of type 'an_enum'}}
|
|
|
|
// PR4515
|
|
enum PR4515 {PR4515a=1u,PR4515b=(PR4515a-2)/2};
|
|
int CheckPR4515[PR4515b==0?1:-1];
|
|
|
|
// PR7911
|
|
extern enum PR7911T PR7911V; // expected-warning{{ISO C forbids forward references to 'enum' types}}
|
|
void PR7911F(void) {
|
|
switch (PR7911V) // expected-error {{statement requires expression of integer type}}
|
|
;
|
|
}
|
|
|
|
char test5[__has_feature(enumerator_attributes) ? 1 : -1];
|
|
|
|
// PR8694
|
|
void PR8694(int* e) // expected-note {{passing argument to parameter 'e' here}}
|
|
{
|
|
}
|
|
|
|
void crash(enum E* e) // expected-warning {{declaration of 'enum E' will not be visible outside of this function}} \
|
|
// expected-warning {{ISO C forbids forward references to 'enum' types}}
|
|
{
|
|
PR8694(e); // expected-warning {{incompatible pointer types passing 'enum E *' to parameter of type 'int *'}}
|
|
}
|
|
|
|
typedef enum { NegativeShort = (short)-1 } NegativeShortEnum;
|
|
int NegativeShortTest[NegativeShort == -1 ? 1 : -1];
|
|
|
|
// PR24610
|
|
enum Color { Red, Green, Blue }; // expected-note{{previous use is here}}
|
|
typedef struct Color NewColor; // expected-error {{use of 'Color' with tag type that does not match previous declaration}}
|
|
|
|
// PR28903
|
|
// In C it is valid to define tags inside enums.
|
|
struct PR28903 {
|
|
enum {
|
|
PR28903_A = (enum {
|
|
PR28903_B,
|
|
PR28903_C = PR28903_B
|
|
})0
|
|
};
|
|
int makeStructNonEmpty;
|
|
};
|
|
|
|
static int EnumRedecl; // expected-note 2 {{previous definition is here}}
|
|
struct S {
|
|
enum {
|
|
EnumRedecl = 4 // expected-error {{redefinition of 'EnumRedecl'}}
|
|
} e;
|
|
};
|
|
|
|
union U {
|
|
enum {
|
|
EnumRedecl = 5 // expected-error {{redefinition of 'EnumRedecl'}}
|
|
} e;
|
|
};
|
|
|
|
enum PR15071 {
|
|
PR15071_One // expected-note {{previous definition is here}}
|
|
};
|
|
|
|
struct EnumRedeclStruct {
|
|
enum {
|
|
PR15071_One // expected-error {{redefinition of enumerator 'PR15071_One'}}
|
|
} e;
|
|
};
|
|
|
|
enum struct GH42372_1 { // expected-error {{expected identifier or '{'}}
|
|
One
|
|
};
|
|
|
|
// Because class is not a keyword in C, this looks like a forward declaration.
|
|
// expected-error@+4 {{expected ';' after top level declarator}}
|
|
// expected-error@+3 {{tentative definition has type 'enum class' that is never completed}}
|
|
// expected-warning@+2 {{ISO C forbids forward references to 'enum' types}}
|
|
// expected-note@+1 {{forward declaration of 'enum class'}}
|
|
enum class GH42372_2 {
|
|
One
|
|
};
|