caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
1daf2994de49d1ecba4bee4e6842aa8a564cbc96
clang-p2996/clang/test/SemaObjCXX
History
Aaron Ballman 84a3aadf0f Diagnose use of VLAs in C++ by default 
Reapplication of 7339c0f782 with a fix
for a crash involving arrays without a size expression.

Clang supports VLAs in C++ as an extension, but we currently only warn
on their use when you pass -Wvla, -Wvla-extension, or -pedantic.
However, VLAs as they're expressed in C have been considered by WG21
and rejected, are easy to use accidentally to the surprise of users
(e.g., https://ddanilov.me/default-non-standard-features/), and they
have potential security implications beyond constant-size arrays
(https://wiki.sei.cmu.edu/confluence/display/c/ARR32-C.+Ensure+size+arguments+for+variable+length+arrays+are+in+a+valid+range).
C++ users should strongly consider using other functionality such as
std::vector instead.

This seems like sufficiently compelling evidence to warn users about
VLA use by default in C++ modes. This patch enables the -Wvla-extension
diagnostic group in C++ language modes by default, and adds the warning
group to -Wall in GNU++ language modes. The warning is still opt-in in
C language modes, where support for VLAs is somewhat less surprising to
users.

RFC: https://discourse.llvm.org/t/rfc-diagnosing-use-of-vlas-in-c/73109
Fixes https://github.com/llvm/llvm-project/issues/62836
Differential Revision: https://reviews.llvm.org/D156565
2023-10-20 13:10:03 -04:00
..
Inputs
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
abstract-class-type-ivar.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
arc-0x.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
arc-bool-conversion.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
arc-bridged-cast.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
arc-libstdcxx.mm
…
arc-memfunc.mm
…
arc-nsconsumed-errors.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
arc-objc-lifetime.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
arc-overloading.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
arc-ppe.mm
…
arc-ptr-comparison.mm
…
arc-system-header.mm
…
arc-templates.mm
…
arc-type-conversion.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
arc-type-traits.mm
…
arc-unavailable-for-weakref.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
arc-unbridged-cast.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
argument-dependent-lookup.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
attr-swift_name-cxx.mm
…
attr-trivial-abi.mm
…
base-type-as-written.mm
…
block-capture.mm
[clang] Use -std=c++23 instead of -std=c++2b
2023-05-04 19:19:52 +02:00
block-cleanup.mm
…
block-for-lambda-conversion.mm
…
block-variable-move.mm
…
blocks.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
boxing-illegal-types.mm
…
bridge-cast-redecl.mm
…
builtin-objcsuper.mm
…
capturing-flexible-array-in-block.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
category-lookup.mm
…
class-method-self.mm
…
class-templ-error-null-init.mm
…
composite-objc-pointertype.mm
…
comptypes-1.mm
…
comptypes-7.mm
…
conditional-expr.mm
…
const-cast.mm
…
contextual-convert-to-id.mm
…
conversion-ranking.mm
…
conversion-to-objc-pointer-2.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
conversion-to-objc-pointer.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
crash.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
cstyle-block-pointer-cast.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
cstyle-cast.mm
…
cxx1y-lambda.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
cxxoperator-selector.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
debugger-cast-result-to-id.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
debugger-support.mm
…
decltype.mm
…
deduction.mm
…
delay-parsing-cfunctions.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
delay-parsing-cplusfuncs.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
delay-parsing-func-tryblock.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
dllexport.mm
…
dllimport.mm
…
exceptions-fragile.mm
…
exceptions.mm
…
expr-objcxx.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
flexible-array.mm
Revert "[clang] Reject flexible array member in a union in C++"
2023-05-03 09:25:03 -04:00
foreach-block.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
foreach.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
format-strings.mm
…
fragile-abi-object-assign.m
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
function-pointer-void-star.mm
…
gc-attributes.mm
…
goto.mm
…
instancetype.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
instantiate-expr.mm
…
instantiate-message.mm
…
instantiate-method-return.mm
…
instantiate-property-access.mm
…
instantiate-stmt.mm
…
interface-return-type.mm
…
is-base-of.mm
…
ivar-construct.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
ivar-lookup.mm
…
ivar-reference-type.mm
…
ivar-struct.mm
Mark an ObjCIvarDecl as invalid if its type contains errors (#68001)
2023-10-02 12:46:00 -07:00
linkage-spec.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
lit.local.cfg
[NFC][Py Reformat] Reformat python files in clang and clang-tools-extra
2023-05-23 08:29:52 +02:00
literals.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
message.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
microsoft-abi-byval.mm
…
missing-lhs-gun-extension.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
namespace-lookup.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
no-crash-thread-safety-analysis.mm
…
noescape.mm
…
NSString-type.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
null_objc_pointer.mm
…
nullability-completeness-cferror.mm
…
nullability-consistency-arrays.mm
…
nullability-consistency.mm
…
nullability-pragmas.mm
…
nullptr.mm
…
objc2-merge-gc-attribue-decl.mm
…
objc-boxed-expressions-nsvalue.mm
…
objc-container-subscripting.mm
…
objc-decls-inside-namespace.mm
…
objc-extern-c.mm
…
objc-pointer-conv.mm
…
objc-weak-type-traits.mm
…
objc-weak.mm
…
objcbridge-attribute-arc.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
objcbridge-attribute.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
objcbridge-related-attribute.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
objcbridge-static-cast.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
objcxx_openmp.mm
…
old-style-cast.mm
…
overload-gc.mm
…
overload.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
parameterized_classes_arc.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
parameterized_classes_subst.mm
…
parameterized_classes.mm
…
parameters.mm
[Clang] Check for abstract parameters only when functions are defined.
2023-06-07 21:44:14 +02:00
pointer-to-objc-pointer-conv.mm
…
pr32725.mm
…
propert-dot-error.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
properties.mm
Diagnose use of VLAs in C++ by default
2023-10-20 13:10:03 -04:00
property-invalid-type.mm
…
property-reference.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
property-synthesis-error.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
property-type-mismatch.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
protocol-lookup.mm
…
pseudo-destructor.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
references.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
reinterpret-cast-objc-pointertype.mm
…
related-result-type-inference.mm
…
reserved-keyword-methods.mm
…
sel-address.mm
…
standard-conversion-to-bool.mm
…
static-cast.mm
…
synchronized.mm
…
thread-safety-analysis.h
…
type-traits-is-pointer.mm
…
typeloc-data-alignment.mm
…
typo-correction.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
unknown-anytype.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
unsupported-signature-std-addressof-id.mm
…
vararg-non-pod.mm
…
vla.mm
Diagnose use of VLAs in C++ by default
2023-10-20 13:10:03 -04:00
void_to_obj.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
warn-called-once.mm
…
warn-implicit-self-in-block.mm
[clang] Remove rdar links; NFC
2023-08-28 12:13:42 -04:00
warn-missing-super.mm
…
warn-objc-literal-conversion.mm
…
warn-strict-selector-match.mm
…
warn-thread-safety-analysis.mm
…