1981b1b6b9
When an input section is matched by /DISCARD/ in a linker script, GNU ld
reports errors for relocations referencing symbols defined in the section:
`.aaa' referenced in section `.bbb' of a.o: defined in discarded section `.aaa' of a.o
Implement the error by demoting eligible symbols to `Undefined` and changing
STB_WEAK to STB_GLOBAL. As a side benefit, in relocatable links, relocations
referencing symbols defined relative to /DISCARD/ discarded sections no longer
set symbol/type to zeros.
It's arguable whether a weak reference to a discarded symbol should lead to
errors. GNU ld reports an error and our demoting approach reports an error as
well.
Close #58891
Co-authored-by: Bevin Hansson <bevin.hansson@ericsson.com>
84 lines
3.6 KiB
ArmAsm
84 lines
3.6 KiB
ArmAsm
# REQUIRES: x86
|
|
## Test relocations referencing symbols defined relative to sections discarded by /DISCARD/.
|
|
|
|
# RUN: rm -rf %t && split-file %s %t && cd %t
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 a.s -o a.o
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 b.s -o b.o
|
|
# RUN: not ld.lld --threads=1 -T a.lds a.o b.o -z undefs -o /dev/null 2>&1 | FileCheck %s --check-prefix=LOCAL --implicit-check-not=error:
|
|
# RUN: not ld.lld --threads=1 -T a.lds a.o b.o -o /dev/null 2>&1 | FileCheck %s --check-prefixes=LOCAL,NONLOCAL --implicit-check-not=error:
|
|
# RUN: ld.lld -r -T a.lds a.o b.o -o a.ro 2>&1 | FileCheck %s --check-prefix=WARNING --implicit-check-not=warning:
|
|
# RUN: llvm-readelf -r -s a.ro | FileCheck %s --check-prefix=RELOC
|
|
|
|
# LOCAL: error: relocation refers to a discarded section: .aaa
|
|
# LOCAL-NEXT: >>> defined in a.o
|
|
# LOCAL-NEXT: >>> referenced by a.o:(.bbb+0x0)
|
|
|
|
# NONLOCAL: error: relocation refers to a symbol in a discarded section: global
|
|
# NONLOCAL-NEXT: >>> defined in a.o
|
|
# NONLOCAL-NEXT: >>> referenced by b.o:(.data+0x0)
|
|
|
|
# NONLOCAL: error: relocation refers to a symbol in a discarded section: weak
|
|
# NONLOCAL-NEXT: >>> defined in a.o
|
|
# NONLOCAL-NEXT: >>> referenced by b.o:(.data+0x8)
|
|
|
|
# NONLOCAL: error: relocation refers to a symbol in a discarded section: weakref1
|
|
# NONLOCAL-NEXT: >>> defined in a.o
|
|
# NONLOCAL-NEXT: >>> referenced by b.o:(.data+0x10)
|
|
|
|
# NONLOCAL: error: relocation refers to a symbol in a discarded section: weakref2
|
|
# NONLOCAL-NEXT: >>> defined in a.o
|
|
# NONLOCAL-NEXT: >>> referenced by b.o:(.data+0x18)
|
|
|
|
# WARNING: warning: relocation refers to a discarded section: .aaa
|
|
# WARNING-NEXT: >>> referenced by a.o:(.rela.bbb+0x0)
|
|
|
|
# RELOC: Relocation section '.rela.bbb' at offset {{.*}} contains 1 entries:
|
|
# RELOC-NEXT: Offset Info Type Symbol's Value Symbol's Name + Addend
|
|
# RELOC-NEXT: 0000000000000000 0000000000000000 R_X86_64_NONE 0
|
|
# RELOC-EMPTY:
|
|
# RELOC-NEXT: Relocation section '.rela.data' at offset {{.*}} contains 4 entries:
|
|
# RELOC-NEXT: Offset Info Type Symbol's Value Symbol's Name + Addend
|
|
# RELOC-NEXT: 0000000000000000 0000000500000001 R_X86_64_64 0000000000000000 global + 0
|
|
# RELOC-NEXT: 0000000000000008 0000000700000001 R_X86_64_64 0000000000000000 weak + 0
|
|
# RELOC-NEXT: 0000000000000010 0000000600000001 R_X86_64_64 0000000000000000 weakref1 + 0
|
|
# RELOC-NEXT: 0000000000000018 0000000800000001 R_X86_64_64 0000000000000000 weakref2 + 0
|
|
|
|
# RELOC: Num: Value Size Type Bind Vis Ndx Name
|
|
# RELOC-NEXT: 0: 0000000000000000 0 NOTYPE LOCAL DEFAULT UND
|
|
# RELOC-NEXT: 1: 0000000000000000 0 SECTION LOCAL DEFAULT 1 .text
|
|
# RELOC-NEXT: 2: 0000000000000000 0 SECTION LOCAL DEFAULT 2 .bbb
|
|
# RELOC-NEXT: 3: 0000000000000000 0 SECTION LOCAL DEFAULT 4 .data
|
|
# RELOC-NEXT: 4: 0000000000000000 0 NOTYPE GLOBAL DEFAULT 1 _start
|
|
# RELOC-NEXT: 5: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND global
|
|
# RELOC-NEXT: 6: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND weakref1
|
|
# RELOC-NEXT: 7: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND weak
|
|
# RELOC-NEXT: 8: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND weakref2
|
|
# RELOC-EMPTY:
|
|
|
|
#--- a.s
|
|
.globl _start
|
|
_start:
|
|
|
|
.section .aaa,"a"
|
|
.globl global, weakref1
|
|
.weak weak, weakref2
|
|
global:
|
|
weak:
|
|
weakref1:
|
|
weakref2:
|
|
.quad 0
|
|
|
|
.section .bbb,"aw"
|
|
.quad .aaa
|
|
|
|
#--- b.s
|
|
.weak weakref1, weakref2
|
|
.section .data,"aw"
|
|
.quad global
|
|
.quad weak
|
|
.quad weakref1
|
|
.quad weakref2
|
|
|
|
#--- a.lds
|
|
SECTIONS { /DISCARD/ : { *(.aaa) } }
|